Upgrade jquery to 3.2.1

Comes with a feature removal that needed to be taken care of

static/functions/browse.js

@@ -185,7 +185,7 @@ function toggle_edition(groupid, editionid, lnk, event) {
   var showing = $(clickedRow).nextElementSibling().has_class('hidden');
   var allEditions = event.ctrlKey;
   var group_rows = $('tr.groupid_' + groupid);
-  for (var i = 0; i < group_rows.results(); i++) {
+  for (var i = 0; i < group_rows.length; i++) {
     var row = $(group_rows.raw(i));
     if (row.has_class('edition') && (allEditions || row.raw(0) == clickedRow)) {
       var tooltip = showing

static/functions/comments.js

@@ -116,7 +116,7 @@ function Edit_Form(post,key) {
   postid = post;
   var boxWidth, postuserid, pmbox, inputname;
   //If no edit is already going underway or a previous edit was finished, make the necessary dom changes.
-  if (!$('#editbox' + postid).results() || $('#editbox' + postid + '.hidden').results()) {
+  if (!$('#editbox' + postid).length || $('#editbox' + postid + '.hidden').length) {
     $('#reply_box').ghide();
     boxWidth = (location.href.match(/torrents\.php/) || location.href.match(/artist\.php/)) ? "50" : "80";
     postuserid = $('#post' + postid + ' strong a').attr('href').split('=')[1];

static/functions/donor_titles.js

@@ -1,5 +1,5 @@
 $(document).ready(function() {
-  if ($('#donor_title_prefix_preview').size() === 0) {
+  if ($('#donor_title_prefix_preview').length === 0) {
     return;
   }
   $('#donor_title_prefix_preview').text($('#donor_title_prefix').val().trim() + ' ');

static/functions/global.js

@@ -35,16 +35,13 @@ function save_message(message, err = false) {
 }
 
 $.fn.extend({
-  results: function () {
-    return this.size();
-  },
-  gshow: function () {
+  gshow: function() {
     return this.remove_class('hidden');
   },
-  ghide: function (force) {
+  ghide: function(force) {
     return this.add_class('hidden', force);
   },
-  gtoggle: function (force) {
+  gtoggle: function(force) {
     if (this[0].className.split(' ').indexOf('hidden') == -1) {
       this.add_class('hidden', force);
     } else {
@@ -52,8 +49,8 @@ $.fn.extend({
     }
     return this;
   },
-  listen: function (event, callback) {
-    for (var i = 0, il = this.size(); i < il; i++) {
+  listen: function(event, callback) {
+    for (var i = 0; i < this.length; i++) {
       var object = this[i];
       if (document.addEventListener) {
         object.addEventListener(event, callback, false);
@@ -63,8 +60,8 @@ $.fn.extend({
     }
     return this;
   },
-  add_class: function (class_name, force) {
-    for (var i = 0, il = this.size(); i < il; i++) {
+  add_class: function(class_name, force) {
+    for (var i = 0; i < this.length; i++) {
       var object = this[i];
       if (object.className === '') {
         object.className = class_name;
@@ -74,8 +71,8 @@ $.fn.extend({
     }
     return this;
   },
-  remove_class: function (class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
+  remove_class: function(class_name) {
+    for (var i = 0; i < this.length; i++) {
       var object = this[i];
       var classes = object.className.split(' ');
       var result = classes.indexOf(class_name);
@@ -87,7 +84,7 @@ $.fn.extend({
     return this;
   },
   has_class: function(class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
+    for (var i = 0; i < this.length; i++) {
       var object = this[i];
       var classes = object.className.split(' ');
       if (classes.indexOf(class_name) != -1) {
@@ -97,7 +94,7 @@ $.fn.extend({
     return false;
   },
   toggle_class: function(class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
+    for (var i = 0, il; i < this.length; i++) {
       var object = this[i];
       var classes = object.className.split(' ');
       var result = classes.indexOf(class_name);
@@ -114,21 +111,21 @@ $.fn.extend({
     }
     return this;
   },
-  disable : function () {
+  disable : function() {
     $(this).prop('disabled', true);
     return this;
   },
-  enable : function () {
+  enable : function() {
     $(this).prop('disabled', false);
     return this;
   },
-  raw: function (number) {
+  raw: function(number) {
     if (typeof number == 'undefined') {
       number = 0;
     }
     return $(this).get(number);
   },
-  nextElementSibling: function () {
+  nextElementSibling: function() {
     var here = this[0];
     if (here.nextElementSibling) {
       return $(here.nextElementSibling);
@@ -138,7 +135,7 @@ $.fn.extend({
     } while (here.nodeType != 1);
     return $(here);
   },
-  previousElementSibling: function () {
+  previousElementSibling: function() {
     var here = this[0];
     if (here.previousElementSibling) {
       return $(here.previousElementSibling);

static/functions/jquery.validate.js

@@ -439,7 +439,7 @@ $.extend($.validator, {
     },
 
     valid: function() {
-      return this.size() === 0;
+      return this.length === 0;
     },
 
     size: function() {

static/functions/notifications.js

@@ -30,7 +30,7 @@ $(document).ready(function () {
     var nextBox, index = notifyBoxes.index($(this));
     if (index > 0 && e.which === 75) { // K
       nextBox = notifyBoxes.get(index-1);
-    } else if (index < notifyBoxes.size()-1 && e.which === 74) { // J
+    } else if (index < notifyBoxes.length-1 && e.which === 74) { // J
       nextBox = notifyBoxes.get(index+1);
     } else if (e.which === 88) {
       $(this).prop('checked', !$(this).prop('checked'));

static/functions/reportsv2.js

@@ -57,7 +57,7 @@ function TakeResolve(reportid) {
     if (response) {
       ErrorBox(reportid, response);
     } else {
-      if ($('#from_delete' + reportid).size()) {
+      if ($('#from_delete' + reportid).length) {
         window.location.search = '?id=' + $('#from_delete' + reportid).val();
       } else {
         $('#report' + reportid).remove();
@@ -81,16 +81,16 @@ function NewReport(q, view, id) {
     if (response) {
       var div = $(response);
       var id = div.data("reportid");
-      if (!$('#report'+id).size()) {
+      if (!$('#report'+id).length) {
         $('#all_reports').append(div);
         $('#no_reports').remove();
-        if ($('#type', div).size()) {
+        if ($('#type', div).length) {
           Load(id);
         }
       }
     } else {
       // No new reports at this time
-      if (!$('.report').size() && !$('#no_reports') == 0) {
+      if (!$('.report').length && !$('#no_reports') == 0) {
         $('#all_reports').append($('<div id="no_reports" class="box pad center"><strong>No new reports! \o/</strong></div>'));
       }
     }
@@ -104,7 +104,7 @@ function NewReport(q, view, id) {
 function AddMore(view, id) {
   // Function will add the amount of reports in the input box unless that will take it over 50
   var num = parseInt($('#repop_amount').val()) || 10;
-  var curCount = $('.report').size();
+  var curCount = $('.report').length;
   if (curCount < 50) {
     NewReport(Math.min(num, 50 - curCount), view, id)
   }

static/functions/requests.js

@@ -39,7 +39,7 @@ function Vote(amount, requestid) {
         votecount.innerHTML = (parseInt(votecount.innerHTML)) + 1;
       }
 
-      if ($('#total_bounty').results() > 0) {
+      if ($('#total_bounty').length > 0) {
         totalBounty = parseInt($('#total_bounty').raw().value);
         totalBounty += (amount * (1 - $('#request_tax').raw().value));
         $('#total_bounty').raw().value = totalBounty;

static/functions/subscriptions.js

@@ -30,7 +30,7 @@ function SubscribeComments(page, pageid) {
 function Collapse() {
   var collapseLink = $('#collapselink').raw();
   var hide = (collapseLink.innerHTML.substr(0,1) == 'H' ? 1 : 0);
-  if ($('.row').results() > 0) {
+  if ($('.row').length > 0) {
     $('.row').gtoggle();
   }
   if (hide) {

static/functions/torrent.js

@@ -174,7 +174,7 @@ function Vote(amount, requestid) {
         votecount.innerHTML = (parseInt(votecount.innerHTML)) + 1;
       }
 
-      if ($('#total_bounty').results() > 0) {
+      if ($('#total_bounty').length > 0) {
         totalBounty = parseInt($('#total_bounty').raw().value);
         totalBounty += (amount * (1 - $('#request_tax').raw().value));
         $('#total_bounty').raw().value = totalBounty;

static/functions/user.js

@@ -87,7 +87,7 @@ function AlterParanoia() {
 
 function ParanoiaReset(checkbox, drops) {
   var selects = $('select');
-  for (var i = 0; i < selects.results(); i++) {
+  for (var i = 0; i < selects.length; i++) {
     if (selects.raw(i).name.match(/^p_/)) {
       if (drops == 0) {
         selects.raw(i).selectedIndex = 0;
@@ -100,7 +100,7 @@ function ParanoiaReset(checkbox, drops) {
     }
   }
   var checkboxes = $(':checkbox');
-  for (var i = 0; i < checkboxes.results(); i++) {
+  for (var i = 0; i < checkboxes.length; i++) {
     if (checkboxes.raw(i).name.match(/^p_/) && (checkboxes.raw(i).name != 'p_lastseen')) {
       if (checkbox == 3) {
         checkboxes.raw(i).checked = !(checkboxes.raw(i).name.match(/_list$/) || checkboxes.raw(i).name.match(/_l$/));
@@ -142,7 +142,7 @@ function ToggleWarningAdjust(selector) {
 document.addEventListener("DOMContentLoaded", ToggleIdenticons);
 function ToggleIdenticons() {
   var disableAvatars = $('#disableavatars');
-  if (disableAvatars.size()) {
+  if (disableAvatars.length) {
     var selected = disableAvatars[0].selectedIndex;
     if (selected == 2 || selected == 3) {
       $('#identicons').gshow();