Browse Source

Use MySQL date constructs instead of composing date strings in PHP and shoving them into queries

spaghetti 7 years ago
parent
commit
b1cce49ee7

+ 2
- 2
sections/schedule/daily/delete_dead_torrents.php View File

12
   FROM torrents AS t
12
   FROM torrents AS t
13
     JOIN torrents_group AS tg ON tg.ID = t.GroupID
13
     JOIN torrents_group AS tg ON tg.ID = t.GroupID
14
   WHERE
14
   WHERE
15
-    (t.last_action < '".time_minus(3600 * 24 * 28)."' AND t.last_action IS NOT NULL)
15
+    (t.last_action < (NOW() - INTERVAL 28 DAY) AND t.last_action IS NOT NULL)
16
     OR
16
     OR
17
-    (t.Time < '".time_minus(3600 * 24 * 2)."' AND t.last_action IS NULL)");
17
+    (t.Time < (NOW() - INTERVAL 2 DAY) AND t.last_action IS NULL)");
18
 $Torrents = $DB->to_array(false, MYSQLI_NUM, false);
18
 $Torrents = $DB->to_array(false, MYSQLI_NUM, false);
19
 echo 'Found '.count($Torrents)." inactive torrents to be deleted.\n";
19
 echo 'Found '.count($Torrents)." inactive torrents to be deleted.\n";
20
 
20
 

+ 3
- 3
sections/schedule/daily/disable_inactive_users.php View File

9
       JOIN users_main AS um ON um.ID = ui.UserID
9
       JOIN users_main AS um ON um.ID = ui.UserID
10
       LEFT JOIN users_levels AS ul ON ul.UserID = um.ID AND ul.PermissionID = '".CELEB."'
10
       LEFT JOIN users_levels AS ul ON ul.UserID = um.ID AND ul.PermissionID = '".CELEB."'
11
     WHERE um.PermissionID IN ('".USER."', '".MEMBER ."')
11
     WHERE um.PermissionID IN ('".USER."', '".MEMBER ."')
12
-      AND um.LastAccess < '".time_minus(3600 * 24 * 110, true)."'
13
-      AND um.LastAccess > '".time_minus(3600 * 24 * 111, true)."'
12
+      AND um.LastAccess < (NOW() - INTERVAL 110 DAY)
13
+      AND um.LastAccess > (NOW() - INTERVAL 111 DAY)
14
       AND um.LastAccess IS NOT NULL
14
       AND um.LastAccess IS NOT NULL
15
       AND ui.Donor = '0'
15
       AND ui.Donor = '0'
16
       AND um.Enabled != '2'
16
       AND um.Enabled != '2'
28
       JOIN users_main AS um ON um.ID = ui.UserID
28
       JOIN users_main AS um ON um.ID = ui.UserID
29
       LEFT JOIN users_levels AS ul ON ul.UserID = um.ID AND ul.PermissionID = '".CELEB."'
29
       LEFT JOIN users_levels AS ul ON ul.UserID = um.ID AND ul.PermissionID = '".CELEB."'
30
     WHERE um.PermissionID IN ('".USER."', '".MEMBER ."')
30
     WHERE um.PermissionID IN ('".USER."', '".MEMBER ."')
31
-      AND um.LastAccess < '".time_minus(3600 * 24 * 30 * 4)."'
31
+      AND um.LastAccess < (NOW() - INTERVAL 120 DAY)
32
       AND um.LastAccess IS NOT NULL
32
       AND um.LastAccess IS NOT NULL
33
       AND ui.Donor = '0'
33
       AND ui.Donor = '0'
34
       AND um.Enabled != '2'
34
       AND um.Enabled != '2'

+ 2
- 2
sections/schedule/daily/disable_unconfirmed_users.php View File

7
   FROM users_info AS ui
7
   FROM users_info AS ui
8
     JOIN users_main AS um ON um.ID = ui.UserID
8
     JOIN users_main AS um ON um.ID = ui.UserID
9
   WHERE um.LastAccess IS NULL
9
   WHERE um.LastAccess IS NULL
10
-    AND ui.JoinDate < '".time_minus(60 * 60 * 24 * 7)."'
10
+    AND ui.JoinDate < (NOW() - INTERVAL 7 DAY)
11
     AND um.Enabled != '2'");
11
     AND um.Enabled != '2'");
12
 $UserIDs = $DB->collect('UserID');
12
 $UserIDs = $DB->collect('UserID');
13
 
13
 
20
     ui.BanReason = '3',
20
     ui.BanReason = '3',
21
     ui.AdminComment = CONCAT('$sqltime - Disabled for inactivity (never logged in)\n\n', ui.AdminComment)
21
     ui.AdminComment = CONCAT('$sqltime - Disabled for inactivity (never logged in)\n\n', ui.AdminComment)
22
   WHERE um.LastAccess IS NULL
22
   WHERE um.LastAccess IS NULL
23
-    AND ui.JoinDate < '".time_minus(60 * 60 * 24 * 7)."'
23
+    AND ui.JoinDate < (NOW() - INTERVAL 7 DAY)
24
     AND um.Enabled != '2'");
24
     AND um.Enabled != '2'");
25
 $Cache->decrement('stats_user_count', $DB->affected_rows());
25
 $Cache->decrement('stats_user_count', $DB->affected_rows());
26
 
26
 

Loading…
Cancel
Save