Quick sanity check (textareas eventually replaced)

classes/textarea_preview.class.php

@@ -1,74 +1,79 @@
 <?php
+
 /**
  * This super class is used to manage the ammount of textareas there are and to
  * generate the required JavaScript that enables the previews to work.
  */
-class TEXTAREA_PREVIEW_SUPER {
+class TEXTAREA_PREVIEW_SUPER
+{
+  
   /**
    * @static
    * @var int $Textareas Total number of textareas created
    */
-  protected static $Textareas = 0;
-
-  /**
-   * @static
-   * @var array $_ID Array of textarea IDs
-   */
-  protected static $_ID = [];
-
-  /**
-   * @static
-   * @var bool For use in JavaScript method
-   */
-  private static $Exectuted = false;
-
-  /**
-   * This method should only run once with $all as true and should be placed
-   * in the header or footer.
-   *
-   * If $all is true, it includes TextareaPreview and jQuery
-   *
-   * jQuery is required for this to work, include it in the headers.
-   *
-   * @static
-   * @param bool $all Output all required scripts, otherwise just do iterator()
-   * @example <pre><?php TEXT_PREVIEW::JavaScript(); ?></pre>
-   * @return void
-   */
-  public static function JavaScript ($all = true) {
-    if (self::$Textareas === 0) {
-      return;
-    }
-    if (self::$Exectuted === false && $all) {
-      View::parse('generic/textarea/script.phtml');
+    protected static $Textareas = 0;
+
+    /**
+     * @static
+     * @var array $_ID Array of textarea IDs
+     */
+    protected static $_ID = [];
+
+    /**
+     * @static
+     * @var bool For use in JavaScript method
+     */
+    private static $Exectuted = false;
+
+    /**
+     * This method should only run once with $all as true and should be placed
+     * in the header or footer.
+     *
+     * If $all is true, it includes TextareaPreview and jQuery
+     *
+     * jQuery is required for this to work, include it in the headers.
+     *
+     * @static
+     * @param bool $all Output all required scripts, otherwise just do iterator()
+     * @example <pre><?php TEXT_PREVIEW::JavaScript(); ?></pre>
+     * @return void
+     */
+    public static function JavaScript($all = true)
+    {
+        if (self::$Textareas === 0) {
+            return;
+        }
+        if (self::$Exectuted === false && $all) {
+            View::parse('generic/textarea/script.phtml');
+        }
+
+        self::$Exectuted = true;
+        self::iterator();
     }
 
-    self::$Exectuted = true;
-    self::iterator();
-  }
-
-  /**
-   * This iterator generates JavaScript to initialize each JavaScript
-   * TextareaPreview object.
-   *
-   * It will generate a numeric or custom ID related to the textarea.
-   * @static
-   * @return void
-   */
-  private static function iterator() {
-    $script = [];
-    for ($i = 0; $i < self::$Textareas; $i++) {
-      if (isset(self::$_ID[$i]) && is_string(self::$_ID[$i])) {
-        $a = sprintf('%d, "%s"', $i, self::$_ID[$i]);
-      } else {
-        $a = $i;
-      }
-      $script[] = sprintf('[%s]', $a);
-    }
-    if (!empty($script)) {
-      View::parse('generic/textarea/script_factory.phtml', array('script' => join(', ', $script)));
+    /**
+     * This iterator generates JavaScript to initialize each JavaScript
+     * TextareaPreview object.
+     *
+     * It will generate a numeric or custom ID related to the textarea.
+     * @static
+     * @return void
+     */
+    private static function iterator()
+    {
+        $script = [];
+        for ($i = 0; $i < self::$Textareas; $i++) {
+            if (isset(self::$_ID[$i]) && is_string(self::$_ID[$i])) {
+                $a = sprintf('%d, "%s"', $i, self::$_ID[$i]);
+            } else {
+                $a = $i;
+            }
+            $script[] = sprintf('[%s]', $a);
+        }
+        if (!empty($script)) {
+            View::parse('generic/textarea/script_factory.phtml', array('script' => join(', ', $script)));
+        }
     }
-  }
 }
 
 /**
@@ -110,66 +115,75 @@ class TEXTAREA_PREVIEW_SUPER {
  * </div>
  * </pre>
  */
-class TEXTAREA_PREVIEW extends TEXTAREA_PREVIEW_SUPER {
-  /**
-   * @var int Unique ID
-   */
-  private $id;
+class TEXTAREA_PREVIEW extends TEXTAREA_PREVIEW_SUPER
+{
 
   /**
-   * Flag for preview output
-   * @var bool $preview
-   */
-  private $preview = false;
-
-  /**
-   * String table
-   * @var string Buffer
-   */
-  private $buffer = null;
-
-  /**
-   * This method creates a textarea
-   *
-   * @param string $Name     name attribute
-   * @param string $ID       id attribute
-   * @param string $Value    default text attribute
-   * @param string $Cols     cols attribute
-   * @param string $Rows     rows attribute
-   * @param bool   $Preview  add the preview divs near the textarea
-   * @param bool   $Buttons  add the edit/preview buttons near the textarea
-   * @param bool   $Buffer   doesn't output the textarea, use getBuffer()
-   * @param array  $ExtraAttributes  array of attribute="value"
-   *
-   * If false for $Preview, $Buttons, or $Buffer, use the appropriate
-   * methods to add the those elements manually. Alternatively, use getID
-   * to create your own.
-   *
-   * It's important to have the right IDs as they make the JS function properly.
+   * @var int Unique ID
    */
-  public function __construct($Name, $ID = '', $Value = '', $Cols = 50, $Rows = 10,
-    $Preview = true, $Buttons = true, $Buffer = false,
-    array $ExtraAttributes = []
+    private $id;
+
+    /**
+     * Flag for preview output
+     * @var bool $preview
+     */
+    private $preview = false;
+
+    /**
+     * String table
+     * @var string Buffer
+     */
+    private $buffer = null;
+
+    /**
+     * This method creates a textarea
+     *
+     * @param string $Name     name attribute
+     * @param string $ID       id attribute
+     * @param string $Value    default text attribute
+     * @param string $Cols     cols attribute
+     * @param string $Rows     rows attribute
+     * @param bool   $Preview  add the preview divs near the textarea
+     * @param bool   $Buttons  add the edit/preview buttons near the textarea
+     * @param bool   $Buffer   doesn't output the textarea, use getBuffer()
+     * @param array  $ExtraAttributes  array of attribute="value"
+     *
+     * If false for $Preview, $Buttons, or $Buffer, use the appropriate
+     * methods to add the those elements manually. Alternatively, use getID
+     * to create your own.
+     *
+     * It's important to have the right IDs as they make the JS function properly.
+     */
+    public function __construct(
+      $Name,
+      $ID = '',
+      $Value = '',
+      $Cols = 50,
+      $Rows = 10,
+      $Preview = true,
+      $Buttons = true,
+      $Buffer = false,
+      array $ExtraAttributes = []
   ) {
-    $this->id = parent::$Textareas;
-    parent::$Textareas += 1;
-    array_push(parent::$_ID, $ID);
+        $this->id = parent::$Textareas;
+        parent::$Textareas += 1;
+        array_push(parent::$_ID, $ID);
 
-    if (empty($ID)) {
-      $ID = 'quickpost_' . $this->id;
-    }
+        if (empty($ID)) {
+            $ID = 'quickpost_' . $this->id;
+        }
 
-    if (!empty($ExtraAttributes)) {
-      $Attributes = ' ' . implode(' ', $ExtraAttributes);
-    } else {
-      $Attributes = '';
-    }
+        if (!empty($ExtraAttributes)) {
+            $Attributes = ' ' . implode(' ', $ExtraAttributes);
+        } else {
+            $Attributes = '';
+        }
 
-    if ($Preview === true) {
-      $this->preview();
-    }
+        if ($Preview === true) {
+            $this->preview();
+        }
 
-    $this->buffer = View::parse('generic/textarea/textarea.phtml', array(
+        $this->buffer = View::parse('generic/textarea/textarea.phtml', array(
       'ID' => $ID,
       'NID' => $this->id,
       'Name' => &$Name,
@@ -179,42 +193,46 @@ class TEXTAREA_PREVIEW extends TEXTAREA_PREVIEW_SUPER {
       'Attributes' => &$Attributes
     ), $Buffer);
 
-    if ($Buttons === true) {
-      $this->buttons();
+        if ($Buttons === true) {
+            $this->buttons();
+        }
     }
-  }
 
-  /**
-   * Outputs the divs required for previewing the AJAX content
-   * Will only output once
-   */
-  public function preview() {
-    if (!$this->preview) {
-      View::parse('generic/textarea/preview.phtml', array('ID' => $this->id));
+    /**
+     * Outputs the divs required for previewing the AJAX content
+     * Will only output once
+     */
+    public function preview()
+    {
+        if (!$this->preview) {
+            View::parse('generic/textarea/preview.phtml', array('ID' => $this->id));
+        }
+        $this->preview = true;
     }
-    $this->preview = true;
-  }
 
-  /**
-   * Outputs the preview and edit buttons
-   * Can be called many times to place buttons in different areas
-   */
-  public function buttons() {
-    View::parse('generic/textarea/buttons.phtml', array('ID' => $this->id));
-  }
+    /**
+     * Outputs the preview and edit buttons
+     * Can be called many times to place buttons in different areas
+     */
+    public function buttons()
+    {
+        View::parse('generic/textarea/buttons.phtml', array('ID' => $this->id));
+    }
 
-  /**
-   * Returns the textarea's numeric ID.
-   */
-  public function getID() {
-    return $this->id;
-  }
+    /**
+     * Returns the textarea's numeric ID.
+     */
+    public function getID()
+    {
+        return $this->id;
+    }
 
-  /**
-   * Returns textarea string when buffer is enabled in the constructor
-   * @return string
-   */
-  public function getBuffer() {
-    return $this->buffer;
-  }
+    /**
+     * Returns textarea string when buffer is enabled in the constructor
+     * @return string
+     */
+    public function getBuffer()
+    {
+        return $this->buffer;
+    }
 }

sections/ajax/forum/forum.php

@@ -1,5 +1,4 @@
-<?
-
+<?php
 
 /**********|| Page to show individual forums || ********************************\
 
@@ -15,16 +14,16 @@ Things to expect in $_GET:
 // Check for lame SQL injection attempts
 $ForumID = $_GET['forumid'];
 if (!is_number($ForumID)) {
-  print json_encode(array('status' => 'failure'));
-  die();
+    print json_encode(array('status' => 'failure'));
+    die();
 }
 
 if (isset($_GET['pp'])) {
-  $PerPage = intval($_GET['pp']);
+    $PerPage = intval($_GET['pp']);
 } elseif (isset($LoggedUser['PostsPerPage'])) {
-  $PerPage = $LoggedUser['PostsPerPage'];
+    $PerPage = $LoggedUser['PostsPerPage'];
 } else {
-  $PerPage = POSTS_PER_PAGE;
+    $PerPage = POSTS_PER_PAGE;
 }
 
 list($Page, $Limit) = Format::page_limit(TOPICS_PER_PAGE);
@@ -33,11 +32,11 @@ list($Page, $Limit) = Format::page_limit(TOPICS_PER_PAGE);
 
 // Caching anything beyond the first page of any given forum is just wasting ram
 // users are more likely to search then to browse to page 2
-if ($Page == 1) {
-  list($Forum,,,$Stickies) = $Cache->get_value("forums_$ForumID");
+if ($Page === 1) {
+    list($Forum, , , $Stickies) = $Cache->get_value("forums_$ForumID");
 }
 if (!isset($Forum) || !is_array($Forum)) {
-  $DB->query("
+    $DB->query("
     SELECT
       ID,
       Title,
@@ -52,36 +51,36 @@ if (!isset($Forum) || !is_array($Forum)) {
     WHERE ForumID = '$ForumID'
     ORDER BY IsSticky DESC, LastPostTime DESC
     LIMIT $Limit"); // Can be cached until someone makes a new post
-  $Forum = $DB->to_array('ID',MYSQLI_ASSOC, false);
-  if ($Page == 1) {
-    $DB->query("
+    $Forum = $DB->to_array('ID', MYSQLI_ASSOC, false);
+    if ($Page === 1) {
+        $DB->query("
       SELECT COUNT(ID)
       FROM forums_topics
       WHERE ForumID = '$ForumID'
         AND IsSticky = '1'");
-    list($Stickies) = $DB->next_record();
-    $Cache->cache_value("forums_$ForumID", array($Forum, '', 0, $Stickies), 0);
-  }
+        list($Stickies) = $DB->next_record();
+        $Cache->cache_value("forums_$ForumID", array($Forum, '', 0, $Stickies), 0);
+    }
 }
 
 if (!isset($Forums[$ForumID])) {
-  json_die("failure");
+    json_die("failure");
 }
 // Make sure they're allowed to look at the page
 if (!check_perms('site_moderate_forums')) {
-  if (isset($LoggedUser['CustomForums'][$ForumID]) && $LoggedUser['CustomForums'][$ForumID] === 0) {
-    json_die("failure", "insufficient permissions to view page");
-  }
+    if (isset($LoggedUser['CustomForums'][$ForumID]) && $LoggedUser['CustomForums'][$ForumID] === 0) {
+        json_die("failure", "insufficient permissions to view page");
+    }
 }
 if ($LoggedUser['CustomForums'][$ForumID] != 1 && $Forums[$ForumID]['MinClassRead'] > $LoggedUser['Class']) {
-  json_die("failure", "insufficient permissions to view page");
+    json_die("failure", "insufficient permissions to view page");
 }
 
 $ForumName = display_str($Forums[$ForumID]['Name']);
 $JsonSpecificRules = [];
 foreach ($Forums[$ForumID]['SpecificRules'] as $ThreadIDs) {
-  $Thread = Forums::get_thread_info($ThreadIDs);
-  $JsonSpecificRules[] = array(
+    $Thread = Forums::get_thread_info($ThreadIDs);
+    $JsonSpecificRules[] = array(
     'threadId' => (int)$ThreadIDs,
     'thread' => display_str($Thread['Title'])
   );
@@ -90,17 +89,17 @@ foreach ($Forums[$ForumID]['SpecificRules'] as $ThreadIDs) {
 $Pages = Format::get_pages($Page, $Forums[$ForumID]['NumTopics'], TOPICS_PER_PAGE, 9);
 
 if (count($Forum) === 0) {
-  print
+    print
     json_encode(
-      array(
+        array(
         'status' => 'success',
         'forumName' => $ForumName,
         'threads' => []
       )
     );
 } else {
-  // forums_last_read_topics is a record of the last post a user read in a topic, and what page that was on
-  $DB->query("
+    // forums_last_read_topics is a record of the last post a user read in a topic, and what page that was on
+    $DB->query("
     SELECT
       l.TopicID,
       l.PostID,
@@ -116,53 +115,55 @@ if (count($Forum) === 0) {
     WHERE l.TopicID IN(".implode(', ', array_keys($Forum)).')
       AND l.UserID = \''.$LoggedUser['ID'].'\'');
 
-  // Turns the result set into a multi-dimensional array, with
-  // forums_last_read_topics.TopicID as the key.
-  // This is done here so we get the benefit of the caching, and we
-  // don't have to make a database query for each topic on the page
-  $LastRead = $DB->to_array('TopicID');
+    // Turns the result set into a multi-dimensional array, with
+    // forums_last_read_topics.TopicID as the key.
+    // This is done here so we get the benefit of the caching, and we
+    // don't have to make a database query for each topic on the page
+    $LastRead = $DB->to_array('TopicID');
 
-  $JsonTopics = [];
-  foreach ($Forum as $Topic) {
-    list($TopicID, $Title, $AuthorID, $Locked, $Sticky, $PostCount, $LastID, $LastTime, $LastAuthorID) = array_values($Topic);
+    $JsonTopics = [];
+    foreach ($Forum as $Topic) {
+        list($TopicID, $Title, $AuthorID, $Locked, $Sticky, $PostCount, $LastID, $LastTime, $LastAuthorID) = array_values($Topic);
 
-    // handle read/unread posts - the reason we can't cache the whole page
-    if ((!$Locked || $Sticky)
+        // Handle read/unread posts - the reason we can't cache the whole page
+        if ((!$Locked || $Sticky)
         && ((empty($LastRead[$TopicID]) || $LastRead[$TopicID]['PostID'] < $LastID)
           && strtotime($LastTime) > $LoggedUser['CatchupTime'])
     ) {
-      $Read = 'unread';
-    } else {
-      $Read = 'read';
-    }
-    $UserInfo = Users::user_info($AuthorID);
-    $AuthorName = $UserInfo['Username'];
-    $UserInfo = Users::user_info($LastAuthorID);
-    $LastAuthorName = $UserInfo['Username'];
-    // Bug fix for no last time available
-    if (!$LastTime) { $LastTime = ''; }
-
-    $JsonTopics[] = array(
+            $Read = 'unread';
+        } else {
+            $Read = 'read';
+        }
+        $UserInfo = Users::user_info($AuthorID);
+        $AuthorName = $UserInfo['Username'];
+        $UserInfo = Users::user_info($LastAuthorID);
+        $LastAuthorName = $UserInfo['Username'];
+        // Bug fix for no last time available
+        if (!$LastTime) {
+            $LastTime = '';
+        }
+
+        $JsonTopics[] = array(
       'topicId' => (int)$TopicID,
       'title' => display_str($Title),
       'authorId' => (int)$AuthorID,
       'authorName' => $AuthorName,
-      'locked' => $Locked == 1,
-      'sticky' => $Sticky == 1,
+      'locked' => $Locked === 1,
+      'sticky' => $Sticky === 1,
       'postCount' => (int)$PostCount,
-      'lastID' => ($LastID == null) ? 0 : (int)$LastID,
+      'lastID' => ($LastID === null) ? 0 : (int)$LastID,
       'lastTime' => $LastTime,
-      'lastAuthorId' => ($LastAuthorID == null) ? 0 : (int)$LastAuthorID,
-      'lastAuthorName' => ($LastAuthorName == null) ? '' : $LastAuthorName,
-      'lastReadPage' => ($LastRead[$TopicID]['Page'] == null) ? 0 : (int)$LastRead[$TopicID]['Page'],
-      'lastReadPostId' => ($LastRead[$TopicID]['PostID'] == null) ? 0 : (int)$LastRead[$TopicID]['PostID'],
-      'read' => $Read == 'read'
+      'lastAuthorId' => ($LastAuthorID === null) ? 0 : (int)$LastAuthorID,
+      'lastAuthorName' => ($LastAuthorName === null) ? '' : $LastAuthorName,
+      'lastReadPage' => ($LastRead[$TopicID]['Page'] === null) ? 0 : (int)$LastRead[$TopicID]['Page'],
+      'lastReadPostId' => ($LastRead[$TopicID]['PostID'] === null) ? 0 : (int)$LastRead[$TopicID]['PostID'],
+      'read' => $Read === 'read'
     );
-  }
+    }
 
-  print
+    print
     json_encode(
-      array(
+        array(
         'status' => 'success',
         'response' => array(
           'forumName' => $ForumName,
@@ -174,4 +175,3 @@ if (count($Forum) === 0) {
       )
     );
 }
-?>

sections/ajax/forum/index.php

@@ -1,21 +1,22 @@
-<?
+<?php
+
 // Already done in /sections/ajax/index.php
 //enforce_login();
 
 if (!empty($LoggedUser['DisableForums'])) {
-  print json_encode(array('status' => 'failure'));
-  die();
+    print json_encode(array('status' => 'failure'));
+    die();
 } else {
-  // Replace the old hard-coded forum categories
-  $ForumCats = Forums::get_forum_categories();
+    // Replace the old hard-coded forum categories
+    $ForumCats = Forums::get_forum_categories();
 
-  //This variable contains all our lovely forum data
-  $Forums = Forums::get_forums();
+    // This variable contains all our lovely forum data
+    $Forums = Forums::get_forums();
 
-  if (empty($_GET['type']) || $_GET['type'] == 'main') {
-    include(SERVER_ROOT.'/sections/ajax/forum/main.php');
-  } else {
-    switch ($_GET['type']) {
+    if (empty($_GET['type']) || $_GET['type'] === 'main') {
+        include(SERVER_ROOT.'/sections/ajax/forum/main.php');
+    } else {
+        switch ($_GET['type']) {
       case 'viewforum':
         include(SERVER_ROOT.'/sections/ajax/forum/forum.php');
         break;
@@ -26,5 +27,5 @@ if (!empty($LoggedUser['DisableForums'])) {
         print json_encode(array('status' => 'failure'));
         break;
     }
-  }
+    }
 }

sections/ajax/forum/main.php

@@ -1,22 +1,22 @@
-<?
+<?php
 
 if (isset($LoggedUser['PostsPerPage'])) {
-  $PerPage = $LoggedUser['PostsPerPage'];
+    $PerPage = $LoggedUser['PostsPerPage'];
 } else {
-  $PerPage = POSTS_PER_PAGE;
+    $PerPage = POSTS_PER_PAGE;
 }
 
-//We have to iterate here because if one is empty it breaks the query
+// We have to iterate here because if one is empty it breaks the query
 $TopicIDs = [];
 foreach ($Forums as $Forum) {
-  if (!empty($Forum['LastPostTopicID'])) {
-    $TopicIDs[] = $Forum['LastPostTopicID'];
-  }
+    if (!empty($Forum['LastPostTopicID'])) {
+        $TopicIDs[] = $Forum['LastPostTopicID'];
+    }
 }
 
-//Now if we have IDs' we run the query
+// Now if we have IDs' we run the query
 if (!empty($TopicIDs)) {
-  $DB->query("
+    $DB->query("
     SELECT
       l.TopicID,
       l.PostID,
@@ -31,9 +31,9 @@ if (!empty($TopicIDs)) {
     FROM forums_last_read_topics AS l
     WHERE l.TopicID IN(".implode(',', $TopicIDs).")
       AND l.UserID = '$LoggedUser[ID]'");
-  $LastRead = $DB->to_array('TopicID', MYSQLI_ASSOC);
+    $LastRead = $DB->to_array('TopicID', MYSQLI_ASSOC);
 } else {
-  $LastRead = [];
+    $LastRead = [];
 }
 
 $DB->query("
@@ -48,40 +48,40 @@ $JsonCategories = [];
 $JsonCategory = [];
 $JsonForums = [];
 foreach ($Forums as $Forum) {
-  list($ForumID, $CategoryID, $ForumName, $ForumDescription, $MinRead, $MinWrite, $MinCreate, $NumTopics, $NumPosts, $LastPostID, $LastAuthorID, $LastTopicID, $LastTime, $SpecificRules, $LastTopic, $Locked, $Sticky) = array_values($Forum);
-  if ($LoggedUser['CustomForums'][$ForumID] != 1
+    list($ForumID, $CategoryID, $ForumName, $ForumDescription, $MinRead, $MinWrite, $MinCreate, $NumTopics, $NumPosts, $LastPostID, $LastAuthorID, $LastTopicID, $LastTime, $SpecificRules, $LastTopic, $Locked, $Sticky) = array_values($Forum);
+    if ($LoggedUser['CustomForums'][$ForumID] != 1
       && ($MinRead > $LoggedUser['Class']
       || array_search($ForumID, $RestrictedForums) !== false)
   ) {
-    continue;
-  }
-  $ForumDescription = display_str($ForumDescription);
-
-  if ($CategoryID != $LastCategoryID) {
-    if (!empty($JsonForums) && !empty($JsonCategory)) {
-      $JsonCategory['forums'] = $JsonForums;
-      $JsonCategories[] = $JsonCategory;
+        continue;
     }
-    $LastCategoryID = $CategoryID;
-    $JsonCategory = array(
+    $ForumDescription = display_str($ForumDescription);
+
+    if ($CategoryID != $LastCategoryID) {
+        if (!empty($JsonForums) && !empty($JsonCategory)) {
+            $JsonCategory['forums'] = $JsonForums;
+            $JsonCategories[] = $JsonCategory;
+        }
+        $LastCategoryID = $CategoryID;
+        $JsonCategory = array(
       'categoryID' => (int)$CategoryID,
       'categoryName' => $ForumCats[$CategoryID]
     );
-    $JsonForums = [];
-  }
+        $JsonForums = [];
+    }
 
-  if ((!$Locked || $Sticky)
+    if ((!$Locked || $Sticky)
       && $LastPostID != 0
       && ((empty($LastRead[$LastTopicID]) || $LastRead[$LastTopicID]['PostID'] < $LastPostID)
         && strtotime($LastTime) > $LoggedUser['CatchupTime'])
   ) {
-    $Read = 'unread';
-  } else {
-    $Read = 'read';
-  }
-  $UserInfo = Users::user_info($LastAuthorID);
+        $Read = 'unread';
+    } else {
+        $Read = 'read';
+    }
+    $UserInfo = Users::user_info($LastAuthorID);
 
-  $JsonForums[] = array(
+    $JsonForums[] = array(
     'forumId' => (int)$ForumID,
     'forumName' => $ForumName,
     'forumDescription' => $ForumDescription,
@@ -94,19 +94,19 @@ foreach ($Forums as $Forum) {
     'lastTime' => $LastTime,
     'specificRules' => $SpecificRules,
     'lastTopic' => display_str($LastTopic),
-    'read' => $Read == 1,
-    'locked' => $Locked == 1,
-    'sticky' => $Sticky == 1
+    'read' => $Read === 1,
+    'locked' => $Locked === 1,
+    'sticky' => $Sticky === 1
   );
 }
 // ...And an extra one to catch the last category.
 if (!empty($JsonForums) && !empty($JsonCategory)) {
-  $JsonCategory['forums'] = $JsonForums;
-  $JsonCategories[] = $JsonCategory;
+    $JsonCategory['forums'] = $JsonForums;
+    $JsonCategories[] = $JsonCategory;
 }
 
 print json_encode(
-  array(
+    array(
     'status' => 'success',
     'response' => array(
       'categories' => $JsonCategories

sections/ajax/forum/thread.php

@@ -1,4 +1,5 @@
 <?php
+
 // todo: Normalize thread_*_info don't need to waste all that ram on things that are already in other caches
 /**********|| Page to show individual threads || ********************************\
 
@@ -13,81 +14,79 @@ Things to expect in $_GET:
 
 // Check for lame SQL injection attempts
 if (!isset($_GET['threadid']) || !is_number($_GET['threadid'])) {
-  if (isset($_GET['topicid']) && is_number($_GET['topicid'])) {
-    $ThreadID = $_GET['topicid'];
-  } elseif (isset($_GET['postid']) && is_number($_GET['postid'])) {
-    $DB->query("
+    if (isset($_GET['topicid']) && is_number($_GET['topicid'])) {
+        $ThreadID = $_GET['topicid'];
+    } elseif (isset($_GET['postid']) && is_number($_GET['postid'])) {
+        $DB->query("
       SELECT TopicID
       FROM forums_posts
       WHERE ID = $_GET[postid]");
-    list($ThreadID) = $DB->next_record();
-    if ($ThreadID) {
-      //Redirect postid to threadid when necessary.
-      header("Location: ajax.php?action=forum&type=viewthread&threadid=$ThreadID&postid=$_GET[postid]");
-      die();
+        list($ThreadID) = $DB->next_record();
+        if ($ThreadID) {
+            //Redirect postid to threadid when necessary.
+            header("Location: ajax.php?action=forum&type=viewthread&threadid=$ThreadID&postid=$_GET[postid]");
+            die();
+        } else {
+            print json_encode(array('status' => 'failure'));
+            die();
+        }
     } else {
-      print json_encode(array('status' => 'failure'));
-      die();
+        print json_encode(array('status' => 'failure'));
+        die();
     }
-  } else {
-    print json_encode(array('status' => 'failure'));
-    die();
-  }
 } else {
-  $ThreadID = $_GET['threadid'];
+    $ThreadID = $_GET['threadid'];
 }
 
 if (isset($_GET['pp'])) {
-  $PerPage = $_GET['pp'];
+    $PerPage = $_GET['pp'];
 } elseif (isset($LoggedUser['PostsPerPage'])) {
-  $PerPage = $LoggedUser['PostsPerPage'];
+    $PerPage = $LoggedUser['PostsPerPage'];
 } else {
-  $PerPage = POSTS_PER_PAGE;
+    $PerPage = POSTS_PER_PAGE;
 }
 
-
-
 //---------- Get some data to start processing
 
 // Thread information, constant across all pages
 $ThreadInfo = Forums::get_thread_info($ThreadID, true, true);
 if ($ThreadInfo === null) {
-  json_die('failure', 'no such thread exists');
+    json_die('failure', 'no such thread exists');
 }
 $ForumID = $ThreadInfo['ForumID'];
 
 // Make sure they're allowed to look at the page
 if (!Forums::check_forumperm($ForumID)) {
-  print json_encode(array('status' => 'failure'));
-  die();
+    print json_encode(array('status' => 'failure'));
+    die();
 }
 
-//Post links utilize the catalogue & key params to prevent issues with custom posts per page
+// Post links utilize the catalogue & key params to prevent issues with custom posts per page
 if ($ThreadInfo['Posts'] > $PerPage) {
-  if (isset($_GET['post']) && is_number($_GET['post'])) {
-    $PostNum = $_GET['post'];
-  } elseif (isset($_GET['postid']) && is_number($_GET['postid'])) {
-    $DB->query("
+    if (isset($_GET['post']) && is_number($_GET['post'])) {
+        $PostNum = $_GET['post'];
+    } elseif (isset($_GET['postid']) && is_number($_GET['postid'])) {
+        $DB->query("
       SELECT COUNT(ID)
       FROM forums_posts
       WHERE TopicID = $ThreadID
         AND ID <= $_GET[postid]");
-    list($PostNum) = $DB->next_record();
-  } else {
-    $PostNum = 1;
-  }
+        list($PostNum) = $DB->next_record();
+    } else {
+        $PostNum = 1;
+    }
 } else {
-  $PostNum = 1;
+    $PostNum = 1;
 }
 list($Page, $Limit) = Format::page_limit($PerPage, min($ThreadInfo['Posts'], $PostNum));
 if (($Page - 1) * $PerPage > $ThreadInfo['Posts']) {
-  $Page = ceil($ThreadInfo['Posts'] / $PerPage);
+    $Page = ceil($ThreadInfo['Posts'] / $PerPage);
 }
-list($CatalogueID,$CatalogueLimit) = Format::catalogue_limit($Page, $PerPage, THREAD_CATALOGUE);
+list($CatalogueID, $CatalogueLimit) = Format::catalogue_limit($Page, $PerPage, THREAD_CATALOGUE);
 
 // Cache catalogue from which the page is selected, allows block caches and future ability to specify posts per page
 if (!$Catalogue = $Cache->get_value("thread_$ThreadID"."_catalogue_$CatalogueID")) {
-  $DB->query("
+    $DB->query("
     SELECT
       p.ID,
       p.AuthorID,
@@ -99,155 +98,153 @@ if (!$Catalogue = $Cache->get_value("thread_$ThreadID"."_catalogue_$CatalogueID"
     WHERE p.TopicID = '$ThreadID'
       AND p.ID != '".$ThreadInfo['StickyPostID']."'
     LIMIT $CatalogueLimit");
-  $Catalogue = $DB->to_array(false, MYSQLI_ASSOC);
-  if (!$ThreadInfo['IsLocked'] || $ThreadInfo['IsSticky']) {
-    $Cache->cache_value("thread_$ThreadID"."_catalogue_$CatalogueID", $Catalogue, 0);
-  }
+    $Catalogue = $DB->to_array(false, MYSQLI_ASSOC);
+    if (!$ThreadInfo['IsLocked'] || $ThreadInfo['IsSticky']) {
+        $Cache->cache_value("thread_$ThreadID"."_catalogue_$CatalogueID", $Catalogue, 0);
+    }
 }
 $Thread = Format::catalogue_select($Catalogue, $Page, $PerPage, THREAD_CATALOGUE);
 
 if ($_GET['updatelastread'] !== '0') {
-  $LastPost = end($Thread);
-  $LastPost = $LastPost['ID'];
-  reset($Thread);
-  if ($ThreadInfo['Posts'] <= $PerPage * $Page && $ThreadInfo['StickyPostID'] > $LastPost) {
-    $LastPost = $ThreadInfo['StickyPostID'];
-  }
-  //Handle last read
-  if (!$ThreadInfo['IsLocked'] || $ThreadInfo['IsSticky']) {
-    $DB->query("
+    $LastPost = end($Thread);
+    $LastPost = $LastPost['ID'];
+    reset($Thread);
+    if ($ThreadInfo['Posts'] <= $PerPage * $Page && $ThreadInfo['StickyPostID'] > $LastPost) {
+        $LastPost = $ThreadInfo['StickyPostID'];
+    }
+    // Handle last read
+    if (!$ThreadInfo['IsLocked'] || $ThreadInfo['IsSticky']) {
+        $DB->query("
       SELECT PostID
       FROM forums_last_read_topics
       WHERE UserID = '$LoggedUser[ID]'
         AND TopicID = '$ThreadID'");
-    list($LastRead) = $DB->next_record();
-    if ($LastRead < $LastPost) {
-      $DB->query("
+        list($LastRead) = $DB->next_record();
+        if ($LastRead < $LastPost) {
+            $DB->query("
         INSERT INTO forums_last_read_topics
           (UserID, TopicID, PostID)
         VALUES
           ('$LoggedUser[ID]', '$ThreadID', '".db_string($LastPost)."')
         ON DUPLICATE KEY UPDATE
           PostID = '$LastPost'");
+        }
     }
-  }
 }
 
-//Handle subscriptions
+// Handle subscriptions
 $UserSubscriptions = Subscriptions::get_subscriptions();
 
 if (empty($UserSubscriptions)) {
-  $UserSubscriptions = [];
+    $UserSubscriptions = [];
 }
 
 if (in_array($ThreadID, $UserSubscriptions)) {
-  $Cache->delete_value('subscriptions_user_new_'.$LoggedUser['ID']);
+    $Cache->delete_value('subscriptions_user_new_'.$LoggedUser['ID']);
 }
 
 $JsonPoll = [];
 if ($ThreadInfo['NoPoll'] == 0) {
-  if (!list($Question, $Answers, $Votes, $Featured, $Closed) = $Cache->get_value("polls_$ThreadID")) {
-    $DB->query("
+    if (!list($Question, $Answers, $Votes, $Featured, $Closed) = $Cache->get_value("polls_$ThreadID")) {
+        $DB->query("
       SELECT Question, Answers, Featured, Closed
       FROM forums_polls
       WHERE TopicID = '$ThreadID'");
-    list($Question, $Answers, $Featured, $Closed) = $DB->next_record(MYSQLI_NUM, array(1));
-    $Answers = unserialize($Answers);
-    $DB->query("
+        list($Question, $Answers, $Featured, $Closed) = $DB->next_record(MYSQLI_NUM, array(1));
+        $Answers = unserialize($Answers);
+        $DB->query("
       SELECT Vote, COUNT(UserID)
       FROM forums_polls_votes
       WHERE TopicID = '$ThreadID'
       GROUP BY Vote");
-    $VoteArray = $DB->to_array(false, MYSQLI_NUM);
+        $VoteArray = $DB->to_array(false, MYSQLI_NUM);
 
-    $Votes = [];
-    foreach ($VoteArray as $VoteSet) {
-      list($Key, $Value) = $VoteSet;
-      $Votes[$Key] = $Value;
-    }
+        $Votes = [];
+        foreach ($VoteArray as $VoteSet) {
+            list($Key, $Value) = $VoteSet;
+            $Votes[$Key] = $Value;
+        }
 
-    foreach (array_keys($Answers) as $i) {
-      if (!isset($Votes[$i])) {
-        $Votes[$i] = 0;
-      }
+        foreach (array_keys($Answers) as $i) {
+            if (!isset($Votes[$i])) {
+                $Votes[$i] = 0;
+            }
+        }
+        $Cache->cache_value("polls_$ThreadID", array($Question, $Answers, $Votes, $Featured, $Closed), 0);
     }
-    $Cache->cache_value("polls_$ThreadID", array($Question, $Answers, $Votes, $Featured, $Closed), 0);
-  }
 
-  if (!empty($Votes)) {
-    $TotalVotes = array_sum($Votes);
-    $MaxVotes = max($Votes);
-  } else {
-    $TotalVotes = 0;
-    $MaxVotes = 0;
-  }
+    if (!empty($Votes)) {
+        $TotalVotes = array_sum($Votes);
+        $MaxVotes = max($Votes);
+    } else {
+        $TotalVotes = 0;
+        $MaxVotes = 0;
+    }
 
-  $RevealVoters = in_array($ForumID, FORUMS_TO_REVEAL_VOTERS);
-  //Polls lose the you voted arrow thingy
-  $DB->query("
+    $RevealVoters = in_array($ForumID, FORUMS_TO_REVEAL_VOTERS);
+    //Polls lose the you voted arrow thingy
+    $DB->query("
     SELECT Vote
     FROM forums_polls_votes
     WHERE UserID = '".$LoggedUser['ID']."'
       AND TopicID = '$ThreadID'");
-  list($UserResponse) = $DB->next_record();
-  if (!empty($UserResponse) && $UserResponse != 0) {
-    $Answers[$UserResponse] = '&raquo; '.$Answers[$UserResponse];
-  } else {
-    if (!empty($UserResponse) && $RevealVoters) {
-      $Answers[$UserResponse] = '&raquo; '.$Answers[$UserResponse];
+    list($UserResponse) = $DB->next_record();
+    if (!empty($UserResponse) && $UserResponse != 0) {
+        $Answers[$UserResponse] = '&raquo; '.$Answers[$UserResponse];
+    } else {
+        if (!empty($UserResponse) && $RevealVoters) {
+            $Answers[$UserResponse] = '&raquo; '.$Answers[$UserResponse];
+        }
     }
-  }
 
-  $JsonPoll['closed'] = ($Closed == 1);
-  $JsonPoll['featured'] = $Featured;
-  $JsonPoll['question'] = $Question;
-  $JsonPoll['maxVotes'] = (int)$MaxVotes;
-  $JsonPoll['totalVotes'] = $TotalVotes;
-  $JsonPollAnswers = [];
+    $JsonPoll['closed'] = ($Closed == 1);
+    $JsonPoll['featured'] = $Featured;
+    $JsonPoll['question'] = $Question;
+    $JsonPoll['maxVotes'] = (int)$MaxVotes;
+    $JsonPoll['totalVotes'] = $TotalVotes;
+    $JsonPollAnswers = [];
 
-  foreach ($Answers as $i => $Answer) {
-    if (!empty($Votes[$i]) && $TotalVotes > 0) {
-      $Ratio = $Votes[$i] / $MaxVotes;
-      $Percent = $Votes[$i] / $TotalVotes;
-    } else {
-      $Ratio = 0;
-      $Percent = 0;
-    }
-    $JsonPollAnswers[] = array(
+    foreach ($Answers as $i => $Answer) {
+        if (!empty($Votes[$i]) && $TotalVotes > 0) {
+            $Ratio = $Votes[$i] / $MaxVotes;
+            $Percent = $Votes[$i] / $TotalVotes;
+        } else {
+            $Ratio = 0;
+            $Percent = 0;
+        }
+        $JsonPollAnswers[] = array(
       'answer' => $Answer,
       'ratio' => $Ratio,
       'percent' => $Percent
     );
-  }
+    }
 
-  if ($UserResponse !== null || $Closed || $ThreadInfo['IsLocked'] || $LoggedUser['Class'] < $Forums[$ForumID]['MinClassWrite']) {
-    $JsonPoll['voted'] = True;
-  } else {
-    $JsonPoll['voted'] = False;
-  }
+    if ($UserResponse !== null || $Closed || $ThreadInfo['IsLocked'] || $LoggedUser['Class'] < $Forums[$ForumID]['MinClassWrite']) {
+        $JsonPoll['voted'] = true;
+    } else {
+        $JsonPoll['voted'] = false;
+    }
 
-  $JsonPoll['answers'] = $JsonPollAnswers;
+    $JsonPoll['answers'] = $JsonPollAnswers;
 }
 
-//Sqeeze in stickypost
+// Sqeeze in stickypost
 if ($ThreadInfo['StickyPostID']) {
-  if ($ThreadInfo['StickyPostID'] != $Thread[0]['ID']) {
-    array_unshift($Thread, $ThreadInfo['StickyPost']);
-  }
-  if ($ThreadInfo['StickyPostID'] != $Thread[count($Thread) - 1]['ID']) {
-    $Thread[] = $ThreadInfo['StickyPost'];
-  }
+    if ($ThreadInfo['StickyPostID'] != $Thread[0]['ID']) {
+        array_unshift($Thread, $ThreadInfo['StickyPost']);
+    }
+    if ($ThreadInfo['StickyPostID'] != $Thread[count($Thread) - 1]['ID']) {
+        $Thread[] = $ThreadInfo['StickyPost'];
+    }
 }
 
 $JsonPosts = [];
 foreach ($Thread as $Key => $Post) {
-  list($PostID, $AuthorID, $AddedTime, $Body, $EditedUserID, $EditedTime) = array_values($Post);
-  list($AuthorID, $Username, $PermissionID, $Paranoia, $Artist, $Donor, $Warned, $Avatar, $Enabled, $UserTitle) = array_values(Users::user_info($AuthorID));
-
-
+    list($PostID, $AuthorID, $AddedTime, $Body, $EditedUserID, $EditedTime) = array_values($Post);
+    list($AuthorID, $Username, $PermissionID, $Paranoia, $Artist, $Donor, $Warned, $Avatar, $Enabled, $UserTitle) = array_values(Users::user_info($AuthorID));
 
-  $UserInfo = Users::user_info($EditedUserID);
-  $JsonPosts[] = [
+    $UserInfo = Users::user_info($EditedUserID);
+    $JsonPosts[] = [
     'postId' => (int)$PostID,
     'addedTime' => $AddedTime,
     'bbBody' => $Body,