Start using internal API calls to fetch database info

sections/api/index.php

@@ -0,0 +1,300 @@
+<?php
+declare(strict_types = 1);
+
+/**
+ * AJAX Switch Center
+ *
+ * This page acts as an AJAX "switch" - it's called by scripts, and it includes the required pages.
+ * The required page is determined by $_GET['action'].
+ */
+
+# $_POST login cookie
+if (!isset($FullToken)) {
+    enforce_login();
+}
+
+
+/**
+ * These users aren't rate limited.
+ * This array should contain user IDs.
+ */
+
+# Get people with Donor permissions
+$Donors = $DB->query("
+SELECT
+  `ID`
+FROM
+  `users_main`
+WHERE
+  `PermissionID` = 20
+");
+
+# Add Donors to $UserExceptions or define manually
+if ($DB->record_count()) {
+    $UserExceptions = array_unique($DB->collect('ID'));
+} else {
+    $UserExceptions = array(
+      # 1, 2, 3, etc.
+    );
+}
+
+# System and admin fix
+array_push($UserExceptions, 0, 1);
+
+
+/**
+ * AJAX_LIMIT = array($x, $y) = $x requests every $y seconds,
+ * e.g., array(5, 10) = 5 requests every 10 seconds.
+ */
+$AJAX_LIMIT = array(1, 6);
+$UserID = $LoggedUser['ID'];
+
+# Set proper headers for JSON output
+# https://github.com/OPSnet/Gazelle/blob/master/sections/ajax/index.php
+if (!empty($_SERVER['CONTENT_TYPE']) && substr($_SERVER['CONTENT_TYPE'], 0, 16) === 'application/json') {
+    $_POST = json_decode(file_get_contents('php://input'), true);
+}
+header('Content-Type: application/json; charset=utf-8');
+
+#  Enforce rate limiting everywhere
+if (!in_array($UserID, $UserExceptions) && isset($_GET['action'])) {
+    if (!$UserRequests = $Cache->get_value("ajax_requests_$UserID")) {
+        $UserRequests = 0;
+        $Cache->cache_value("ajax_requests_$UserID", '0', $AJAX_LIMIT[1]);
+    }
+
+    if ($UserRequests > $AJAX_LIMIT[0]) {
+        json_die('failure', 'rate limit exceeded');
+    } else {
+        $Cache->increment_value("ajax_requests_$UserID");
+    }
+}
+
+
+/**
+ * Actions
+ */
+
+switch ($_GET['action']) {
+
+  /**
+   * Torrents
+   */
+
+  case 'torrent':
+    require 'torrents/torrent.php';
+    break;
+
+  case 'group':
+    require 'torrents/group.php';
+    break;
+
+  // So the album art script can function without breaking the rate limit
+  case 'torrentgroupalbumart':
+    require SERVER_ROOT.'/sections/ajax/torrentgroupalbumart.php';
+    break;
+
+  case 'browse':
+    require SERVER_ROOT.'/sections/ajax/browse.php';
+    break;
+  
+   case 'tcomments':
+    require SERVER_ROOT.'/sections/ajax/tcomments.php';
+    break;
+
+
+  /**
+   * Features
+   */
+
+  case 'collage':
+    require SERVER_ROOT.'/sections/ajax/collage.php';
+    break;
+  
+  case 'artist':
+    require SERVER_ROOT.'/sections/ajax/artist.php';
+    break;
+
+  case 'request':
+    require SERVER_ROOT.'/sections/ajax/request.php';
+    break;
+
+  case 'requests':
+    require SERVER_ROOT.'/sections/ajax/requests.php';
+    break;
+
+  case 'top10':
+    require SERVER_ROOT.'/sections/ajax/top10/index.php';
+    break;
+
+
+  /**
+   * Users
+   */
+
+  case 'user':
+    require SERVER_ROOT.'/sections/ajax/user.php';
+    break;
+
+  case 'usersearch':
+    require SERVER_ROOT.'/sections/ajax/usersearch.php';
+    break;
+  
+  case 'community_stats':
+    require SERVER_ROOT.'/sections/ajax/community_stats.php';
+    break;
+
+  case 'user_recents':
+    require SERVER_ROOT.'/sections/ajax/user_recents.php';
+    break;
+
+  case 'userhistory':
+    require SERVER_ROOT.'/sections/ajax/userhistory/index.php';
+    break;
+
+
+  /**
+   * Account
+   */
+
+  case 'inbox':
+    require SERVER_ROOT.'/sections/ajax/inbox/index.php';
+    break;
+
+  case 'bookmarks':
+    require SERVER_ROOT.'/sections/ajax/bookmarks/index.php';
+    break;
+
+  case 'notifications':
+    require SERVER_ROOT.'/sections/ajax/notifications.php';
+    break;
+
+  case 'get_user_notifications':
+    require SERVER_ROOT.'/sections/ajax/get_user_notifications.php';
+    break;
+
+  case 'clear_user_notification':
+    require SERVER_ROOT.'/sections/ajax/clear_user_notification.php';
+    break;
+
+
+  /**
+   * Forums
+   */
+
+  case 'forum':
+    require SERVER_ROOT.'/sections/ajax/forum/index.php';
+    break;
+
+
+  case 'subscriptions':
+    require SERVER_ROOT.'/sections/ajax/subscriptions.php';
+    break;
+
+  case 'raw_bbcode':
+    require SERVER_ROOT.'/sections/ajax/raw_bbcode.php';
+    break;
+
+
+  /**
+   * Meta
+   */
+
+  case 'index':
+    require SERVER_ROOT.'/sections/ajax/info.php';
+    break;
+
+  case 'manifest':
+    require SERVER_ROOT.'/manifest.php';
+    json_die('success', manifest());
+    break;
+
+  case 'stats':
+    require SERVER_ROOT.'/sections/ajax/stats.php';
+    break;
+
+  case 'loadavg':
+    require SERVER_ROOT.'/sections/ajax/loadavg.php';
+    break;
+
+  case 'announcements':
+    require SERVER_ROOT.'/sections/ajax/announcements.php';
+    break;
+
+  case 'wiki':
+    require SERVER_ROOT.'/sections/ajax/wiki.php';
+    break;
+  
+  case 'ontology':
+    require SERVER_ROOT.'/sections/ajax/ontology.php';
+    break;
+  
+
+  /**
+   * Under construction
+   */
+
+  case 'preview':
+    require 'preview.php';
+    break;
+
+  case 'better':
+    require SERVER_ROOT.'/sections/ajax/better/index.php';
+    break;
+
+  case 'get_friends':
+    require SERVER_ROOT.'/sections/ajax/get_friends.php';
+    break;
+
+  case 'news_ajax':
+    require SERVER_ROOT.'/sections/ajax/news_ajax.php';
+    break;
+
+  case 'send_recommendation':
+    require SERVER_ROOT.'/sections/ajax/send_recommendation.php';
+    break;
+
+  /*
+  case 'similar_artists':
+    require SERVER_ROOT.'/sections/ajax/similar_artists.php';
+    break;
+  */
+
+  /*
+  case 'votefavorite':
+    require SERVER_ROOT.'/sections/ajax/takevote.php';
+    break;
+  */
+
+  /*
+  case 'torrent_info':
+    require 'torrent_info.php';
+    break;
+  */
+
+  /*
+  case 'checkprivate':
+    include 'checkprivate.php';
+    break;
+  */
+
+  case 'autofill':
+    /*
+    if ($_GET['cat'] === 'anime') {
+        require SERVER_ROOT.'/sections/ajax/autofill/anime.php';
+    }
+
+    if ($_GET['cat'] === 'jav') {
+        require SERVER_ROOT.'/sections/ajax/autofill/jav.php';
+    }
+
+    if ($_GET['cat'] === 'manga') {
+        require SERVER_ROOT.'/sections/ajax/autofill/manga.php';
+    }
+    */
+    break;
+
+  default:
+    // If they're screwing around with the query string
+    json_die('failure');
+}

sections/api/torrents/group.php

@@ -0,0 +1,101 @@
+<?php
+#declare(strict_types=1);
+
+require SERVER_ROOT.'/sections/torrents/functions.php';
+
+$GroupID = (int) $_GET['id'];
+$TorrentHash = (string) $_GET['hash'];
+
+if ($GroupID && $TorrentHash) {
+    json_die('failure', 'bad parameters');
+}
+
+if ($TorrentHash) {
+    if (!is_valid_torrenthash($TorrentHash)) {
+        json_die('failure', 'bad hash parameter');
+    } else {
+        $GroupID = (int) torrenthash_to_groupid($TorrentHash);
+        if (!$GroupID) {
+            json_die('failure', 'bad hash parameter');
+        }
+    }
+}
+
+if ($GroupID <= 0) {
+    json_die('failure', 'bad id parameter');
+}
+
+$TorrentCache = get_group_info($GroupID, true, 0, true, true);
+if (!$TorrentCache) {
+    json_die('failure', 'bad id parameter');
+}
+
+list($TorrentDetails, $TorrentList) = $TorrentCache;
+$Artists = Artists::get_artist($GroupID);
+
+if ($TorrentDetails['CategoryID'] === 0) {
+    $CategoryName = 'Unknown';
+} else {
+    $CategoryName = $Categories[$TorrentDetails['CategoryID'] - 1];
+}
+
+$TagList = explode('|', $TorrentDetails['GROUP_CONCAT(DISTINCT tags.Name SEPARATOR \'|\')']);
+
+$JsonTorrentDetails = [
+  'description'  => Text::full_format($TorrentDetails['WikiBody']),
+  'picture'      => $TorrentDetails['WikiImage'],
+  'id'           => (int) $TorrentDetails['ID'],
+  'name'         => $TorrentDetails['Name'],
+  'organism'     => $TorrentDetails['Title2'],
+  'strain'       => $TorrentDetails['NameJP'],
+  'authors'      => $Artists,
+  'year'         => (int) $TorrentDetails['Year'],
+  'accession'    => $TorrentDetails['CatalogueNumber'],
+  'categoryId'   => (int) $TorrentDetails['CategoryID'],
+  'categoryName' => $CategoryName,
+  'time'         => $TorrentDetails['Time'],
+  'isBookmarked' => Bookmarks::has_bookmarked('torrent', $GroupID),
+  'tags'         => $TagList
+];
+
+$JsonTorrentList = [];
+foreach ($TorrentList as $Torrent) {
+    // Convert file list back to the old format
+    $FileList = explode("\n", $Torrent['FileList']);
+    foreach ($FileList as &$File) {
+        $File = Torrents::filelist_old_format($File);
+    }
+
+    unset($File);
+    $FileList = implode('|||', $FileList);
+    $Userinfo = Users::user_info($Torrent['UserID']);
+
+    $Reports = Torrents::get_reports($Torrent['ID']);
+    $Torrent['Reported'] = count($Reports) > 0;
+
+    $JsonTorrentList[] = [
+      'id'          => (int) $Torrent['ID'],
+      'infoHash'    => $Torrent['InfoHash'],
+      'platform'    => $Torrent['Media'],
+      'format'      => $Torrent['Container'],
+      'license'     => $Torrent['Codec'],
+      'scope'       => $Torrent['Resolution'],
+      'annotated'   => (bool) $Torrent['Censored'],
+      'archive'     => $Torrent['Archive'],
+      'fileCount'   => (int) $Torrent['FileCount'],
+      'size'        => (int) $Torrent['Size'],
+      'seeders'     => (int) $Torrent['Seeders'],
+      'leechers'    => (int) $Torrent['Leechers'],
+      'snatched'    => (int) $Torrent['Snatched'],
+      'freeTorrent' => ($Torrent['FreeTorrent'] == 1),
+      'reported'    => (bool) $Torrent['Reported'],
+      'time'        => $Torrent['Time'],
+      'description' => $Torrent['Description'],
+      'fileList'    => $FileList,
+      'filePath'    => $Torrent['FilePath'],
+      'userId'      => (int) ($Torrent['Anonymous'] ? 0 : $Torrent['UserID']),
+      'username'    => ($Torrent['Anonymous'] ? 'Anonymous' : $Userinfo['Username'])
+    ];
+}
+
+json_die('success', ['group' => $JsonTorrentDetails, 'torrents' => $JsonTorrentList]);

sections/api/torrents/torrent.php

@@ -0,0 +1,105 @@
+<?php
+#declare(strict_types=1);
+
+require SERVER_ROOT.'/sections/torrents/functions.php';
+
+$TorrentID = (int) $_GET['id'];
+$TorrentHash = (string) $_GET['hash'];
+
+if ($TorrentID && $TorrentHash) {
+    json_die('failure', 'bad parameters');
+}
+
+if ($TorrentHash) {
+    if (!is_valid_torrenthash($TorrentHash)) {
+        json_die('failure', 'bad hash parameter');
+    } else {
+        $TorrentID = (int) torrenthash_to_torrentid($TorrentHash);
+        if (!$TorrentID) {
+            json_die('failure', 'bad hash parameter');
+        }
+    }
+}
+
+if ($TorrentID <= 0) {
+    json_die('failure', 'bad id parameter');
+}
+
+$TorrentCache = get_torrent_info($TorrentID, true, 0, true, true);
+if (!$TorrentCache) {
+    json_die('failure', 'bad id parameter');
+}
+
+list($TorrentDetails, $TorrentList) = $TorrentCache;
+if (!isset($TorrentList[$TorrentID])) {
+    json_die('failure', 'bad id parameter');
+}
+
+$GroupID = $TorrentDetails['ID'];
+$Artists = Artists::get_artist($GroupID);
+
+if ($TorrentDetails['CategoryID'] === 0) {
+    $CategoryName = 'Unknown';
+} else {
+    $CategoryName = $Categories[$TorrentDetails['CategoryID'] - 1];
+}
+
+$TagList = explode('|', $TorrentDetails['GROUP_CONCAT(DISTINCT tags.Name SEPARATOR \'|\')']);
+
+$JsonTorrentDetails = [
+  'description'  => Text::full_format($TorrentDetails['WikiBody']),
+  'picture'      => $TorrentDetails['WikiImage'],
+  'id'           => (int) $TorrentDetails['ID'],
+  'name'         => $TorrentDetails['Name'],
+  'organism'     => $TorrentDetails['Title2'],
+  'strain'       => $TorrentDetails['NameJP'],
+  'authors'      => $Artists,
+  'year'         => (int) $TorrentDetails['Year'],
+  'accession'    => $TorrentDetails['CatalogueNumber'],
+  'categoryId'   => (int) $TorrentDetails['CategoryID'],
+  'categoryName' => $CategoryName,
+  'time'         => $TorrentDetails['Time'],
+  'isBookmarked' => Bookmarks::has_bookmarked('torrent', $GroupID),
+  'tags'         => $TagList
+];
+
+$Torrent = $TorrentList[$TorrentID];
+
+$Reports = Torrents::get_reports($TorrentID);
+$Torrent['Reported'] = (count($Reports) > 0);
+
+// Convert file list back to the old format
+$FileList = explode("\n", $Torrent['FileList']);
+foreach ($FileList as &$File) {
+    $File = Torrents::filelist_old_format($File);
+}
+
+unset($File);
+$FileList = implode('|||', $FileList);
+$Userinfo = Users::user_info($Torrent['UserID']);
+
+$JsonTorrentList[] = [
+  'id'          => (int) $Torrent['ID'],
+  'infoHash'    => $Torrent['InfoHash'],
+  'platform'    => $Torrent['Media'],
+  'format'      => $Torrent['Container'],
+  'license'     => $Torrent['Codec'],
+  'scope'       => $Torrent['Resolution'],
+  'annotated'   => (bool) $Torrent['Censored'],
+  'archive'     => $Torrent['Archive'],
+  'fileCount'   => (int) $Torrent['FileCount'],
+  'size'        => (int) $Torrent['Size'],
+  'seeders'     => (int) $Torrent['Seeders'],
+  'leechers'    => (int) $Torrent['Leechers'],
+  'snatched'    => (int) $Torrent['Snatched'],
+  'freeTorrent' => ($Torrent['FreeTorrent'] == 1),
+  'reported'    => (bool) $Torrent['Reported'],
+  'time'        => $Torrent['Time'],
+  'description' => $Torrent['Description'],
+  'fileList'    => $FileList,
+  'filePath'    => $Torrent['FilePath'],
+  'userId'      => (int) ($Torrent['Anonymous'] ? 0 : $Torrent['UserID']),
+  'username'    => ($Torrent['Anonymous'] ? 'Anonymous' : $Userinfo['Username'])
+];
+
+json_die('success', ['group' => $JsonTorrentDetails, 'torrent' => array_pop($JsonTorrentList)]);

sections/pwgen/diceware.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 # Load the dictionary
 require_once 'wordlist.php';

sections/pwgen/wordlist.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 # https://www.eff.org/files/2016/07/18/eff_large_wordlist.txt
 $eff_large_wordlist = [

sections/rules/chat.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 # Formerly Rules::display_forum_rules()
 # and Rules::display_irc_chat_rules()

sections/rules/clients.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 View::show_header('Client rules');
 

sections/rules/collages.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 View::show_header('Collection rules');
 ?>

sections/rules/index.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 enforce_login();
 

sections/rules/jump.php

@@ -1,3 +1,8 @@
+<?php
+declare(strict_types=1);
+
+?>
+
 <h3 id="jump">Other sections</h3>
 <div class="box pad rule_table">
   <table>

sections/rules/ratio.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 View::show_header('Ratio requirements');
 ?>

sections/rules/requests.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 View::show_header('Request rules');
 ?>

sections/rules/tag.php

@@ -1,5 +1,5 @@
 <?php
-#declare(strict_types=1);
+declare(strict_types=1);
 
 # Formerly Rules::display_site_tag_rules()
 View::show_header('Tagging rules');

sections/user/community_stats.php

@@ -1,4 +1,6 @@
-<?
+<?php
+declare(strict_types=1);
+
 $DB->query("
   SELECT Page, COUNT(1)
   FROM comments
@@ -32,49 +34,65 @@ $DB->query("
 list($UniqueGroups) = $DB->next_record();
 
 ?>
-    <div class="box box_info box_userinfo_community">
-      <div class="head colhead_dark">Community</div>
-      <ul class="stats nobullet">
-        <li id="comm_posts">Forum posts: <?=number_format($ForumPosts)?> <a href="userhistory.php?action=posts&amp;userid=<?=$UserID?>" class="brackets">View</a></li>
-        <li id="comm_irc">IRC lines: <?=number_format($IRCLines)?></li>
-<?php if ($Override = check_paranoia_here('torrentcomments+')) { ?>
-        <li id="comm_torrcomm"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Torrent comments: <?=number_format($NumComments)?>
-<?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
-          <a href="comments.php?id=<?=$UserID?>" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-        <li id="comm_artcomm"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Artist comments: <?=number_format($NumArtistComments)?>
-<?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
-          <a href="comments.php?id=<?=$UserID?>&amp;action=artist" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-        <li id="comm_collcomm"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collage comments: <?=number_format($NumCollageComments)?>
-<?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
-          <a href="comments.php?id=<?=$UserID?>&amp;action=collages" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-        <li id="comm_reqcomm"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Request comments: <?=number_format($NumRequestComments)?>
-<?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
-          <a href="comments.php?id=<?=$UserID?>&amp;action=requests" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-<?
+<div class="box box_info box_userinfo_community">
+        <div class="head colhead_dark">Community</div>
+        <ul class="stats nobullet">
+                <li id="comm_posts">Forum posts: <?=number_format($ForumPosts)?> <a
+                                href="userhistory.php?action=posts&amp;userid=<?=$UserID?>"
+                                class="brackets">View</a></li>
+                <li id="comm_irc">IRC lines: <?=number_format($IRCLines)?>
+                </li>
+                <?php if ($Override = check_paranoia_here('torrentcomments+')) { ?>
+                <li id="comm_torrcomm" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Torrent
+                        comments: <?=number_format($NumComments)?>
+                        <?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
+                        <a href="comments.php?id=<?=$UserID?>"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <li id="comm_artcomm" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Artist
+                        comments: <?=number_format($NumArtistComments)?>
+                        <?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
+                        <a href="comments.php?id=<?=$UserID?>&amp;action=artist"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <li id="comm_collcomm" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collage
+                        comments: <?=number_format($NumCollageComments)?>
+                        <?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
+                        <a href="comments.php?id=<?=$UserID?>&amp;action=collages"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <li id="comm_reqcomm" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Request
+                        comments: <?=number_format($NumRequestComments)?>
+                        <?php if ($Override = check_paranoia_here('torrentcomments')) { ?>
+                        <a href="comments.php?id=<?=$UserID?>&amp;action=requests"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <?php
   }
   if (($Override = check_paranoia_here('collages+'))) { ?>
-        <li id="comm_collstart"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collages started: <?=number_format($NumCollages)?>
-<?php if ($Override = check_paranoia_here('collages')) { ?>
-          <a href="collages.php?userid=<?=$UserID?>" class="brackets<?=(($Override === 2) ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-<?
+                <li id="comm_collstart" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collages
+                        started: <?=number_format($NumCollages)?>
+                        <?php if ($Override = check_paranoia_here('collages')) { ?>
+                        <a href="collages.php?userid=<?=$UserID?>"
+                                class="brackets<?=(($Override === 2) ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <?php
   }
   if (($Override = check_paranoia_here('collagecontribs+'))) { ?>
-        <li id="comm_collcontrib"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collages contributed to: <? echo number_format($NumCollageContribs); ?>
-<?php if ($Override = check_paranoia_here('collagecontribs')) { ?>
-          <a href="collages.php?userid=<?=$UserID?>&amp;contrib=1" class="brackets<?=(($Override === 2) ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-<?
+                <li id="comm_collcontrib" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Collages
+                        contributed to:
+                        <?php echo number_format($NumCollageContribs); ?>
+                        <?php if ($Override = check_paranoia_here('collagecontribs')) { ?>
+                        <a href="collages.php?userid=<?=$UserID?>&amp;contrib=1"
+                                class="brackets<?=(($Override === 2) ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <?php
   }
 
   //Let's see if we can view requests because of reasons
@@ -83,18 +101,23 @@ list($UniqueGroups) = $DB->next_record();
   $ViewBounty = check_paranoia_here('requestsfilled_bounty');
 
   if ($ViewCount && !$ViewBounty && !$ViewAll) { ?>
-        <li>Requests filled: <?=number_format($RequestsFilled)?></li>
-<?php } elseif (!$ViewCount && $ViewBounty && !$ViewAll) { ?>
-        <li>Requests filled: <?=Format::get_size($TotalBounty)?> collected</li>
-<?php } elseif ($ViewCount && $ViewBounty && !$ViewAll) { ?>
-        <li>Requests filled: <?=number_format($RequestsFilled)?> for <?=Format::get_size($TotalBounty)?></li>
-<?php } elseif ($ViewAll) { ?>
-        <li>
-          <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests filled: <?=number_format($RequestsFilled)?></span>
-          <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>> for <?=Format::get_size($TotalBounty) ?></span>
-          <a href="requests.php?type=filled&amp;userid=<?=$UserID?>" class="brackets<?=(($ViewAll === 2) ? ' paranoia_override' : '')?>">View</a>
-        </li>
-<?
+                <li>Requests filled: <?=number_format($RequestsFilled)?>
+                </li>
+                <?php } elseif (!$ViewCount && $ViewBounty && !$ViewAll) { ?>
+                <li>Requests filled: <?=Format::get_size($TotalBounty)?> collected</li>
+                <?php } elseif ($ViewCount && $ViewBounty && !$ViewAll) { ?>
+                <li>Requests filled: <?=number_format($RequestsFilled)?> for <?=Format::get_size($TotalBounty)?>
+                </li>
+                <?php } elseif ($ViewAll) { ?>
+                <li>
+                        <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests
+                                filled: <?=number_format($RequestsFilled)?></span>
+                                <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>>
+                                        for <?=Format::get_size($TotalBounty) ?></span>
+                                        <a href="requests.php?type=filled&amp;userid=<?=$UserID?>"
+                                                class="brackets<?=(($ViewAll === 2) ? ' paranoia_override' : '')?>">View</a>
+                </li>
+                <?php
   }
 
   //Let's see if we can view requests because of reasons
@@ -103,135 +126,169 @@ list($UniqueGroups) = $DB->next_record();
   $ViewBounty = check_paranoia_here('requestsvoted_bounty');
 
   if ($ViewCount && !$ViewBounty && !$ViewAll) { ?>
-        <li>Requests created: <?=number_format($RequestsCreated)?></li>
-        <li>Requests voted: <?=number_format($RequestsVoted)?></li>
-<?php } elseif (!$ViewCount && $ViewBounty && !$ViewAll) { ?>
-        <li>Requests created: <?=Format::get_size($RequestsCreatedSpent)?> spent</li>
-        <li>Requests voted: <?=Format::get_size($TotalSpent)?> spent</li>
-<?php } elseif ($ViewCount && $ViewBounty && !$ViewAll) { ?>
-        <li>Requests created: <?=number_format($RequestsCreated)?> for <?=Format::get_size($RequestsCreatedSpent)?></li>
-        <li>Requests voted: <?=number_format($RequestsVoted)?> for <?=Format::get_size($TotalSpent)?></li>
-<?php } elseif ($ViewAll) { ?>
-        <li>
-          <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests created: <?=number_format($RequestsCreated)?></span>
-          <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>> for <?=Format::get_size($RequestsCreatedSpent)?></span>
-          <a href="requests.php?type=created&amp;userid=<?=$UserID?>" class="brackets<?=($ViewAll === 2 ? ' paranoia_override' : '')?>">View</a>
-        </li>
-        <li>
-          <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests voted: <?=number_format($RequestsVoted)?></span>
-          <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>> for <?=Format::get_size($TotalSpent)?></span>
-          <a href="requests.php?type=voted&amp;userid=<?=$UserID?>" class="brackets<?=($ViewAll === 2 ? ' paranoia_override' : '')?>">View</a>
-        </li>
-<?
+                <li>Requests created: <?=number_format($RequestsCreated)?>
+                </li>
+                <li>Requests voted: <?=number_format($RequestsVoted)?>
+                </li>
+                <?php } elseif (!$ViewCount && $ViewBounty && !$ViewAll) { ?>
+                <li>Requests created: <?=Format::get_size($RequestsCreatedSpent)?> spent
+                </li>
+                <li>Requests voted: <?=Format::get_size($TotalSpent)?> spent</li>
+                <?php } elseif ($ViewCount && $ViewBounty && !$ViewAll) { ?>
+                <li>Requests created: <?=number_format($RequestsCreated)?> for <?=Format::get_size($RequestsCreatedSpent)?>
+                </li>
+                <li>Requests voted: <?=number_format($RequestsVoted)?> for <?=Format::get_size($TotalSpent)?>
+                </li>
+                <?php } elseif ($ViewAll) { ?>
+                <li>
+                        <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests
+                                created: <?=number_format($RequestsCreated)?></span>
+                                <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>>
+                                        for <?=Format::get_size($RequestsCreatedSpent)?></span>
+                                        <a href="requests.php?type=created&amp;userid=<?=$UserID?>"
+                                                class="brackets<?=($ViewAll === 2 ? ' paranoia_override' : '')?>">View</a>
+                </li>
+                <li>
+                        <span<?=($ViewCount === 2 ? ' class="paranoia_override"' : '')?>>Requests
+                                voted: <?=number_format($RequestsVoted)?></span>
+                                <span<?=($ViewBounty === 2 ? ' class="paranoia_override"' : '')?>>
+                                        for <?=Format::get_size($TotalSpent)?></span>
+                                        <a href="requests.php?type=voted&amp;userid=<?=$UserID?>"
+                                                class="brackets<?=($ViewAll === 2 ? ' paranoia_override' : '')?>">View</a>
+                </li>
+                <?php
   }
 
   if ($Override = check_paranoia_here('screenshotcount')) {
-  $DB->query("
+      $DB->query("
     SELECT COUNT(*)
     FROM torrents_doi
     WHERE UserID = '$UserID'");
-  list($Screenshots) = $DB->next_record();
-?>
-        <li id="comm_screenshots">Screenshots added: <?=number_format($Screenshots)?></li>
-<?
+      list($Screenshots) = $DB->next_record(); ?>
+                <li id="comm_screenshots">Screenshots added: <?=number_format($Screenshots)?>
+                </li>
+                <?php
   }
 
   if ($Override = check_paranoia_here('uploads+')) { ?>
-        <li id="comm_upload"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Uploaded: <?=number_format($Uploads)?>
-<?php if ($Override = check_paranoia_here('uploads')) { ?>
-          <a href="torrents.php?type=uploaded&amp;userid=<?=$UserID?>" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php if (check_perms('zip_downloader')) { ?>
-          <a href="torrents.php?action=redownload&amp;type=uploads&amp;userid=<?=$UserID?>" onclick="return confirm('If you no longer have the content, your ratio WILL be affected; be sure to check the size of all torrents before redownloading.');" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">Download</a>
-<?
+                <li id="comm_upload" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Uploaded:
+                        <?=number_format($Uploads)?>
+                        <?php if ($Override = check_paranoia_here('uploads')) { ?>
+                        <a href="torrents.php?type=uploaded&amp;userid=<?=$UserID?>"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php if (check_perms('zip_downloader')) { ?>
+                        <a href="torrents.php?action=redownload&amp;type=uploads&amp;userid=<?=$UserID?>"
+                                onclick="return confirm('If you no longer have the content, your ratio WILL be affected; be sure to check the size of all torrents before redownloading.');"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">Download</a>
+                        <?php
             }
           }
 ?>
-        </li>
-<?
+                </li>
+                <?php
   }
   if ($Override = check_paranoia_here('uniquegroups+')) { ?>
-        <li id="comm_uniquegroup"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Unique groups: <?=number_format($UniqueGroups)?>
-<?php if ($Override = check_paranoia_here('uniquegroups')) { ?>
-          <a href="torrents.php?type=uploaded&amp;userid=<?=$UserID?>&amp;filter=uniquegroup" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php } ?>
-        </li>
-<?
+                <li id="comm_uniquegroup" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Unique
+                        groups: <?=number_format($UniqueGroups)?>
+                        <?php if ($Override = check_paranoia_here('uniquegroups')) { ?>
+                        <a href="torrents.php?type=uploaded&amp;userid=<?=$UserID?>&amp;filter=uniquegroup"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php } ?>
+                </li>
+                <?php
   }
   if ($Override = check_paranoia_here('seeding+')) {
-?>
-        <li id="comm_seeding"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Seeding:
-          <span class="user_commstats" id="user_commstats_seeding"><a href="#" class="brackets" onclick="commStats(<?=$UserID?>); return false;">Show stats</a></span>
-<?php if ($Override = check_paranoia_here('snatched+')) { ?>
-          <span<?=($Override === 2 ? ' class="paranoia_override"' : '')?> id="user_commstats_seedingperc"></span>
-<?
+      ?>
+                <li id="comm_seeding" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Seeding:
+                        <span class="user_commstats" id="user_commstats_seeding"><a href="#" class="brackets"
+                                        onclick="commStats(<?=$UserID?>); return false;">Show
+                                        stats</a></span>
+                        <?php if ($Override = check_paranoia_here('snatched+')) { ?>
+                        <span<?=($Override === 2 ? ' class="paranoia_override"' : '')?>
+                                id="user_commstats_seedingperc"></span>
+                                <?php
     }
-    if ($Override = check_paranoia_here('seeding')) {
-?>
-          <a href="torrents.php?type=seeding&amp;userid=<?=$UserID?>" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php if (check_perms('zip_downloader')) { ?>
-          <a href="torrents.php?action=redownload&amp;type=seeding&amp;userid=<?=$UserID?>" onclick="return confirm('If you no longer have the content, your ratio WILL be affected; be sure to check the size of all torrents before redownloading.');" class="brackets">Download</a>
-<?
+      if ($Override = check_paranoia_here('seeding')) {
+          ?>
+                                <a href="torrents.php?type=seeding&amp;userid=<?=$UserID?>"
+                                        class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                                <?php if (check_perms('zip_downloader')) { ?>
+                                <a href="torrents.php?action=redownload&amp;type=seeding&amp;userid=<?=$UserID?>"
+                                        onclick="return confirm('If you no longer have the content, your ratio WILL be affected; be sure to check the size of all torrents before redownloading.');"
+                                        class="brackets">Download</a>
+                                <?php
       }
-    }
-?>
-        </li>
-<?
+      } ?>
+                </li>
+                <?php
   }
   if ($Override = check_paranoia_here('leeching+')) {
-?>
-        <li id="comm_leeching"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Leeching:
-          <span class="user_commstats" id="user_commstats_leeching"><a href="#" class="brackets" onclick="commStats(<?=$UserID?>); return false;">Show stats</a></span>
-<?php if ($Override = check_paranoia_here('leeching')) { ?>
-          <a href="torrents.php?type=leeching&amp;userid=<?=$UserID?>" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?
+      ?>
+                <li id="comm_leeching" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Leeching:
+                        <span class="user_commstats" id="user_commstats_leeching"><a href="#" class="brackets"
+                                        onclick="commStats(<?=$UserID?>); return false;">Show
+                                        stats</a></span>
+                        <?php if ($Override = check_paranoia_here('leeching')) { ?>
+                        <a href="torrents.php?type=leeching&amp;userid=<?=$UserID?>"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php
     }
-    if ($DisableLeech == 0 && check_perms('users_view_ips')) {
-?>
-          <strong>(Disabled)</strong>
-<?php } ?>
-        </li>
-<?
+      if ($DisableLeech == 0 && check_perms('users_view_ips')) {
+          ?>
+                        <strong>(Disabled)</strong>
+                        <?php
+      } ?>
+                </li>
+                <?php
   }
   if ($Override = check_paranoia_here('snatched+')) { ?>
-        <li id="comm_snatched"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Snatched:
-          <span class="user_commstats" id="user_commstats_snatched"><a href="#" class="brackets" onclick="commStats(<?=$UserID?>); return false;">Show stats</a></span>
-<?php if ($Override = check_perms('site_view_torrent_snatchlist', $Class)) { ?>
-          <span id="user_commstats_usnatched"<?=($Override === 2 ? ' class="paranoia_override"' : '')?>></span>
-<?
+                <li id="comm_snatched" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>>Snatched:
+                        <span class="user_commstats" id="user_commstats_snatched"><a href="#" class="brackets"
+                                        onclick="commStats(<?=$UserID?>); return false;">Show
+                                        stats</a></span>
+                        <?php if ($Override = check_perms('site_view_torrent_snatchlist', $Class)) { ?>
+                        <span id="user_commstats_usnatched" <?=($Override === 2 ? ' class="paranoia_override"' : '')?>></span>
+                        <?php
     }
   }
   if ($Override = check_paranoia_here('snatched')) { ?>
-          <a href="torrents.php?type=snatched&amp;userid=<?=$UserID?>" class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
-<?php if (check_perms('zip_downloader')) { ?>
-          <a href="torrents.php?action=redownload&amp;type=snatches&amp;userid=<?=$UserID?>" onclick="return confirm('If you no longer have the content, your ratio WILL be affected, be sure to check the size of all torrents before redownloading.');" class="brackets">Download</a>
-<?php } ?>
-        </li>
-<?
+                        <a href="torrents.php?type=snatched&amp;userid=<?=$UserID?>"
+                                class="brackets<?=($Override === 2 ? ' paranoia_override' : '')?>">View</a>
+                        <?php if (check_perms('zip_downloader')) { ?>
+                        <a href="torrents.php?action=redownload&amp;type=snatches&amp;userid=<?=$UserID?>"
+                                onclick="return confirm('If you no longer have the content, your ratio WILL be affected, be sure to check the size of all torrents before redownloading.');"
+                                class="brackets">Download</a>
+                        <?php } ?>
+                </li>
+                <?php
   }
   if (check_perms('site_view_torrent_snatchlist', $Class)) {
-?>
-        <li id="comm_downloaded">Downloaded:
-          <span class="user_commstats" id="user_commstats_downloaded"><a href="#" class="brackets" onclick="commStats(<?=$UserID?>); return false;">Show stats</a></span>
-          <span id="user_commstats_udownloaded"></span>
-          <a href="torrents.php?type=downloaded&amp;userid=<?=$UserID?>" class="brackets">View</a>
-        </li>
-<?
+      ?>
+                <li id="comm_downloaded">Downloaded:
+                        <span class="user_commstats" id="user_commstats_downloaded"><a href="#" class="brackets"
+                                        onclick="commStats(<?=$UserID?>); return false;">Show
+                                        stats</a></span>
+                        <span id="user_commstats_udownloaded"></span>
+                        <a href="torrents.php?type=downloaded&amp;userid=<?=$UserID?>"
+                                class="brackets">View</a>
+                </li>
+                <?php
   }
   if ($Override = check_paranoia_here('invitedcount')) {
-  $DB->query("
+      $DB->query("
     SELECT COUNT(UserID)
     FROM users_info
     WHERE Inviter = '$UserID'");
-  list($Invited) = $DB->next_record();
-?>
-        <li id="comm_invited">Invited: <?=number_format($Invited)?></li>
-<?
+      list($Invited) = $DB->next_record(); ?>
+                <li id="comm_invited">Invited: <?=number_format($Invited)?>
+                </li>
+                <?php
   }
 ?>
-      </ul>
-<?php if ($LoggedUser['AutoloadCommStats']) { ?>
-      <script type="text/javascript">
-        commStats(<?=$UserID?>);
-      </script>
-<?php } ?>
-    </div>
+        </ul>
+        <?php if ($LoggedUser['AutoloadCommStats']) { ?>
+        <script type="text/javascript">
+                commStats( <?=$UserID?> );
+        </script>
+        <?php } ?>
+</div>

sections/user/delete_invite.php

@@ -1,4 +1,6 @@
-<?
+<?php
+declare(strict_types=1);
+
 authorize();
 
 $InviteKey = db_string($_GET['invite']);
@@ -8,10 +10,10 @@ $DB->query("
   WHERE InviteKey = ?", $InviteKey);
 list($UserID) = $DB->next_record();
 if (!$DB->has_results()) {
-  error(404);
+    error(404);
 }
 if ($UserID != $LoggedUser['ID'] && $LoggedUser['PermissionID'] != SYSOP) {
-  error(403);
+    error(403);
 }
 
 $DB->query("
@@ -19,21 +21,20 @@ $DB->query("
   WHERE InviteKey = ?", $InviteKey);
 
 if (!check_perms('site_send_unlimited_invites')) {
-  $DB->query("
+    $DB->query("
     SELECT Invites
     FROM users_main
     WHERE ID = ?
     LIMIT 1", $UserID);
-  list($Invites) = $DB->next_record();
-  if ($Invites < 10) {
-    $DB->query("
+    list($Invites) = $DB->next_record();
+    if ($Invites < 10) {
+        $DB->query("
       UPDATE users_main
       SET Invites = Invites + 1
       WHERE ID = ?", $UserID);
-    $Cache->begin_transaction("user_info_heavy_$UserID");
-    $Cache->update_row(false, ['Invites' => '+1']);
-    $Cache->commit_transaction(0);
-  }
+        $Cache->begin_transaction("user_info_heavy_$UserID");
+        $Cache->update_row(false, ['Invites' => '+1']);
+        $Cache->commit_transaction(0);
+    }
 }
 header('Location: user.php?action=invite');
-?>

sections/user/donor_stats.php

@@ -1,18 +1,20 @@
-<?
+<?php
+declare(strict_types=1);
+
 if (check_perms('users_mod') || $OwnProfile || Donations::is_visible($UserID)) { ?>
-  <div class="box box_info box_userinfo_donor_stats">
-    <div class="head colhead_dark">Donor Statistics</div>
-    <ul class="stats nobullet">
-      <li>
-        Total donor points: <?=Donations::get_total_rank($UserID)?>
-      </li>
-      <li>
-        Current donor rank: <?=Donations::render_rank(Donations::get_rank($UserID), true)?>
-      </li>
-      <li>
-        Last donated: <?=time_diff(Donations::get_donation_time($UserID))?>
-      </li>
-    </ul>
-  </div>
-<?
+<div class="box box_info box_userinfo_donor_stats">
+  <div class="head colhead_dark">Donor Statistics</div>
+  <ul class="stats nobullet">
+    <li>
+      Total donor points: <?=Donations::get_total_rank($UserID)?>
+    </li>
+    <li>
+      Current donor rank: <?=Donations::render_rank(Donations::get_rank($UserID), true)?>
+    </li>
+    <li>
+      Last donated: <?=time_diff(Donations::get_donation_time($UserID))?>
+    </li>
+  </ul>
+</div>
+<?php
 }

sections/user/lastfm.php

@@ -1,3 +0,0 @@
-<?php
-#declare(strict_types=1);
-

sections/user/manage_linked.php

@@ -1,9 +1,11 @@
-<?
+<?php
+declare(strict_types=1);
+
 authorize();
 include(SERVER_ROOT.'/sections/user/linkedfunctions.php');
 
 if (!check_perms('users_mod')) {
-  error(403);
+    error(403);
 }
 
 $UserID = (int) $_REQUEST['userid'];
@@ -15,16 +17,16 @@ switch ($_REQUEST['dupeaction']) {
 
   case 'update':
     if ($_REQUEST['target']) {
-      $Target = $_REQUEST['target'];
-      $DB->query("
+        $Target = $_REQUEST['target'];
+        $DB->query("
         SELECT ID
         FROM users_main
         WHERE Username LIKE '".db_string($Target)."'");
-      if (list($TargetID) = $DB->next_record()) {
-        link_users($UserID, $TargetID);
-      } else {
-        error("User '$Target' not found.");
-      }
+        if (list($TargetID) = $DB->next_record()) {
+            link_users($UserID, $TargetID);
+        } else {
+            error("User '$Target' not found.");
+        }
     }
 
     $DB->query("
@@ -34,7 +36,7 @@ switch ($_REQUEST['dupeaction']) {
     list($GroupID) = $DB->next_record();
 
     if ($_REQUEST['dupecomments'] && $GroupID) {
-      dupe_comments($GroupID, $_REQUEST['dupecomments']);
+        dupe_comments($GroupID, $_REQUEST['dupecomments']);
     }
     break;
 
@@ -43,4 +45,3 @@ switch ($_REQUEST['dupeaction']) {
 }
 echo '\o/';
 header("Location: user.php?id=$UserID");
-?>

sections/user/permissions.php

@@ -1,10 +1,12 @@
-<?
+<?php
+declare(strict_types=1);
+
 // todo: Redo HTML
 if (!check_perms('admin_manage_permissions')) {
-  error(403);
+    error(403);
 }
 if (!isset($_REQUEST['userid']) || !is_number($_REQUEST['userid'])) {
-  error(404);
+    error(404);
 }
 
 include(SERVER_ROOT."/classes/permissions_form.php");
@@ -23,83 +25,96 @@ $Defaults = Permissions::get_permissions_for_user($UserID, []);
 
 $Delta = [];
 if (isset($_POST['action'])) {
-  authorize();
+    authorize();
 
-  foreach ($PermissionsArray as $Perm => $Explaination) {
-    $Setting = isset($_POST["perm_$Perm"]) ? 1 : 0;
-    $Default = isset($Defaults[$Perm]) ? 1 : 0;
-    if ($Setting != $Default) {
-      $Delta[$Perm] = $Setting;
+    foreach ($PermissionsArray as $Perm => $Explaination) {
+        $Setting = isset($_POST["perm_$Perm"]) ? 1 : 0;
+        $Default = isset($Defaults[$Perm]) ? 1 : 0;
+        if ($Setting != $Default) {
+            $Delta[$Perm] = $Setting;
+        }
     }
-  }
-  if (!is_number($_POST['maxcollages']) && !empty($_POST['maxcollages'])) {
-    error("Please enter a valid number of extra personal collages");
-  }
-  $Delta['MaxCollages'] = $_POST['maxcollages'];
+    if (!is_number($_POST['maxcollages']) && !empty($_POST['maxcollages'])) {
+        error("Please enter a valid number of extra personal collages");
+    }
+    $Delta['MaxCollages'] = $_POST['maxcollages'];
 
-  $Cache->begin_transaction("user_info_heavy_$UserID");
-  $Cache->update_row(false, array('CustomPermissions' => $Delta));
-  $Cache->commit_transaction(0);
-  $DB->query("
+    $Cache->begin_transaction("user_info_heavy_$UserID");
+    $Cache->update_row(false, array('CustomPermissions' => $Delta));
+    $Cache->commit_transaction(0);
+    $DB->query("
     UPDATE users_main
     SET CustomPermissions = '".db_string(serialize($Delta))."'
     WHERE ID = '$UserID'");
 } elseif (!empty($Customs)) {
-  $Delta = unserialize($Customs);
+    $Delta = unserialize($Customs);
 }
 
 $Permissions = array_merge($Defaults, $Delta);
 $MaxCollages = $Customs['MaxCollages'] + $Delta['MaxCollages'];
 
-function display_perm($Key, $Title) {
-  global $Defaults, $Permissions;
-  $Perm = "<input id=\"default_$Key\" type=\"checkbox\" disabled=\"disabled\"";
-  if (isset($Defaults[$Key]) && $Defaults[$Key]) {
-    $Perm .= ' checked="checked"';
-  }
-  $Perm .= " /><input type=\"checkbox\" name=\"perm_$Key\" id=\"$Key\" value=\"1\"";
-  if (isset($Permissions[$Key]) && $Permissions[$Key]) {
-    $Perm .= ' checked="checked"';
-  }
-  $Perm .= " /> <label for=\"$Key\">$Title</label><br />";
-  echo "$Perm\n";
+function display_perm($Key, $Title)
+{
+    global $Defaults, $Permissions;
+    $Perm = "<input id=\"default_$Key\" type=\"checkbox\" disabled=\"disabled\"";
+    if (isset($Defaults[$Key]) && $Defaults[$Key]) {
+        $Perm .= ' checked="checked"';
+    }
+    $Perm .= " /><input type=\"checkbox\" name=\"perm_$Key\" id=\"$Key\" value=\"1\"";
+    if (isset($Permissions[$Key]) && $Permissions[$Key]) {
+        $Perm .= ' checked="checked"';
+    }
+    $Perm .= " /> <label for=\"$Key\">$Title</label><br />";
+    echo "$Perm\n";
 }
 
 View::show_header("$Username &gt; Permissions");
 ?>
-<script type="text/javascript">//<![CDATA[
-function reset() {
-  for (i = 0; i < $('#permissionsform').raw().elements.length; i++) {
-    element = $('#permissionsform').raw().elements[i];
-    if (element.id.substr(0, 8) == 'default_') {
-      $('#' + element.id.substr(8)).raw().checked = element.checked;
+<script type="text/javascript">
+  //<![CDATA[
+  function reset() {
+    for (i = 0; i < $('#permissionsform').raw().elements.length; i++) {
+      element = $('#permissionsform').raw().elements[i];
+      if (element.id.substr(0, 8) == 'default_') {
+        $('#' + element.id.substr(8)).raw().checked = element.checked;
+      }
     }
   }
-}
-//]]>
+  //]]>
 </script>
 <div class="header">
-  <h2><?=Users::format_username($UserID, false, false, false)?> &gt; Permissions</h2>
+  <h2><?=Users::format_username($UserID, false, false, false)?> &gt;
+    Permissions</h2>
   <div class="linkbox">
     <a href="#" onclick="reset(); return false;" class="brackets">Defaults</a>
   </div>
 </div>
 <div class="box pad">
-  <p>Before using permissions, please understand that it allows you to both add and remove access to specific features. If you think that to add access to a feature, you need to uncheck everything else, <strong>YOU ARE WRONG</strong>. The check boxes on the left, which are grayed out, are the standard permissions granted by their class (and donor/artist status). Any changes you make to the right side will overwrite this. It's not complicated, and if you screw up, click the "Defaults" link at the top. It will reset the user to their respective features granted by class, then you can select or deselect the one or two things you want to change. <strong>DO NOT DESELECT EVERYTHING.</strong> If you need further clarification, ask a developer before using this tool.</p>
+  <p>Before using permissions, please understand that it allows you to both add and remove access to specific features.
+    If you think that to add access to a feature, you need to uncheck everything else, <strong>YOU ARE WRONG</strong>.
+    The check boxes on the left, which are grayed out, are the standard permissions granted by their class (and
+    donor/artist status). Any changes you make to the right side will overwrite this. It's not complicated, and if you
+    screw up, click the "Defaults" link at the top. It will reset the user to their respective features granted by
+    class, then you can select or deselect the one or two things you want to change. <strong>DO NOT DESELECT
+      EVERYTHING.</strong> If you need further clarification, ask a developer before using this tool.</p>
 </div>
 <br />
 <form class="manage_form" name="permissions" id="permissionsform" method="post" action="">
   <table class="layout permission_head">
     <tr>
       <td class="label">Extra personal collages</td>
-      <td><input type="text" name="maxcollages" size="5" value="<?=($MaxCollages ? $MaxCollages : '0') ?>" /></td>
+      <td><input type="text" name="maxcollages" size="5"
+          value="<?=($MaxCollages ? $MaxCollages : '0') ?>" />
+      </td>
     </tr>
   </table>
   <input type="hidden" name="action" value="permissions" />
-  <input type="hidden" name="auth" value="<?=$LoggedUser['AuthKey']?>" />
-  <input type="hidden" name="id" value="<?=$_REQUEST['userid']?>" />
-<?
+  <input type="hidden" name="auth"
+    value="<?=$LoggedUser['AuthKey']?>" />
+  <input type="hidden" name="id"
+    value="<?=$_REQUEST['userid']?>" />
+  <?php
 permissions_form();
 ?>
 </form>
-<? View::show_footer(); ?>
+<?php View::show_footer();

sections/user/points.php

@@ -1,5 +1,5 @@
-<?
-$Amount = (int) db_string($_POST['amount']);
+<?php
+declare(strict_types=1);$Amount = (int) db_string($_POST['amount']);
 $To = (int) db_string($_POST['to']);
 $UserID = (int) $LoggedUser['ID'];
 $Adjust = isset($_POST['adjust'])?true:false;
@@ -9,92 +9,95 @@ $Message = $_POST['message'];
 $Tax = 0.1;
 
 if ($LoggedUser['DisablePoints']) {
-  $Err = 'You are not allowed to send '.BONUS_POINTS.'.';
+    $Err = 'You are not allowed to send '.BONUS_POINTS.'.';
 } else {
-  if ($Adjust)
-    $Amount = $Amount/(1-$Tax);
+    if ($Adjust) {
+        $Amount = $Amount/(1-$Tax);
+    }
 
-  $SentAmount = (int) ($Amount*(1-$Tax));
+    $SentAmount = (int) ($Amount*(1-$Tax));
 
-  $Amount = (int) $Amount;
+    $Amount = (int) $Amount;
 
-  if ($UserID == $To) {
-    $Err = 'If you sent '.BONUS_POINTS.' to yourself it wouldn\'t even do anything. Stop that.';
-  } elseif ($Amount < 0) {
-    $Err = 'You can\'t send a negative amount of '.BONUS_POINTS.'.';
-  } elseif ($Amount < 100) {
-    $Err = 'You must send at least 100 '.BONUS_POINTS.'.';
-  } else {
-    $DB->query("
+    if ($UserID == $To) {
+        $Err = 'If you sent '.BONUS_POINTS.' to yourself it wouldn\'t even do anything. Stop that.';
+    } elseif ($Amount < 0) {
+        $Err = 'You can\'t send a negative amount of '.BONUS_POINTS.'.';
+    } elseif ($Amount < 100) {
+        $Err = 'You must send at least 100 '.BONUS_POINTS.'.';
+    } else {
+        $DB->query("
       SELECT ui.DisablePoints
       FROM users_main AS um
         JOIN users_info AS ui ON um.ID = ui.UserID
       WHERE ID = $To");
-    if (!$DB->has_results()) {
-      $Err = 'That user doesn\'t exist.';
-    } else {
-      list($Disabled) = $DB->next_record();
-      if ($Disabled) {
-        $Err = "This user is not allowed to receive ".BONUS_POINTS.".";
-      } else {
-        $DB->query("
+        if (!$DB->has_results()) {
+            $Err = 'That user doesn\'t exist.';
+        } else {
+            list($Disabled) = $DB->next_record();
+            if ($Disabled) {
+                $Err = "This user is not allowed to receive ".BONUS_POINTS.".";
+            } else {
+                $DB->query("
           SELECT BonusPoints
           FROM users_main
           WHERE ID = $UserID");
-        if ($DB->has_results()) {
-          list($BP) = $DB->next_record();
+                if ($DB->has_results()) {
+                    list($BP) = $DB->next_record();
 
-          if ($BP < $Amount) {
-            $Err = 'You don\'t have enough '.BONUS_POINTS.'.';
-          } else {
-            $DB->query("
+                    if ($BP < $Amount) {
+                        $Err = 'You don\'t have enough '.BONUS_POINTS.'.';
+                    } else {
+                        $DB->query("
               UPDATE users_main
               SET BonusPoints = BonusPoints - $Amount
               WHERE ID = $UserID");
-            $DB->query("
+                        $DB->query("
               UPDATE users_main
               SET BonusPoints = BonusPoints + ".$SentAmount."
               WHERE ID = $To");
 
-            $UserInfo = Users::user_info($UserID);
-            $ToInfo = Users::user_info($To);
+                        $UserInfo = Users::user_info($UserID);
+                        $ToInfo = Users::user_info($To);
 
-            $DB->query("
+                        $DB->query("
               UPDATE users_info
               SET AdminComment = CONCAT('".sqltime()." - Sent $Amount ".BONUS_POINTS." (".$SentAmount." after tax) to [user]".$ToInfo['Username']."[/user]\n\n', AdminComment)
               WHERE UserID = $UserID");
-            $DB->query("
+                        $DB->query("
               UPDATE users_info
               SET AdminComment = CONCAT('".sqltime()." - Received ".$SentAmount." ".BONUS_POINTS." from [user]".$UserInfo['Username']."[/user]\n\n', AdminComment)
               WHERE UserID = $To");
 
-            $PM = '[user]'.$UserInfo['Username'].'[/user] has sent you a gift of '.$SentAmount.' '.BONUS_POINTS.'!';
+                        $PM = '[user]'.$UserInfo['Username'].'[/user] has sent you a gift of '.$SentAmount.' '.BONUS_POINTS.'!';
 
-            if (!empty($Message)) {
-              $PM .= "\n\n".'[quote='.$UserInfo['Username'].']'.$Message.'[/quote]';
-            }
+                        if (!empty($Message)) {
+                            $PM .= "\n\n".'[quote='.$UserInfo['Username'].']'.$Message.'[/quote]';
+                        }
 
-            Misc::send_pm($To, 0, 'You\'ve received a gift!', $PM);
+                        Misc::send_pm($To, 0, 'You\'ve received a gift!', $PM);
 
-            $Cache->delete_value('user_info_heavy_'.$UserID);
-            $Cache->delete_value('user_stats_'.$UserID);
-            $Cache->delete_value('user_info_heavy_'.$To);
-            $Cache->delete_value('user_stats_'.$To);
-          }
-        } else {
-          $Err = 'An unknown error occurred.';
+                        $Cache->delete_value('user_info_heavy_'.$UserID);
+                        $Cache->delete_value('user_stats_'.$UserID);
+                        $Cache->delete_value('user_info_heavy_'.$To);
+                        $Cache->delete_value('user_stats_'.$To);
+                    }
+                } else {
+                    $Err = 'An unknown error occurred.';
+                }
+            }
         }
-      }
     }
-  }
 }
 
 View::show_header('Send '.BONUS_POINTS); ?>
 <div>
-  <h2 id='general'>Send <?=BONUS_POINTS?></h2>
+  <h2 id='general'>Send <?=BONUS_POINTS?>
+  </h2>
   <div class='box pad' style='padding: 10px 10px 10px 20p;'>
-    <p><?=$Err?'Error: '.$Err:'Sent '.$Amount.' '.BONUS_POINTS.' ('.$SentAmount.' after tax) to '.$ToInfo['Username'].'.'?></p>
+    <p><?=$Err?'Error: '.$Err:'Sent '.$Amount.' '.BONUS_POINTS.' ('.$SentAmount.' after tax) to '.$ToInfo['Username'].'.'?>
+    </p>
     <p><a href='/user.php?id=<?=$To?>'>Return</a></p>
   </div>
 </div>
-<? View::show_footer(); ?>
+<?php View::show_footer();