Start systematically going through DB schema

classes/torrents.class.php

 class Torrents
 {
     const FILELIST_DELIM = 0xF7; // Hex for ÷ Must be the same as phrase_boundary in sphinx.conf!
-  const SNATCHED_UPDATE_INTERVAL = 3600; // How often we want to update users' snatch lists
-  const SNATCHED_UPDATE_AFTERDL = 300; // How long after a torrent download we want to update a user's snatch lists
+    const SNATCHED_UPDATE_INTERVAL = 3600; // How often we want to update users' snatch lists
+    const SNATCHED_UPDATE_AFTERDL = 300; // How long after a torrent download we want to update a user's snatch lists
 
   /**
    * Function to get data and torrents for an array of GroupIDs. Order of keys doesn't matter
     public static function array_group(array &$Group)
     {
         return array(
-      'GroupID' => $Group['ID'],
-      'GroupName' => $Group['Name'],
-      'GroupNameRJ' => $Group['NameRJ'],
-      'GroupNameJP' => $Group['NameJP'],
-      'GroupYear' => $Group['Year'],
-      'GroupCategoryID' => $Group['CategoryID'],
-      'GroupCatalogueNumber' => $Group['CatalogueNumber'],
-      'GroupPages' => $Group['Pages'],
-      'GroupDLSiteID' => ($Group['DLSiteID'] ?? ''),
-      'GroupStudio' => $Group['Studio'],
-      'GroupSeries' => $Group['Series'],
-      'GroupFlags' => ($Group['Flags'] ?? ''),
-      'TagList' => $Group['TagList'],
-      'WikiImage' => $Group['WikiImage'],
-      'Torrents' => $Group['Torrents'],
-      'Artists' => $Group['Artists']
-    );
+          'GroupID' => $Group['ID'],
+          'GroupName' => $Group['Name'],
+          'GroupNameRJ' => $Group['NameRJ'],
+          'GroupNameJP' => $Group['NameJP'],
+          'GroupYear' => $Group['Year'],
+          'GroupCategoryID' => $Group['CategoryID'],
+          'GroupCatalogueNumber' => $Group['CatalogueNumber'],
+          'GroupPages' => $Group['Pages'],
+          'GroupDLSiteID' => ($Group['DLSiteID'] ?? ''),
+          'GroupStudio' => $Group['Studio'],
+          'GroupSeries' => $Group['Series'],
+          'GroupFlags' => ($Group['Flags'] ?? ''),
+          'TagList' => $Group['TagList'],
+          'WikiImage' => $Group['WikiImage'],
+          'Torrents' => $Group['Torrents'],
+          'Artists' => $Group['Artists']
+        );
     }
 
     /**
             G::$Cache->delete_value("torrent_download_$TorrentID");
             Misc::write_log((G::$LoggedUser['Username']??'System')." marked torrent $TorrentID freeleech type $FreeLeechType");
             Torrents::write_group_log($GroupID, $TorrentID, (G::$LoggedUser['ID']??0), "marked as freeleech type $FreeLeechType", 0);
-            if ($Announce && ($FreeLeechType == 1 || $FreeLeechType == 3)) {
+            if ($Announce && ($FreeLeechType === 1 || $FreeLeechType === 3)) {
                 send_irc('PRIVMSG '.BOT_ANNOUNCE_CHAN.' FREELEECH - '.site_url()."torrents.php?id=$GroupID / ".site_url()."torrents.php?action=download&id=$TorrentID");
             }
         }

classes/torrentsdl.class.php

         {
             return (is_array($Ann)) ? array_map('add_passkey', $Ann) : $Ann."/".G::$LoggedUser['torrent_pass']."/announce";
         }
-        $this->AnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array(array_map('add_passkey', ANNOUNCE_URLS[0]), ANNOUNCE_URLS[1]);
+        $this->AnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array_map('add_passkey', ANNOUNCE_URLS[0]);
+        #$this->AnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array(array_map('add_passkey', ANNOUNCE_URLS[0]), ANNOUNCE_URLS[1]);
         #$this->AnnounceList = (sizeof(ANNOUNCE_URLS) == 1 && sizeof(ANNOUNCE_URLS[0]) == 1) ? [] : array_map('add_passkey', ANNOUNCE_URLS);
         $this->Zip = new Zip(Misc::file_string($Title));
     }

sections/donate/donate.php

   <div class="box pad donation_info">
     <p>
       <?= SITE_NAME ?> accepts donations on a tactful array of platforms.
-      We also accept tax-deductible donations on behalf of the
+      We also accept <strong>tax-deductible donations</strong> on behalf of the
       <a href="https://www.boslab.org/donate" target="_blank">Boston Open Science Laboratory (BosLab)</a>,
       a registered 501c3.
       Please use the memo field on BosLab's PayPal form to credit your <?= SITE_NAME ?> account.
       </ul>
 
     <p>
-      I also accept private donations of cash and cash equivalents, including Bitcoin and other cryptocurrencies.
-      Besides gift transactions sent to my personal PayPal account, I'll also accept USPS money orders in the mail.
+      I also accept private donations of cash and cash equivalents, including <strong>Bitcoin</strong> and other cryptocurrencies.
+      Besides gift transactions sent to my personal <strong>PayPal</strong> account, I'll also accept <strong>USPS money orders</strong> in the mail.
       I can generate unique cryptocurrency addresses for donations in Bitcoin, Litecoin, Curecoin, and Namecoin.
       Please use <a href="https://pgp.mit.edu/pks/lookup?op=get&search=0x760EBED7CFE266D7" target="_blank">GPG key 760EBED7CFE266D7</a> if you desire.
     </p>

sections/torrents/download.php

     return (is_array($ann)) ? array_map("add_passkey", $ann) : $ann."/".$TorrentPass."/announce";
 }
 $UserAnnounceURL = ANNOUNCE_URLS[0][0]."/".$TorrentPass."/announce";
-$UserAnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array(array_map('add_passkey', ANNOUNCE_URLS[0]), ANNOUNCE_URLS[1]);
+$UserAnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array_map('add_passkey', ANNOUNCE_URLS[0]);
+#$UserAnnounceList = (sizeof(ANNOUNCE_URLS) === 1 && sizeof(ANNOUNCE_URLS[0]) === 1) ? [] : array(array_map('add_passkey', ANNOUNCE_URLS[0]), ANNOUNCE_URLS[1]);
 #$UserAnnounceList = (sizeof(ANNOUNCE_URLS) == 1 && sizeof(ANNOUNCE_URLS[0]) == 1) ? [] : array_map("add_passkey", ANNOUNCE_URLS);
 
 echo TorrentsDL::get_file($Contents, $UserAnnounceURL, $UserAnnounceList);

sections/user/notify_handle.php

-<?
+<?php
+
 if (!check_perms('site_torrents_notify')) {
-  error(403);
+    error(403);
 }
 authorize();
 
 $HasFilter = false;
 
 if ($_POST['formid'] && is_number($_POST['formid'])) {
-  $FormID = $_POST['formid'];
+    $FormID = $_POST['formid'];
 }
 
 if ($_POST['artists'.$FormID]) {
-  $Artists = explode(',', $_POST['artists'.$FormID]);
-  $ParsedArtists = [];
-  foreach ($Artists as $Artist) {
-    if (trim($Artist) != '') {
-      $ParsedArtists[] = db_string(trim($Artist));
+    $Artists = explode(',', $_POST['artists'.$FormID]);
+    $ParsedArtists = [];
+    foreach ($Artists as $Artist) {
+        if (trim($Artist) !== '') {
+            $ParsedArtists[] = db_string(trim($Artist));
+        }
+    }
+    if (count($ParsedArtists) > 0) {
+        $ArtistList = '|'.implode('|', $ParsedArtists).'|';
+        $HasFilter = true;
     }
-  }
-  if (count($ParsedArtists) > 0) {
-    $ArtistList = '|'.implode('|', $ParsedArtists).'|';
-    $HasFilter = true;
-  }
 }
 
 if ($_POST['excludeva'.$FormID]) {
-  $ExcludeVA = '1';
-  $HasFilter = true;
+    $ExcludeVA = '1';
+    $HasFilter = true;
 } else {
-  $ExcludeVA = '0';
+    $ExcludeVA = '0';
 }
 
 if ($_POST['newgroupsonly'.$FormID]) {
-  $NewGroupsOnly = '1';
-  $HasFilter = true;
+    $NewGroupsOnly = '1';
+    $HasFilter = true;
 } else {
-  $NewGroupsOnly = '0';
+    $NewGroupsOnly = '0';
 }
 
 if ($_POST['tags'.$FormID]) {
-  $TagList = '|';
-  $Tags = explode(',', $_POST['tags'.$FormID]);
-  foreach ($Tags as $Tag) {
-    $TagList.=db_string(trim($Tag)).'|';
-  }
-  $HasFilter = true;
+    $TagList = '|';
+    $Tags = explode(',', $_POST['tags'.$FormID]);
+    foreach ($Tags as $Tag) {
+        $TagList.=db_string(trim($Tag)).'|';
+    }
+    $HasFilter = true;
 }
 
 if ($_POST['nottags'.$FormID]) {
-  $NotTagList = '|';
-  $Tags = explode(',', $_POST['nottags'.$FormID]);
-  foreach ($Tags as $Tag) {
-    $NotTagList.=db_string(trim($Tag)).'|';
-  }
-  $HasFilter = true;
+    $NotTagList = '|';
+    $Tags = explode(',', $_POST['nottags'.$FormID]);
+    foreach ($Tags as $Tag) {
+        $NotTagList.=db_string(trim($Tag)).'|';
+    }
+    $HasFilter = true;
 }
 
 if ($_POST['categories'.$FormID]) {
-  $CategoryList = '|';
-  foreach ($_POST['categories'.$FormID] as $Category) {
-    $CategoryList.=db_string(trim($Category)).'|';
-  }
-  $HasFilter = true;
+    $CategoryList = '|';
+    foreach ($_POST['categories'.$FormID] as $Category) {
+        $CategoryList.=db_string(trim($Category)).'|';
+    }
+    $HasFilter = true;
 }
 
 if ($_POST['media'.$FormID]) {
-  $MediaList = '|';
-  foreach ($_POST['media'.$FormID] as $Medium) {
-    $MediaList.=db_string(trim($Medium)).'|';
-  }
-  $HasFilter = true;
+    $MediaList = '|';
+    foreach ($_POST['media'.$FormID] as $Medium) {
+        $MediaList.=db_string(trim($Medium)).'|';
+    }
+    $HasFilter = true;
 }
 
 if ($_POST['users'.$FormID]) {
-  $Usernames = explode(',', $_POST['users'.$FormID]);
-  $EscapedUsernames = [];
-  foreach ($Usernames as $Username) {
-    $EscapedUsernames[] = db_string(trim($Username));;
-  }
+    $Usernames = explode(',', $_POST['users'.$FormID]);
+    $EscapedUsernames = [];
+    foreach ($Usernames as $Username) {
+        $EscapedUsernames[] = db_string(trim($Username));
+    }
 
-  $DB->query("
+    $DB->query("
     SELECT ID, Paranoia
     FROM users_main
     WHERE Username IN ('" . implode("', '", $EscapedUsernames) . "')
       AND ID != $LoggedUser[ID]");
-  while (list($UserID, $Paranoia) = $DB->next_record()) {
-    $Paranoia = unserialize($Paranoia);
-    if (!in_array('notifications', $Paranoia)) {
-      $Users .= '|' . $UserID . '|';
-      $HasFilter = true;
+    while (list($UserID, $Paranoia) = $DB->next_record()) {
+        $Paranoia = unserialize($Paranoia);
+        if (!in_array('notifications', $Paranoia)) {
+            $Users .= '|' . $UserID . '|';
+            $HasFilter = true;
+        }
     }
-  }
 }
 
 if (!$HasFilter) {
-  $Err = 'You must add at least one criterion to filter by';
+    $Err = 'You must add at least one criterion to filter by';
 } elseif (!$_POST['label'.$FormID] && !$_POST['id'.$FormID]) {
-  $Err = 'You must add a label for the filter set';
+    $Err = 'You must add a label for the filter set';
 }
 
 if ($Err) {
-  error($Err);
-  header('Location: user.php?action=notify');
-  die();
+    error($Err);
+    header('Location: user.php?action=notify');
+    die();
 }
 
 $ArtistList = str_replace('||', '|', $ArtistList);
 $Users = str_replace('||', '|', $Users);
 
 if ($_POST['id'.$FormID] && is_number($_POST['id'.$FormID])) {
-  $DB->query("
+    $DB->query("
     UPDATE users_notify_filters
     SET
       Artists='$ArtistList',
     WHERE ID='".$_POST['id'.$FormID]."'
       AND UserID='$LoggedUser[ID]'");
 } else {
-  $DB->query("
+    $DB->query("
     INSERT INTO users_notify_filters
       (UserID, Label, Artists, ExcludeVA, NewGroupsOnly, Tags, NotTags, Categories, Media, Users)
     VALUES
 }
 
 $Cache->delete_value('notify_filters_'.$LoggedUser['ID']);
-if (($Notify = $Cache->get_value('notify_artists_'.$LoggedUser['ID'])) !== false && $Notify['ID'] == $_POST['id'.$FormID]) {
-  $Cache->delete_value('notify_artists_'.$LoggedUser['ID']);
+if (($Notify = $Cache->get_value('notify_artists_'.$LoggedUser['ID'])) !== false && $Notify['ID'] === $_POST['id'.$FormID]) {
+    $Cache->delete_value('notify_artists_'.$LoggedUser['ID']);
 }
 header('Location: user.php?action=notify');
-?>