Browse Source

Fix "fix ghost entry" feature and use prepared queries on some classes

biotorrents 4 years ago
parent
commit
0a21914f54

+ 10
- 10
classes/artists.class.php View File

47
             }
47
             }
48
 
48
 
49
             $QueryID = G::$DB->get_query_id();
49
             $QueryID = G::$DB->get_query_id();
50
-            G::$DB->query("
50
+            G::$DB->prepared_query("
51
             SELECT
51
             SELECT
52
               ta.`GroupID`,
52
               ta.`GroupID`,
53
               ta.`ArtistID`,
53
               ta.`ArtistID`,
169
     public static function delete_artist($ArtistID)
169
     public static function delete_artist($ArtistID)
170
     {
170
     {
171
         $QueryID = G::$DB->get_query_id();
171
         $QueryID = G::$DB->get_query_id();
172
-        G::$DB->query("
172
+        G::$DB->prepared_query("
173
         SELECT
173
         SELECT
174
           `NAME`
174
           `NAME`
175
         FROM
175
         FROM
180
         list($Name) = G::$DB->next_record(MYSQLI_NUM, false);
180
         list($Name) = G::$DB->next_record(MYSQLI_NUM, false);
181
 
181
 
182
         // Delete requests
182
         // Delete requests
183
-        G::$DB->query("
183
+        G::$DB->prepared_query("
184
         SELECT
184
         SELECT
185
           `RequestID`
185
           `RequestID`
186
         FROM
186
         FROM
192
         $Requests = G::$DB->to_array();
192
         $Requests = G::$DB->to_array();
193
         foreach ($Requests as $Request) {
193
         foreach ($Requests as $Request) {
194
             list($RequestID) = $Request;
194
             list($RequestID) = $Request;
195
-            G::$DB->query("
195
+            G::$DB->prepared_query("
196
             DELETE
196
             DELETE
197
             FROM
197
             FROM
198
               `requests`
198
               `requests`
200
               `ID` = '$RequestID'
200
               `ID` = '$RequestID'
201
             ");
201
             ");
202
 
202
 
203
-            G::$DB->query("
203
+            G::$DB->prepared_query("
204
             DELETE
204
             DELETE
205
             FROM
205
             FROM
206
               `requests_votes`
206
               `requests_votes`
208
               `RequestID` = '$RequestID'
208
               `RequestID` = '$RequestID'
209
             ");
209
             ");
210
 
210
 
211
-            G::$DB->query("
211
+            G::$DB->prepared_query("
212
             DELETE
212
             DELETE
213
             FROM
213
             FROM
214
               `requests_tags`
214
               `requests_tags`
216
               `RequestID` = '$RequestID'
216
               `RequestID` = '$RequestID'
217
             ");
217
             ");
218
 
218
 
219
-            G::$DB->query("
219
+            G::$DB->prepared_query("
220
             DELETE
220
             DELETE
221
             FROM
221
             FROM
222
               `requests_artists`
222
               `requests_artists`
226
         }
226
         }
227
 
227
 
228
         // Delete artist
228
         // Delete artist
229
-        G::$DB->query("
229
+        G::$DB->prepared_query("
230
         DELETE
230
         DELETE
231
         FROM
231
         FROM
232
           `artists_group`
232
           `artists_group`
236
         G::$Cache->decrement('stats_artist_count');
236
         G::$Cache->decrement('stats_artist_count');
237
 
237
 
238
         // Delete wiki revisions
238
         // Delete wiki revisions
239
-        G::$DB->query("
239
+        G::$DB->prepared_query("
240
         DELETE
240
         DELETE
241
         FROM
241
         FROM
242
           `wiki_artists`
242
           `wiki_artists`
245
         ");
245
         ");
246
 
246
 
247
         // Delete tags
247
         // Delete tags
248
-        G::$DB->query("
248
+        G::$DB->prepared_query("
249
         DELETE
249
         DELETE
250
         FROM
250
         FROM
251
           `artists_tags`
251
           `artists_tags`

+ 2
- 2
classes/badges.class.php View File

28
             return false;
28
             return false;
29
         } else {
29
         } else {
30
             $QueryID = G::$DB->get_query_id();
30
             $QueryID = G::$DB->get_query_id();
31
-            G::$DB->query("
31
+            G::$DB->prepared_query("
32
             INSERT INTO `users_badges`(`UserID`, `BadgeID`)
32
             INSERT INTO `users_badges`(`UserID`, `BadgeID`)
33
             VALUES($UserID, $BadgeID)
33
             VALUES($UserID, $BadgeID)
34
             ");
34
             ");
126
     {
126
     {
127
         $QueryID = G::$DB->get_query_id();
127
         $QueryID = G::$DB->get_query_id();
128
 
128
 
129
-        G::$DB->query("
129
+        G::$DB->prepared_query("
130
         SELECT
130
         SELECT
131
           `ID`,
131
           `ID`,
132
           `Icon`,
132
           `Icon`,

+ 1
- 1
classes/bookmarks.class.php View File

97
             list($Table, $Col) = self::bookmark_schema($Type);
97
             list($Table, $Col) = self::bookmark_schema($Type);
98
             $QueryID = G::$DB->get_query_id();
98
             $QueryID = G::$DB->get_query_id();
99
 
99
 
100
-            G::$DB->query("
100
+            G::$DB->prepared_query("
101
             SELECT `$Col`
101
             SELECT `$Col`
102
             FROM `$Table`
102
             FROM `$Table`
103
               WHERE UserID = '$UserID'");
103
               WHERE UserID = '$UserID'");

+ 4
- 4
classes/collages.class.php View File

6
     public static function increase_subscriptions($CollageID)
6
     public static function increase_subscriptions($CollageID)
7
     {
7
     {
8
         $QueryID = G::$DB->get_query_id();
8
         $QueryID = G::$DB->get_query_id();
9
-        G::$DB->query("
9
+        G::$DB->prepared_query("
10
         UPDATE
10
         UPDATE
11
           `collages`
11
           `collages`
12
         SET
12
         SET
20
     public static function decrease_subscriptions($CollageID)
20
     public static function decrease_subscriptions($CollageID)
21
     {
21
     {
22
         $QueryID = G::$DB->get_query_id();
22
         $QueryID = G::$DB->get_query_id();
23
-        G::$DB->query("
23
+        G::$DB->prepared_query("
24
         UPDATE
24
         UPDATE
25
           `collages`
25
           `collages`
26
         SET
26
         SET
37
 
37
 
38
     public static function create_personal_collage()
38
     public static function create_personal_collage()
39
     {
39
     {
40
-        G::$DB->query("
40
+        G::$DB->prepared_query("
41
         SELECT
41
         SELECT
42
           COUNT(`ID`)
42
           COUNT(`ID`)
43
         FROM
43
         FROM
57
         $NameStr = db_string(G::$LoggedUser['Username']."'s personal collage".($CollageCount > 0 ? ' no. '.($CollageCount + 1) : ''));
57
         $NameStr = db_string(G::$LoggedUser['Username']."'s personal collage".($CollageCount > 0 ? ' no. '.($CollageCount + 1) : ''));
58
         $Description = db_string('Personal collage for '.G::$LoggedUser['Username'].'. The first 5 albums will appear on his or her [url='.site_url().'user.php?id= '.G::$LoggedUser['ID'].']profile[/url].');
58
         $Description = db_string('Personal collage for '.G::$LoggedUser['Username'].'. The first 5 albums will appear on his or her [url='.site_url().'user.php?id= '.G::$LoggedUser['ID'].']profile[/url].');
59
 
59
 
60
-        G::$DB->query("
60
+        G::$DB->prepared_query("
61
         INSERT INTO `collages`(
61
         INSERT INTO `collages`(
62
           `Name`,
62
           `Name`,
63
           `Description`,
63
           `Description`,

+ 7
- 3
sections/torrents/index.php View File

197
             break;
197
             break;
198
             
198
             
199
         case 'fix_group':
199
         case 'fix_group':
200
-            if ((check_perms('users_mod') || check_perms('torrents_fix_ghosts')) && authorize() && !empty($_GET['groupid']) && is_number($_GET['groupid'])) {
201
-                $DB->prepare_query("
200
+            if ((check_perms('users_mod') || check_perms('torrents_fix_ghosts'))
201
+              && !empty($_GET['groupid'])
202
+              && is_number($_GET['groupid'])
203
+                ) {
204
+                authorize();
205
+
206
+                $DB->prepared_query("
202
                 SELECT
207
                 SELECT
203
                   COUNT(`ID`)
208
                   COUNT(`ID`)
204
                 FROM
209
                 FROM
206
                 WHERE
211
                 WHERE
207
                   `GroupID` = '$_GET[groupid]'
212
                   `GroupID` = '$_GET[groupid]'
208
                 ");
213
                 ");
209
-                $DB->exec_prepared_query();
210
                 list($Count) = $DB->next_record();
214
                 list($Count) = $DB->next_record();
211
                 
215
                 
212
                 if ($Count === 0) {
216
                 if ($Count === 0) {

Loading…
Cancel
Save