Fix "fix ghost entry" feature and use prepared queries on some classes

classes/artists.class.php

@@ -47,7 +47,7 @@ class Artists
             }
 
             $QueryID = G::$DB->get_query_id();
-            G::$DB->query("
+            G::$DB->prepared_query("
             SELECT
               ta.`GroupID`,
               ta.`ArtistID`,
@@ -169,7 +169,7 @@ class Artists
     public static function delete_artist($ArtistID)
     {
         $QueryID = G::$DB->get_query_id();
-        G::$DB->query("
+        G::$DB->prepared_query("
         SELECT
           `NAME`
         FROM
@@ -180,7 +180,7 @@ class Artists
         list($Name) = G::$DB->next_record(MYSQLI_NUM, false);
 
         // Delete requests
-        G::$DB->query("
+        G::$DB->prepared_query("
         SELECT
           `RequestID`
         FROM
@@ -192,7 +192,7 @@ class Artists
         $Requests = G::$DB->to_array();
         foreach ($Requests as $Request) {
             list($RequestID) = $Request;
-            G::$DB->query("
+            G::$DB->prepared_query("
             DELETE
             FROM
               `requests`
@@ -200,7 +200,7 @@ class Artists
               `ID` = '$RequestID'
             ");
 
-            G::$DB->query("
+            G::$DB->prepared_query("
             DELETE
             FROM
               `requests_votes`
@@ -208,7 +208,7 @@ class Artists
               `RequestID` = '$RequestID'
             ");
 
-            G::$DB->query("
+            G::$DB->prepared_query("
             DELETE
             FROM
               `requests_tags`
@@ -216,7 +216,7 @@ class Artists
               `RequestID` = '$RequestID'
             ");
 
-            G::$DB->query("
+            G::$DB->prepared_query("
             DELETE
             FROM
               `requests_artists`
@@ -226,7 +226,7 @@ class Artists
         }
 
         // Delete artist
-        G::$DB->query("
+        G::$DB->prepared_query("
         DELETE
         FROM
           `artists_group`
@@ -236,7 +236,7 @@ class Artists
         G::$Cache->decrement('stats_artist_count');
 
         // Delete wiki revisions
-        G::$DB->query("
+        G::$DB->prepared_query("
         DELETE
         FROM
           `wiki_artists`
@@ -245,7 +245,7 @@ class Artists
         ");
 
         // Delete tags
-        G::$DB->query("
+        G::$DB->prepared_query("
         DELETE
         FROM
           `artists_tags`

classes/badges.class.php

@@ -28,7 +28,7 @@ class Badges
             return false;
         } else {
             $QueryID = G::$DB->get_query_id();
-            G::$DB->query("
+            G::$DB->prepared_query("
             INSERT INTO `users_badges`(`UserID`, `BadgeID`)
             VALUES($UserID, $BadgeID)
             ");
@@ -126,7 +126,7 @@ class Badges
     {
         $QueryID = G::$DB->get_query_id();
 
-        G::$DB->query("
+        G::$DB->prepared_query("
         SELECT
           `ID`,
           `Icon`,

classes/bookmarks.class.php

@@ -97,7 +97,7 @@ class Bookmarks
             list($Table, $Col) = self::bookmark_schema($Type);
             $QueryID = G::$DB->get_query_id();
 
-            G::$DB->query("
+            G::$DB->prepared_query("
             SELECT `$Col`
             FROM `$Table`
               WHERE UserID = '$UserID'");

classes/collages.class.php

@@ -6,7 +6,7 @@ class Collages
     public static function increase_subscriptions($CollageID)
     {
         $QueryID = G::$DB->get_query_id();
-        G::$DB->query("
+        G::$DB->prepared_query("
         UPDATE
           `collages`
         SET
@@ -20,7 +20,7 @@ class Collages
     public static function decrease_subscriptions($CollageID)
     {
         $QueryID = G::$DB->get_query_id();
-        G::$DB->query("
+        G::$DB->prepared_query("
         UPDATE
           `collages`
         SET
@@ -37,7 +37,7 @@ class Collages
 
     public static function create_personal_collage()
     {
-        G::$DB->query("
+        G::$DB->prepared_query("
         SELECT
           COUNT(`ID`)
         FROM
@@ -57,7 +57,7 @@ class Collages
         $NameStr = db_string(G::$LoggedUser['Username']."'s personal collage".($CollageCount > 0 ? ' no. '.($CollageCount + 1) : ''));
         $Description = db_string('Personal collage for '.G::$LoggedUser['Username'].'. The first 5 albums will appear on his or her [url='.site_url().'user.php?id= '.G::$LoggedUser['ID'].']profile[/url].');
 
-        G::$DB->query("
+        G::$DB->prepared_query("
         INSERT INTO `collages`(
           `Name`,
           `Description`,

sections/torrents/index.php

@@ -197,8 +197,13 @@ if (!empty($_REQUEST['action'])) {
             break;
             
         case 'fix_group':
-            if ((check_perms('users_mod') || check_perms('torrents_fix_ghosts')) && authorize() && !empty($_GET['groupid']) && is_number($_GET['groupid'])) {
-                $DB->prepare_query("
+            if ((check_perms('users_mod') || check_perms('torrents_fix_ghosts'))
+              && !empty($_GET['groupid'])
+              && is_number($_GET['groupid'])
+                ) {
+                authorize();
+
+                $DB->prepared_query("
                 SELECT
                   COUNT(`ID`)
                 FROM
@@ -206,7 +211,6 @@ if (!empty($_REQUEST['action'])) {
                 WHERE
                   `GroupID` = '$_GET[groupid]'
                 ");
-                $DB->exec_prepared_query();
                 list($Count) = $DB->next_record();
                 
                 if ($Count === 0) {