xoru commented 6 years ago
Review
+ does do concatenation, but yeah it’s wrong to use it here since it ignores duplicate keys. Switched to array_merge and now it works as expected
xoru/Gazelle:fix-jdb-autofill into master 6 years ago
|
||
| 108 | 108 |
|
| 109 | 109 |
|
| 110 | 110 |
|
| 111 |
|
|
| 111 |
|
|
| 112 | 112 |
|
| 113 | 113 |
|
| 114 | 114 |
|
|
||
| 125 | 125 |
|
| 126 | 126 |
|
| 127 | 127 |
|
| 128 |
|
|
| 128 |
|
|
| 129 | 129 |
|
| 130 | 130 |
|
| 131 | 131 |
|
|
||
| 135 | 135 |
|
| 136 | 136 |
|
| 137 | 137 |
|
| 138 |
|
|
| 138 |
|
|
| 139 | 139 |
|
| 140 | 140 |
|
| 141 | 141 |
|
|
||
| 144 | 144 |
|
| 145 | 145 |
|
| 146 | 146 |
|
| 147 |
|
|
| 148 |
|
|
| 149 |
|
|
| 150 |
|
|
| 151 |
|
|
| 152 |
|
|
| 153 |
|
|
| 154 |
|
|
| 155 |
|
|
| 156 |
|
|
| 157 |
|
|
| 158 |
|
|
| 159 |
|
|
| 160 |
|
|
| 161 |
|
|
| 162 |
|
|
| 163 |
|
|
| 164 |
|
|
| 165 |
|
|
| 166 |
|
|
| 167 |
|
|
| 168 |
|
|
| 169 |
|
|
| 170 |
|
|
| 171 |
|
|
| 172 |
|
|
| 173 |
|
|
| 174 |
|
|
| 175 |
|
|
| 176 |
|
|
| 177 |
|
|
| 178 |
|
|
| 179 |
|
|
| 180 |
|
|
| 181 |
|
|
| 182 |
|
|
| 183 |
|
|
| 184 |
|
|
| 185 |
|
|
| 186 |
|
|
| 187 |
|
|
| 188 |
|
|
| 189 |
|
|
| 190 |
|
|
| 191 |
|
|
| 192 |
|
|
| 193 |
|
|
| 194 |
|
|
| 195 |
|
|
| 196 |
|
|
| 197 |
|
|
| 198 |
|
|
| 199 |
|
|
| 200 |
|
|
| 201 |
|
|
| 202 |
|
|
| 203 |
|
|
| 204 |
|
|
| 205 |
|
|
| 206 |
|
|
| 207 |
|
|
| 208 |
|
|
|
|
||
| 209 |
|
|
| 210 |
|
|
| 211 |
|
|
| 212 |
|
|
|
xoru commented 6 years ago
Review
spaghetti commented 6 years ago
Review
Yeah that makes it a union operation, not concatenation.
xoru commented 6 years ago
Review
You’re right, I’m retarded |
||
| 213 |
|
|
| 214 |
|
|
| 215 |
|
|
| 216 |
|
|
| 217 |
|
|
| 218 |
|
|
| 219 |
|
|
| 220 |
|
|
| 147 | 221 |
|
| 148 | 222 |
|
| 149 | 223 |
|
I would definitely prefer if we just created aliases for these tags using gazelle’s built in tooling and let that system handle these transformations, but I don’t really want to do the work to add them so this is fine.