Home Explore Help
Register Sign In
Oppaitime
/
Gazelle
Watch 9
Star 11
Fork 18
Code Issues 21 Pull Requests 7 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#38 Change Log RSS Feed loading Misc class for a 2nd time.

Closed
ambiguousplanca wants to merge 3 commits from deleteme/Gazelle:master into master
Conversation 2 Commits 3 Files Changed 1
ambiguousplanca commented 7 years ago

Was getting this error when loading the Change Log feed: PHP Fatal error: Cannot declare class Misc, because the name is already in use in /var/www/classes/misc.class.php on line 2. The require line might have been able to be removed completely, but I wasn’t sure (it runs fine for me without it, but there must be some other way this page is loaded without the Misc class included or I assume someone would’ve noticed this much sooner). So I switched it to require_once.

Was getting this error when loading the Change Log feed: `PHP Fatal error: Cannot declare class Misc, because the name is already in use in /var/www/classes/misc.class.php on line 2`. The require line might have been able to be removed completely, but I wasn't sure (it runs fine for me without it, but there must be some other way this page is loaded without the Misc class included or I assume someone would've noticed this much sooner). So I switched it to require_once.
ambiguousplanca commented 7 years ago
Poster

Actually, it looks like classes/misc.class.php is included in /feeds.php, and /sections/feeds/index.php is only ever called by /feeds.php. So it is definitely not needed.

Actually, it looks like classes/misc.class.php is included in /feeds.php, and /sections/feeds/index.php is only ever called by /feeds.php. So it is definitely not needed.
spaghetti commented 7 years ago
Owner

Thanks. Went ahead and made a somewhat larger change based on this that includes the same fix. Appreciate the report and debugging.

Thanks. Went ahead and made a somewhat larger change based on this that includes the same fix. Appreciate the report and debugging.
spaghetti closed 7 years ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Labels
Clear labels
Blocked Breaking Easy Enhancement Feature Request In Progress Migrated Issue Needs Research Security
No Label
Blocked
Breaking
Easy
Enhancement
Feature Request
In Progress
Migrated Issue
Needs Research
Security
Milestone
Clear milestone
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'deleteme/Gazelle:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes