#49 Fix user limit reached notice

Merged
spaghetti merged 2 commits from Syunka:fix-user-limit-notice into master 7 years ago
Syunka commented 7 years ago

When USER_LIMIT == 0 (no limit) $UserCount is always > USER_LIMIT so the notice is always shown. Actually this commit just implements the exact opposite of the logic on line 137.

When USER_LIMIT == 0 (no limit) $UserCount is always > USER_LIMIT so the notice is always shown. Actually this commit just implements the exact opposite of the logic on line 137.
spaghetti commented 7 years ago
Owner

I think it would be clearer as

($UserCount >= USER_LIMIT && USER_LIMIT != 0 && !check_perms('site_can_invite_always'))

instead of

(!($UserCount <= USER_LIMIT || USER_LIMIT == 0 || check_perms('site_can_invite_always'))).

If you make that change I’ll be happy to merge it.

I think it would be clearer as ```($UserCount >= USER_LIMIT && USER_LIMIT != 0 && !check_perms('site_can_invite_always'))``` instead of ```(!($UserCount <= USER_LIMIT || USER_LIMIT == 0 || check_perms('site_can_invite_always')))```. If you make that change I'll be happy to merge it.
Syunka commented 7 years ago
Poster

OK, I have pushed a new commit with those changes.

OK, I have pushed a new commit with those changes.
The pull request has been merged.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.