Merge some javascript

- Removed unused JS functions
- Inlined functions not often used
- Minimized some overly verbose functions

classes/view.class.php

@@ -30,7 +30,7 @@ class View {
       require(SERVER_ROOT.'/design/publicheader.php');
     } else {
       // HTTP/2 Server Push headers for cloudflare
-      $Scripts = array_merge(['jquery', 'script_start', 'ajax.class', 'global', 'jquery.autocomplete', 'autocomplete', 'tooltipster', 'tooltipster_settings'], explode(',', $JSIncludes));
+      $Scripts = array_merge(['jquery', 'global', 'ajax.class', 'jquery.autocomplete', 'autocomplete', 'tooltipster', 'tooltipster_settings'], explode(',', $JSIncludes));
       $Styles = array_merge(['tooltipster'], explode(',', $CSSIncludes));
       foreach ($Scripts as $Script) {
         if (trim($Script) == '') { continue; }

design/privateheader.php

@@ -95,11 +95,10 @@ foreach ($ExtraCSS as $CSS) {
 <?
 }
 
-$Scripts = array_merge(array('jquery', 'script_start', 'ajax.class', 'global', 'jquery.autocomplete', 'autocomplete', 'tooltipster', 'tooltipster_settings'), explode(',', $JSIncludes));
+$Scripts = array_merge(array('jquery', 'global', 'ajax.class', 'jquery.autocomplete', 'autocomplete', 'tooltipster', 'tooltipster_settings'), explode(',', $JSIncludes));
 foreach ($Scripts as $Script) {
-  if (trim($Script) == '') {
-    continue;
-  }
+  if (trim($Script) == '') { continue; }
+  $Async = (in_array($Script, ['jquery','global','ajax.class'])) ? '' : 'async';
   if (($ScriptStats = G::$Cache->get_value("script_stats_$Script")) === false || $ScriptStats['mtime'] != filemtime(SERVER_ROOT.STATIC_SERVER."functions/$Script.js")) {
     $ScriptStats['mtime'] = filemtime(SERVER_ROOT.STATIC_SERVER."functions/$Script.js");
     $ScriptStats['hash'] = base64_encode(hash_file(INTEGRITY_ALGO, SERVER_ROOT.STATIC_SERVER."functions/$Script.js", true));
@@ -107,7 +106,7 @@ foreach ($Scripts as $Script) {
     G::$Cache->cache_value("script_stats_$Script", $ScriptStats);
   }
 ?>
-  <script src="<?=STATIC_SERVER."functions/$Script.js?v=$ScriptStats[mtime]"?>" type="text/javascript" integrity="<?="$ScriptStats[algo]-$ScriptStats[hash]"?>"></script>
+  <script src="<?=STATIC_SERVER."functions/$Script.js?v=$ScriptStats[mtime]"?>" type="text/javascript" integrity="<?="$ScriptStats[algo]-$ScriptStats[hash]"?>" <?=$Async?>></script>
 <?
 }
 

design/publicheader.php

@@ -11,7 +11,7 @@ define('FOOTER_FILE',SERVER_ROOT.'/design/publicfooter.php');
   <link rel="shortcut icon" href="favicon.ico?v=<?=md5_file('favicon.ico');?>" />
   <link href="<?=STATIC_SERVER ?>styles/public/style.css?v=<?=filemtime(SERVER_ROOT.'/static/styles/public/style.css')?>" rel="stylesheet" type="text/css" />
 <?
-  $Scripts = ['jquery', 'script_start', 'ajax.class', 'cookie.class', 'storage.class', 'global', 'public'];
+  $Scripts = ['jquery', 'global', 'ajax.class', 'cookie.class', 'storage.class', 'public'];
   foreach($Scripts as $Script) {
     if (($ScriptStats = G::$Cache->get_value("script_stats_$Script")) === false || $ScriptStats['mtime'] != filemtime(SERVER_ROOT.STATIC_SERVER."functions/$Script.js")) {
       $ScriptStats['mtime'] = filemtime(SERVER_ROOT.STATIC_SERVER."functions/$Script.js");

static/functions/ajax.class.js

@@ -21,27 +21,9 @@
 
 */
 "use strict";
-var json = {
-  encode: function (object) {
-    try {
-      return JSON.stringify(object);
-    } catch (err) {
-      return '';
-    }
-  },
-  decode: function (string) {
-    if (window.JSON && JSON.parse) {
-      return JSON.parse(string);
-    } else {
-      return eval("(" + string + ")");
-      //return (new Function("return " + data))();
-    }
-  }
-};
-
 var ajax = {
   get: function (url, callback) {
-    var req = (typeof(window.ActiveXObject) === 'undefined') ? new XMLHttpRequest() : new ActiveXObject("Microsoft.XMLHTTP");
+    var req = new XMLHttpRequest();
     if (callback !== undefined) {
       req.onreadystatechange = function () {
         if (req.readyState !== 4 || req.status !== 200) {
@@ -54,7 +36,7 @@ var ajax = {
     req.send(null);
   },
   post: function (url, data, callback) {
-    var req = isset(window.ActiveXObject) ? new ActiveXObject("Microsoft.XMLHTTP") : new XMLHttpRequest();
+    var req = new XMLHttpRequest();
     var params = ajax.serialize(data);
     if (callback !== undefined) {
       req.onreadystatechange = function () {
@@ -71,7 +53,7 @@ var ajax = {
   serialize: function (data) {
     var query = '',
       elements;
-    if (is_array(data)) {
+    if (Array.isArray(data)) {
       for (var key in data) {
         query += key + '=' + encodeURIComponent(data[key]) + '&';
       }
@@ -79,7 +61,7 @@ var ajax = {
       elements = document.getElementById(data).elements;
       for (var i = 0, il = elements.length; i < il; i++) {
         var element = elements[i];
-        if (!isset(element) || element.disabled || element.name === '') {
+        if (!element || element.disabled || element.name === '') {
           continue;
         }
         switch (element.type) {

static/functions/autocomplete.js

@@ -4,7 +4,10 @@ var SELECTOR = '[data-gazelle-autocomplete="true"]';
 $(document).ready(initAutocomplete)
 
 function initAutocomplete() {
-  var url = new URL();
+  var url = {
+    path: window.location.pathname.split('/').reverse()[0].split(".")[0],
+    query: window.location.search.slice(1).split('&').reduce((a,b)=>Object.assign(a,{[b.split('=')[0]]:b.split('=')[1]}),{})
+  }
 
   $('#artistsearch' + SELECTOR).autocomplete({
     deferRequestBy: 300,

static/functions/comments.js

@@ -1,6 +1,6 @@
 var username;
 var postid;
-var url = new URL();
+var url = {path: window.location.pathname.split('/').reverse()[0].split('.')[0]};
 
 function QuoteJump(event, post) {
   var button = event.button;
@@ -42,12 +42,8 @@ function QuoteJump(event, post) {
   }
 }
 
-function Quote(post, user) {
-  Quote(post, user, false)
-}
-
 var original_post;
-function Quote(post, user, link) {
+function Quote(post, user, link = false) {
   username = user;
   postid = post;
 
@@ -65,7 +61,11 @@ function Quote(post, user, link) {
         }
       }).done(function(response) {
         $("#content" + postid).html(response['response']['body']);
-        select_all($("#content" + postid).get(0));
+        var range = document.createRange();
+        range.selectNodeContents($("#content" + postid).get(0));
+        var sel = window.getSelection();
+        sel.removeAllRanges();
+        sel.addRange(range);
       });
     } else {
       document.getSelection().removeAllRanges();

static/functions/form_validate.js

@@ -1,46 +1,12 @@
 $(document).ready(function() {
-  var url = new URL();
-  var query = url.query;
-  switch (url.path) {
-    case "forums":
-      if (query['action'] == "new") {
-        $("#newthreadform").validate();
-      }
-      break;
-    case "reports":
-      if (query['action'] == "report") {
-        $("#report_form").validate();
-      }
-      break;
-    case "inbox":
-      if (query['action'] == "viewconv" || query['action'] == "compose") {
-        $("#messageform").validate();
-      }
-      break;
-    case "user":
-      if (query['action'] == "notify") {
-        $("#filter_form").validate();
-      }
-      break;
-    case "requests":
-      if (query['action'] == "new") {
-        $("#request_form").preventDoubleSubmission();
-      }
-      break;
-    case "sitehistory":
-      if (query['action'] == "edit") {
-        $("#event_form").validate();
-      }
-      break;
-    case "tools":
-      if (query['action'] == "calendar") {
-        $("#event_form").validate();
-      }
-      if (query['action'] == "mass_pm") {
-        $("#messageform").validate();
-      }
-      break;
-    default:
-      break;
-  }
+  var path = window.location.pathname.split('/').reverse()[0].split(".")[0];
+  var action = (window.location.search.match(/action=([^&]+q)/)||[,''])[1];
+  if (path == "forums" && action == "new") $("#newthreadform").validate();
+  if (path == "reports" && action == "report") $("#report_form").validate();
+  if (path == "inbox" && (action == "viewconv" || action == "compose")) $("#messageform").validate();
+  if (path == "user" && action == "notify") $("#filter_form").validate();
+  if (path == "requests" && action == "new") $("#request_form").preventDoubleSubmission();
+  if (path == "sitehistory" && action == "edit") $("#event_form").validate();
+  if (path == "tools" && action == "calendar") $("#event_form").validate();
+  if (path == "tools" && action == "mass_pm") $("#messageform").validate();
 });

static/functions/global.js

@@ -1,3 +1,189 @@
+"use strict";
+
+//PHP ports
+function html_entity_decode(str) {
+  var el = document.createElement("div");
+  el.innerHTML = str;
+  for (var i = 0, ret = ''; i < el.childNodes.length; i++) {
+    ret += el.childNodes[i].nodeValue;
+  }
+  return ret;
+}
+
+function get_size(size) {
+  var steps = 0;
+  for (; size >= 1024; size /= 1024, steps++);
+  var exts = ['B','KiB','MiB','GiB','TiB','PiB','EiB','ZiB','YiB']
+  return (size.toFixed(2) + (exts[steps]||''))
+}
+
+function ratio(a, b) {
+  var rc = 'r50';
+  for (var i of [[5,  '20'],[2,  '10'],[1,  '09'],[0.9,'08'],[0.8,'07'],[0.7,'06'],
+                 [0.6,'05'],[0.5,'04'],[0.4,'03'],[0.3,'02'],[0.2,'01'],[0.1,'00']]) {
+    if (a/b < i[0]) rc = 'r'+i[1];
+  }
+  if (b == 0) return a ? '<span class="r99">∞</span>' : '--';
+  return '<span class="'+rc+'">'+((a/b)-0.005).toFixed(2)+'</span>';
+}
+
+function save_message(message, err = false) {
+  var messageDiv = document.createElement("div");
+  messageDiv.className = err ? "error_message" : "save_message";
+  messageDiv.innerHTML = message;
+  $("#content").raw().insertBefore(messageDiv,$("#content").raw().firstChild);
+}
+
+$.fn.extend({
+  results: function () {
+    return this.size();
+  },
+  gshow: function () {
+    return this.remove_class('hidden');
+  },
+  ghide: function (force) {
+    return this.add_class('hidden', force);
+  },
+  gtoggle: function (force) {
+    if (this[0].className.split(' ').indexOf('hidden') == -1) {
+      this.add_class('hidden', force);
+    } else {
+      this.remove_class('hidden');
+    }
+    return this;
+  },
+  listen: function (event, callback) {
+    for (var i = 0, il = this.size(); i < il; i++) {
+      var object = this[i];
+      if (document.addEventListener) {
+        object.addEventListener(event, callback, false);
+      } else {
+        object.attachEvent('on' + event, callback);
+      }
+    }
+    return this;
+  },
+  add_class: function (class_name, force) {
+    for (var i = 0, il = this.size(); i < il; i++) {
+      var object = this[i];
+      if (object.className === '') {
+        object.className = class_name;
+      } else if (force || object.className.split(' ').indexOf(class_name) == -1) {
+        object.className = object.className + ' ' + class_name;
+      }
+    }
+    return this;
+  },
+  remove_class: function (class_name) {
+    for (var i = 0, il = this.size(); i < il; i++) {
+      var object = this[i];
+      var classes = object.className.split(' ');
+      var result = classes.indexOf(class_name);
+      if (result != -1) {
+        classes.splice(result, 1);
+        object.className = classes.join(' ');
+      }
+    }
+    return this;
+  },
+  has_class: function(class_name) {
+    for (var i = 0, il = this.size(); i < il; i++) {
+      var object = this[i];
+      var classes = object.className.split(' ');
+      if (classes.indexOf(class_name) != -1) {
+        return true;
+      }
+    }
+    return false;
+  },
+  toggle_class: function(class_name) {
+    for (var i = 0, il = this.size(); i < il; i++) {
+      var object = this[i];
+      var classes = object.className.split(' ');
+      var result = classes.indexOf(class_name);
+      if (result != -1) {
+        classes.splice(result, 1);
+        object.className = classes.join(' ');
+      } else {
+        if (object.className === '') {
+          object.className = class_name;
+        } else {
+          object.className = object.className + ' ' + class_name;
+        }
+      }
+    }
+    return this;
+  },
+  disable : function () {
+    $(this).prop('disabled', true);
+    return this;
+  },
+  enable : function () {
+    $(this).prop('disabled', false);
+    return this;
+  },
+  raw: function (number) {
+    if (typeof number == 'undefined') {
+      number = 0;
+    }
+    return $(this).get(number);
+  },
+  nextElementSibling: function () {
+    var here = this[0];
+    if (here.nextElementSibling) {
+      return $(here.nextElementSibling);
+    }
+    do {
+      here = here.nextSibling;
+    } while (here.nodeType != 1);
+    return $(here);
+  },
+  previousElementSibling: function () {
+    var here = this[0];
+    if (here.previousElementSibling) {
+      return $(here.previousElementSibling);
+    }
+    do {
+      here = here.nextSibling;
+    } while (here.nodeType != 1);
+    return $(here);
+  },
+  updateTooltip: function(tooltip) {
+    if ($.fn.tooltipster) {
+      $(this).tooltipster('update', tooltip);
+    } else {
+      $(this).attr('title', tooltip);
+    }
+    return this;
+  },
+
+  // Disable unset form elements to allow search URLs cleanups
+  disableUnset: function() {
+    $('input, select', this).filter(function() {
+      return $(this).val() === "";
+    }).disable();
+    return this;
+  },
+
+  // Prevent double submission of forms
+  preventDoubleSubmission: function() {
+    $(this).submit(function(e) {
+      var $form = $(this);
+      if ($form.data('submitted') === true) {
+        e.preventDefault();
+      } else {
+        $form.data('submitted', true);
+      }
+    });
+    return this;
+  }
+});
+
+if ($('meta[name=authkey]').raw()) {
+  var authkey = $('meta[name=authkey]').raw().content;
+  var userid = parseInt($('meta[name=userid]').raw().content);
+}
+
 /**
  * Check or uncheck checkboxes in formElem
  * If masterElem is false, toggle each box, otherwise use masterElem's status on all boxes
@@ -14,13 +200,6 @@ function toggleChecks(formElem, masterElem, elemSelector) {
   }
 }
 
-//Lightbox stuff
-
-/*
- * If loading from a thumbnail, the lightbox is shown first with a "loading" screen
- * while the full size image loads, then the HTML of the lightbox is replaced with the image.
- */
-
 var lightbox = {
   init: function (image, size) {
     if ($('#lightbox').length == 0 || $('#curtain').length == 0) {
@@ -49,7 +228,6 @@ var lightbox = {
       tmp.style.visibility = 'hidden';
       tmp.src = image.src;
       image.naturalWidth = tmp.width;
-      delete tmp;
     }
     if (image.naturalWidth > size) {
       lightbox.box(image);
@@ -90,38 +268,9 @@ window.onkeydown = function(e) {
   }
 }
 
-/* Still some issues
-function caps_check(e) {
-  if (e === undefined) {
-    e = window.event;
-  }
-  if (e.which === undefined) {
-    e.which = e.keyCode;
-  }
-  if (e.which > 47 && e.which < 58) {
-    return;
-  }
-  if ((e.which > 64 && e.which < 91 && !e.shiftKey) || (e.which > 96 && e.which < 123 && e.shiftKey)) {
-    $('#capslock').gshow();
-  }
-}
-*/
-
-function hexify(str) {
-  str = str.replace(/rgb\(|\)/g, "").split(",");
-  str[0] = parseInt(str[0], 10).toString(16).toLowerCase();
-  str[1] = parseInt(str[1], 10).toString(16).toLowerCase();
-  str[2] = parseInt(str[2], 10).toString(16).toLowerCase();
-  str[0] = (str[0].length == 1) ? '0' + str[0] : str[0];
-  str[1] = (str[1].length == 1) ? '0' + str[1] : str[1];
-  str[2] = (str[2].length == 1) ? '0' + str[2] : str[2];
-  return (str.join(""));
-}
-
 function resize(id) {
   var textarea = document.getElementById(id);
   if (textarea.scrollHeight > textarea.clientHeight) {
-    //textarea.style.overflowY = 'hidden';
     textarea.style.height = Math.min(1000, textarea.scrollHeight + textarea.style.fontSize) + 'px';
   }
 }
@@ -146,21 +295,6 @@ function remove_selection(index) {
   $('#opt' + index).raw().disabled = '';
 }
 
-// Thank you http://stackoverflow.com/questions/4578398/selecting-all-text-within-a-div-on-a-single-left-click-with-javascript
-function select_all(el) {
-  if (typeof window.getSelection != "undefined" && typeof document.createRange != "undefined") {
-    var range = document.createRange();
-    range.selectNodeContents(el);
-    var sel = window.getSelection();
-    sel.removeAllRanges();
-    sel.addRange(range);
-  } else if (typeof document.selection != "undefined" && typeof document.body.createTextRange != "undefined") {
-    var textRange = document.body.createTextRange();
-    textRange.moveToElementText(el);
-    textRange.select();
-  }
-}
-
 function preload(image) {
   var img = document.createElement('img')
   img.style.display = 'none'
@@ -170,7 +304,7 @@ function preload(image) {
 }
 
 function getCover(event) {
-  image = event.target.attributes['data-cover'].value
+  var image = event.target.attributes['data-cover'].value
   $('#coverCont img').remove()
   var coverCont = ($('#coverCont').length==0)?document.body.appendChild(document.createElement('div')):$('#coverCont')[0]
   coverCont.id = 'coverCont'
@@ -194,7 +328,7 @@ function ungetCover(event) {
 }
 
 // Apparently firefox doesn't implement NodeList.forEach until FF50
-// Remove this shim awter that's stable for a while
+// Remove this shim after that's stable for a while
 if (typeof NodeList.prototype.forEach !== 'function') {
   NodeList.prototype.forEach = Array.prototype.forEach
 }

static/functions/requests.js

@@ -31,7 +31,7 @@ function Vote(amount, requestid) {
 
   ajax.get('requests.php?action=takevote&id=' + requestid + '&auth=' + authkey + '&amount=' + amount, function (response) {
       if (response == 'bankrupt') {
-        error_message("You do not have sufficient upload credit to add " + get_size(amount) + " to this request");
+        save_message("You do not have sufficient upload credit to add " + get_size(amount) + " to this request", true);
         return;
       } else if (response == 'dupesuccess') {
         //No increment

static/functions/script_start.js

@@ -1,368 +0,0 @@
-"use strict";
-
-/* Prototypes */
-if (!String.prototype.trim) {
-  String.prototype.trim = function () {
-    return this.replace(/^\s+|\s+$/g,'');
-  };
-}
-
-var listener = {
-  set: function (el,type,callback) {
-    if (document.addEventListener) {
-      el.addEventListener(type, callback, false);
-    } else {
-      // IE hack courtesy of http://blog.stchur.com/2006/10/12/fixing-ies-attachevent-failures
-      var f = function() {
-        callback.call(el);
-      };
-      el.attachEvent('on' + type, f);
-    }
-  }
-};
-
-/* Site wide functions */
-
-// http://www.thefutureoftheweb.com/blog/adddomloadevent
-// retrieved 2010-08-12
-var addDOMLoadEvent = (
-  function() {
-    var e = [], t, s, n, i, o, d = document, w = window, r = 'readyState', c = 'onreadystatechange',
-      x = function() {
-          n = 1;
-          clearInterval(t);
-          while (i = e.shift()) {
-            i();
-          }
-          if (s) {
-            s[c] = ''
-          }
-        };
-    return function(f) {
-        if (n) {
-          return f();
-        }
-        if (!e[0]) {
-          d.addEventListener && d.addEventListener("DOMContentLoaded", x, false);
-          /*@cc_on@*//*@if(@_win32)d.write("<script id=__ie_onload defer src=//0><\/scr"+"ipt>");s=d.getElementById("__ie_onload");s[c]=function(){s[r]=="complete"&&x()};/*@end@*/
-          if (/WebKit/i.test(navigator.userAgent))
-            t = setInterval(function() {
-                /loaded|complete/.test(d[r]) && x()
-                }, 10);
-            o = w.onload;
-            w.onload = function() {
-                x();
-                o && o()
-                }
-        }
-        e.push(f)
-        }
-  }
-)();
-
-//PHP ports
-function isset(variable) {
-  return (typeof(variable) === 'undefined') ? false : true;
-}
-
-function is_array(input) {
-  return typeof(input) === 'object' && input instanceof Array;
-}
-
-function function_exists(function_name) {
-  return (typeof this.window[function_name] === 'function');
-}
-
-function html_entity_decode(str) {
-  var el = document.createElement("div");
-  el.innerHTML = str;
-  for (var i = 0, ret = ''; i < el.childNodes.length; i++) {
-    ret += el.childNodes[i].nodeValue;
-  }
-  return ret;
-}
-
-function get_size(size) {
-  var steps = 0
-  while (size >= 1024) {
-    steps++
-    size = size / 1024
-  }
-  var exts = ['B','KiB','MiB','GiB','TiB','PiB','EiB','ZiB','YiB']
-  return (size.toFixed(2) + (exts[steps]||''))
-}
-
-function get_ratio_color(ratio) {
-  if (ratio < 0.1) { return 'r00'; }
-  if (ratio < 0.2) { return 'r01'; }
-  if (ratio < 0.3) { return 'r02'; }
-  if (ratio < 0.4) { return 'r03'; }
-  if (ratio < 0.5) { return 'r04'; }
-  if (ratio < 0.6) { return 'r05'; }
-  if (ratio < 0.7) { return 'r06'; }
-  if (ratio < 0.8) { return 'r07'; }
-  if (ratio < 0.9) { return 'r08'; }
-  if (ratio < 1) { return 'r09'; }
-  if (ratio < 2) { return 'r10'; }
-  if (ratio < 5) { return 'r20'; }
-  return 'r50';
-}
-
-function ratio(dividend, divisor, color) {
-  if (!color) {
-    color = true;
-  }
-  if (divisor == 0 && dividend == 0) {
-    return '--';
-  } else if (divisor == 0) {
-    return '<span class="r99">∞</span>';
-  } else if (dividend == 0 && divisor > 0) {
-    return '<span class="r00">-∞</span>';
-  }
-  var rat = ((dividend / divisor) - 0.005).toFixed(2); //Subtract .005 to floor to 2 decimals
-  if (color) {
-    var col = get_ratio_color(rat);
-    if (col) {
-      rat = '<span class="' + col + '">' + rat + '</span>';
-    }
-  }
-  return rat;
-}
-
-
-function save_message(message) {
-  var messageDiv = document.createElement("div");
-  messageDiv.className = "save_message";
-  messageDiv.innerHTML = message;
-  $("#content").raw().insertBefore(messageDiv,$("#content").raw().firstChild);
-}
-
-function error_message(message) {
-  var messageDiv = document.createElement("div");
-  messageDiv.className = "error_message";
-  messageDiv.innerHTML = message;
-  $("#content").raw().insertBefore(messageDiv,$("#content").raw().firstChild);
-}
-
-//returns key if true, and false if false. better than the PHP funciton
-function in_array(needle, haystack, strict) {
-  if (strict === undefined) {
-    strict = false;
-  }
-  for (var key in haystack) {
-    if ((haystack[key] == needle && strict === false) || haystack[key] === needle) {
-      return true;
-    }
-  }
-  return false;
-}
-
-function array_search(needle, haystack, strict) {
-  if (strict === undefined) {
-    strict = false;
-  }
-  for (var key in haystack) {
-    if ((strict === false && haystack[key] == needle) || haystack[key] === needle) {
-      return key;
-    }
-  }
-  return false;
-}
-
-var util = function (selector, context) {
-  return new util.fn.init(selector, context);
-}
-
-function URL() {
-  var path = window.location.pathname.split('/');
-  var path = path[path.length - 1].split(".")[0];
-  var splitted = window.location.search.substr(1).split("&");
-  var query = {};
-  var length = 0;
-  for (var i = 0; i < splitted.length; i++) {
-    var q = splitted[i].split("=");
-    if (q != "") {
-      query[q[0]] = q[1];
-      length++;
-    }
-  };
-  query['length'] = length;
-  var response = new Array();
-  response['path'] = path;
-  response['query'] = query;
-  return response;
-}
-
-function isNumberKey(e) {
-  var charCode = (e.which) ? e.which : e.keyCode
-  if (charCode == 46) {
-    return true;
-  }
-  if (charCode > 31 && (charCode < 48 || charCode > 57)) {
-    return false;
-  }
-  return true;
-}
-
-function sleep(milliseconds) {
-  var start = new Date().getTime();
-  for (var i = 0; i < 1e7; i++) {
-    if ((new Date().getTime() - start) > milliseconds){
-      break;
-    }
-  }
-}
-
-$.fn.extend({
-  results: function () {
-    return this.size();
-  },
-  gshow: function () {
-    return this.remove_class('hidden');
-  },
-  ghide: function (force) {
-    return this.add_class('hidden', force);
-  },
-  gtoggle: function (force) {
-    //Should we interate and invert all entries, or just go by the first?
-    if (!in_array('hidden', this[0].className.split(' '))) {
-      this.add_class('hidden', force);
-    } else {
-      this.remove_class('hidden');
-    }
-    return this;
-  },
-  listen: function (event, callback) {
-    for (var i = 0, il = this.size(); i < il; i++) {
-      var object = this[i];
-      if (document.addEventListener) {
-        object.addEventListener(event, callback, false);
-      } else {
-        object.attachEvent('on' + event, callback);
-      }
-    }
-    return this;
-  },
-  add_class: function (class_name, force) {
-    for (var i = 0, il = this.size(); i < il; i++) {
-      var object = this[i];
-      if (object.className === '') {
-        object.className = class_name;
-      } else if (force || !in_array(class_name, object.className.split(' '))) {
-        object.className = object.className + ' ' + class_name;
-      }
-    }
-    return this;
-  },
-  remove_class: function (class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
-      var object = this[i];
-      var classes = object.className.split(' ');
-      var result = array_search(class_name, classes);
-      if (result !== false) {
-        classes.splice(result, 1);
-        object.className = classes.join(' ');
-      }
-    }
-    return this;
-  },
-  has_class: function(class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
-      var object = this[i];
-      var classes = object.className.split(' ');
-      if (array_search(class_name, classes)) {
-        return true;
-      }
-    }
-    return false;
-  },
-  toggle_class: function(class_name) {
-    for (var i = 0, il = this.size(); i < il; i++) {
-      var object = this[i];
-      var classes = object.className.split(' ');
-      var result = array_search(class_name, classes);
-      if (result !== false) {
-        classes.splice(result, 1);
-        object.className = classes.join(' ');
-      } else {
-        if (object.className === '') {
-          object.className = class_name;
-        } else {
-          object.className = object.className + ' ' + class_name;
-        }
-      }
-    }
-    return this;
-  },
-  disable : function () {
-    $(this).prop('disabled', true);
-    return this;
-  },
-  enable : function () {
-    $(this).prop('disabled', false);
-    return this;
-  },
-  raw: function (number) {
-    if (typeof number == 'undefined') {
-      number = 0;
-    }
-    return $(this).get(number);
-  },
-  nextElementSibling: function () {
-    var here = this[0];
-    if (here.nextElementSibling) {
-      return $(here.nextElementSibling);
-    }
-    do {
-      here = here.nextSibling;
-    } while (here.nodeType != 1);
-    return $(here);
-  },
-  previousElementSibling: function () {
-    var here = this[0];
-    if (here.previousElementSibling) {
-      return $(here.previousElementSibling);
-    }
-    do {
-      here = here.nextSibling;
-    } while (here.nodeType != 1);
-    return $(here);
-  },
-  updateTooltip: function(tooltip) {
-    if ($.fn.tooltipster) {
-      $(this).tooltipster('update', tooltip);
-    } else {
-      $(this).attr('title', tooltip);
-    }
-    return this;
-  },
-
-  // Disable unset form elements to allow search URLs cleanups
-  disableUnset: function() {
-    $('input, select', this).filter(function() {
-      return $(this).val() === "";
-    }).disable();
-    return this;
-  },
-
-  // Prevent double submission of forms
-  preventDoubleSubmission: function() {
-    $(this).submit(function(e) {
-      var $form = $(this);
-      if ($form.data('submitted') === true) {
-        // Previously submitted - don't submit again
-        e.preventDefault();
-      } else {
-        // Mark it so that the next submit can be ignored
-        $form.data('submitted', true);
-      }
-    });
-    // Keep chainability
-    return this;
-  }
-});
-
-if ($('meta[name=authkey]').raw()) {
-  var authkey = $('meta[name=authkey]').raw().content;
-  var userid = parseInt($('meta[name=userid]').raw().content);
-}

static/functions/torrent.js

@@ -130,7 +130,7 @@ function ArtistManagerSubmit() {
   $('#artists_selection').raw().value = Selection.join(',');
   if ((($('#artists_importance').raw().value != 1 && $('#artists_importance').raw().value != 4 && $('#artists_importance').raw().value != 6) || $('#manager_action').raw().value == 'delete') && MainSelectionCount == MainArtistCount) {
     if (!$('.error_message').raw()) {
-      error_message('All groups need to have at least one main artist, composer, or DJ.');
+      save_message('All groups need to have at least one main artist, composer, or DJ.', true);
     }
     $('.error_message').raw().scrollIntoView();
     return;
@@ -166,7 +166,7 @@ function Vote(amount, requestid) {
 
   ajax.get('requests.php?action=takevote&id=' + requestid + '&auth=' + authkey + '&amount=' + amount, function (response) {
       if (response == 'bankrupt') {
-        error_message("You do not have sufficient upload credit to add " + get_size(amount) + " to this request");
+        save_message("You do not have sufficient upload credit to add " + get_size(amount) + " to this request", true);
         return;
       } else if (response == 'dupesuccess') {
         //No increment

static/functions/user.js

@@ -127,7 +127,7 @@ function ParanoiaResetOn() {
   $('input[name=p_collages_l]').raw().checked = false;
 }
 
-addDOMLoadEvent(AlterParanoia);
+document.addEventListener("DOMContentLoaded", AlterParanoia);
 
 function ToggleWarningAdjust(selector) {
   if (selector.options[selector.selectedIndex].value == '---') {
@@ -139,7 +139,7 @@ function ToggleWarningAdjust(selector) {
   }
 }
 
-addDOMLoadEvent(ToggleIdenticons);
+document.addEventListener("DOMContentLoaded", ToggleIdenticons);
 function ToggleIdenticons() {
   var disableAvatars = $('#disableavatars');
   if (disableAvatars.size()) {

static/functions/user_notifications.js

@@ -14,7 +14,11 @@ $(document).ready(function() {
 });
 
 function getSkippedPage() {
-  var skip, url = new URL();
+  var skip
+  var url = {
+    path: window.location.pathname.split('/').reverse()[0].split('.')[0],
+    query: window.location.search.slice(1).split('&').reduce((a,b)=>Object.assign(a,{[b.split('=')[0]]:b.split('=')[1]}),{})
+  };
   switch(url.path) {
     case "inbox":
       if (url.query.length == 0 || (url.query.length == 1 && url.query.hasOwnProperty('sort'))) {