Don't abort page creation if magnet link fails to generate

classes/bencodedecode.class.php

@@ -18,7 +18,10 @@ class BencodeDecode extends Bencode {
    * @param bool $IsPath needs to be true if $Arg is a path
    * @return decoded data with a suitable structure
    */
-  function __construct($Arg = false, $IsPath = false) {
+  function __construct($Arg = false, $IsPath = false, $Strict = true) {
+    if (!$Strict) {
+      $this->ExitOnError = false;
+    }
     if ($Arg === false) {
       if (empty($this->Enc)) {
         return false;
@@ -169,13 +172,13 @@ class BencodeDecode extends Bencode {
       // The recursive nature of the class requires this to avoid duplicate error messages
       return false;
     }
-    if ($ErrMsg === false) {
-      printf("Malformed string. Invalid character at pos 0x%X: %s\n",
-          $this->Pos, str_replace(array("\r","\n"), array('',' '), htmlentities(substr($this->Data, $this->Pos, self::SnipLength))));
-    } else {
-      echo $ErrMsg;
-    }
     if ($this->ExitOnError) {
+      if ($ErrMsg === false) {
+        printf("Malformed string. Invalid character at pos 0x%X: %s\n",
+            $this->Pos, str_replace(array("\r","\n"), array('',' '), htmlentities(substr($this->Data, $this->Pos, self::SnipLength))));
+      } else {
+        echo $ErrMsg;
+      }
       exit();
     }
     $ErrorPos = $this->Pos;

sections/torrents/browse.php

@@ -596,7 +596,7 @@ $ShowGroups = !(!empty($LoggedUser['TorrentGrouping']) && $LoggedUser['TorrentGr
       if (!empty(G::$LoggedUser) && (G::$LoggedUser['ShowMagnets'] ?? false)) {
         if (!($TorrentFileName = $Cache->get_value('torrent_file_name_'.$TorrentID))) {
           $TorrentFile = file_get_contents(TORRENT_STORE.$TorrentID.'.torrent');
-          $Tor = new BencodeTorrent($TorrentFile);
+          $Tor = new BencodeTorrent($TorrentFile, false, false);
           $TorrentFileName = $Tor->Dec['info']['name'];
           $Cache->cache_value('torrent_file_name_'.$TorrentID, $TorrentFileName);
         }
@@ -674,7 +674,7 @@ $ShowGroups = !(!empty($LoggedUser['TorrentGrouping']) && $LoggedUser['TorrentGr
     if (!empty(G::$LoggedUser) && (G::$LoggedUser['ShowMagnets'] ?? false)) {
       if (!($TorrentFileName = $Cache->get_value('torrent_file_name_'.$TorrentID))) {
         $TorrentFile = file_get_contents(TORRENT_STORE.$TorrentID.'.torrent');
-        $Tor = new BencodeTorrent($TorrentFile);
+        $Tor = new BencodeTorrent($TorrentFile, false, false);
         $TorrentFileName = $Tor->Dec['info']['name'];
         $Cache->cache_value('torrent_file_name_'.$TorrentID, $TorrentFileName);
       }

sections/torrents/takedelete.php

@@ -26,9 +26,9 @@ $DB->query("
     LEFT JOIN artists_group AS ag ON ag.ArtistID = ta.ArtistID
     LEFT JOIN xbt_snatched AS x ON x.fid = t.ID
   WHERE t.ID = '$TorrentID'");
-list($UserID, $GroupID, $Size, $InfoHash, $Name, $ArtistName, $Time, $Snatches) = $DB->next_record(MYSQLI_NUM, false);
+list($UploaderID, $GroupID, $Size, $InfoHash, $Name, $ArtistName, $Time, $Snatches) = $DB->next_record(MYSQLI_NUM, false);
 
-if ($LoggedUser['ID'] != $UserID && !check_perms('torrents_delete')) {
+if ($LoggedUser['ID'] != $UploaderID && !check_perms('torrents_delete')) {
   error(403);
 }