Cease use of deprecated functions

classes/debug.class.php

@@ -654,7 +654,8 @@ class DEBUG {
   <table id="debug_loggedvars" class="debug_table hidden">
 <?
     foreach ($Vars as $ID => $Var) {
-      list($Key, $Data) = each($Var);
+      $Key = key($Var);
+      $Data = current($Var);
       $Size = count($Data['data']);
 ?>
     <tr>

classes/tags.class.php

@@ -183,7 +183,9 @@ class Tags {
       ORDER BY BadTag');
       $TagAliases = G::$DB->to_array(false, MYSQLI_ASSOC, false);
       // Unify tag aliases to be in_this_format as tags not in.this.format
-      array_walk_recursive($TagAliases, create_function('&$val', '$val = preg_replace("/\./","_", $val);'));
+      array_walk_recursive($TagAliases, function(&$val) {
+        $val = preg_replace("/\./","_", $val);
+      });
       // Clean up the array for smaller cache size
       foreach ($TagAliases as &$TagAlias) {
         foreach (array_keys($TagAlias) as $Key) {

classes/text.class.php

@@ -213,8 +213,9 @@ class Text {
     $Str = preg_replace('/(?<!'.$URLPrefix.')http(s)?:\/\//i', '$1[inlineurl]http$2://', $Str);
     $Str = preg_replace('/\[embed\]\[inlineurl\]/', '[embed]', $Str);
     // For anonym.to and archive.org links, remove any [inlineurl] in the middle of the link
-    $callback = create_function('$matches', 'return str_replace("[inlineurl]", "", $matches[0]);');
-    $Str = preg_replace_callback('/(?<=\[inlineurl\]|'.$URLPrefix.')(\S*\[inlineurl\]\S*)/m', $callback, $Str);
+    $Str = preg_replace_callback('/(?<=\[inlineurl\]|'.$URLPrefix.')(\S*\[inlineurl\]\S*)/m', function($matches) {
+      return str_replace("[inlineurl]", "", $matches[0]);
+    }, $Str);
 
     if (self::$TOC) {
       $Str = preg_replace('/(\={5})([^=].*)\1/i', '[headline=4]$2[/headline]', $Str);

classes/torrent_32bit.class.php

@@ -143,8 +143,7 @@ class BENCODE2 {
 class BENCODE_LIST extends BENCODE2 {
   function enc() {
     $Str = 'l';
-    reset($this->Val);
-    while (list($Key, $Value) = each($this->Val)) {
+    foreach ($this->Val as $Value) {
       $Str.=$this->encode($Value);
     }
     return $Str.'e';
@@ -177,8 +176,7 @@ class BENCODE_LIST extends BENCODE2 {
 class BENCODE_DICT extends BENCODE2 {
   function enc() {
     $Str = 'd';
-    reset($this->Val);
-    while (list($Key, $Value) = each($this->Val)) {
+    foreach ($this->Val as $Key => $Value) {
       $Str.=strlen($Key).':'.$Key.$this->encode($Value);
     }
     return $Str.'e';

sections/ajax/artist.php

@@ -42,7 +42,7 @@ if (!empty($_GET['revisionid'])) { // if they're viewing an old revision
   $RevisionID = false;
 }
 if ($Data) {
-  list($K, list($Name, $Image, $Body)) = each($Data);
+  list($Name, $Image, $Body) = current($Data);
 } else {
   if ($RevisionID) {
   /*

sections/artist/artist.php

@@ -23,7 +23,7 @@ if (!empty($_GET['revisionid'])) { // if they're viewing an old revision
 }
 
 if ($Data) {
-  list($K, list($Name, $Image, $Body)) = each($Data);
+  list($Name, $Image, $Body) = current($Data);
 } else {
   if ($RevisionID) {
     $sql = "
@@ -296,7 +296,8 @@ foreach ($TorrentList as $Group) {
 <?
     }
   } else {
-    list($TorrentID, $Torrent) = each($Torrents);
+    $TorrentID = key($Torrents);
+    $Torrent = current($Torrents);
     if (!$TorrentID) { continue; }
 
     $TorrentTags = new Tags($TagList, false);

sections/bookmarks/torrents.php

@@ -172,7 +172,8 @@ foreach ($GroupIDs as $GroupID) {
   } else {
     // Viewing a type that does not require grouping
 
-    list($TorrentID, $Torrent) = each($Torrents);
+    $TorrentID = key($Torrents);
+    $Torrent = current($Torrents);
 
     $DisplayName = Artists::display_artists(Artists::get_artist($GroupID));
 

sections/collages/torrent_collage.php

@@ -182,7 +182,8 @@ foreach ($GroupIDs as $GroupID) {
   } else {
     // Viewing a type that does not require grouping
 
-    list($TorrentID, $Torrent) = each($Torrents);
+    $TorrentID = key($Torrents);
+    $Torrent = current($Torrents);
 
     //$DisplayName = "<a href=\"torrents.php?id=$GroupID\" class=\"tooltip\" title=\"View torrent group\" dir=\"ltr\">$GroupName</a>";
 

sections/tools/managers/forum_list.php

@@ -133,7 +133,7 @@ while (list($ID, $CategoryID, $Sort, $Name, $Description, $MinClassRead, $MinCla
       <td>
         <select name="categoryid">
 <?  reset($ForumCats);
-  while (list($CurCat, $CatName) = each($ForumCats)) { ?>
+  foreach($ForumCats as $CurCat => $CatName) { ?>
           <option value="<?=$CurCat?>"<? if ($CurCat == $CategoryID) { echo ' selected="selected"'; } ?>><?=$CatName?></option>
 <?  } ?>
         </select>

sections/torrents/browse.php

@@ -630,7 +630,8 @@ $ShowGroups = !(!empty($LoggedUser['TorrentGrouping']) && $LoggedUser['TorrentGr
   } else {
     // Viewing a type that does not require grouping
 
-    list($TorrentID, $Data) = each($Torrents);
+    $TorrentID = key($Torrents);
+    $Data = current($Torrents);
 
     $Reported = false;
     $Reports = Torrents::get_reports($TorrentID);

sections/torrents/notify.php

@@ -17,7 +17,8 @@ $OrderBys = array(
 if (empty($_GET['order_by']) || !isset($OrderBys[$_GET['order_by']])) {
   $_GET['order_by'] = 'time';
 }
-list($OrderTbl, $OrderCol) = each($OrderBys[$_GET['order_by']]);
+$OrderTbl = key($OrderBys[$_GET['order_by']]);
+$OrderCol = current($OrderBys[$_GET['order_by']]);
 
 if (!empty($_GET['order_way']) && $_GET['order_way'] == 'asc') {
   $OrderWay = 'ASC';

sections/userhistory/subscribed_collages.php

@@ -164,7 +164,8 @@ if (!$NumResults) {
       } else {
         // Viewing a type that does not require grouping
 
-        list($TorrentID, $Torrent) = each($Torrents);
+        $TorrentID = key($Torrents);
+        $Torrent = current($Torrents);
 
         $DisplayName = "<a class=\"torrent_title\" href=\"torrents.php?id=$GroupID\" ";
         if (!isset($LoggedUser['CoverArt']) || $LoggedUser['CoverArt']) {