Rewrite screenshot adding in new torrents to use nicer SQL

classes/mysql.class.php

@@ -149,6 +149,7 @@ class DB_MYSQL {
   public $LinkID = false;
   protected $QueryID = false;
   protected $StatementID = false;
+  protected $PreparedQuery = false;
   protected $Record = [];
   protected $Row;
   protected $Errno = 0;
@@ -203,8 +204,7 @@ class DB_MYSQL {
     mysqli_set_charset($this->LinkID, "utf8");
   }
 
-  function query_p($Query, &...$BindVars) {
-    $QueryStartTime = microtime(true);
+  function prepare_query($Query, &...$BindVars) {
     $this->connect();
 
     $this->StatementID = mysqli_prepare($this->LinkID, $Query);
@@ -216,13 +216,17 @@ class DB_MYSQL {
       }
       mysqli_stmt_bind_param($this->StatementID, $Types, ...$BindVars);
     }
+    $this->PreparedQuery = $Query;
+    return $this->StatementID;
+  }
+
+  function exec_prepared_query() {
+    $QueryStartTime = microtime(true);
     mysqli_stmt_execute($this->StatementID);
     $this->QueryID = mysqli_stmt_get_result($this->StatementID);
     $QueryRunTime = (microtime(true) - $QueryStartTime) * 1000;
-    $this->Queries[] = [$Query, $QueryRunTime, null];
+    $this->Queries[] = [$this->PreppedQuery, $QueryRunTime, null];
     $this->Time += $QueryRunTime;
-
-    return $this->StatementID;
   }
 
   function query($Query, &...$BindVars) {
@@ -291,11 +295,6 @@ class DB_MYSQL {
     return $this->QueryID;
   }
 
-  function reexec_query() {
-    mysqli_stmt_execute($this->StatementID);
-    $this->QueryID = mysqli_stmt_get_result($this->StatementID);
-  }
-
   function query_unb($Query) {
     $this->connect();
     mysqli_real_query($this->LinkID, $Query);

sections/upload/upload_handle.php

@@ -395,18 +395,23 @@ if (!isset($GroupID) || !$GroupID) {
   $Cache->increment('stats_group_count');
 
   // Add screenshots
-  $Screenshots = array_slice(array_filter(array_map("db_string", array_map("trim", array_unique(explode("\n", $T['Screenshots'])))), function ($s) { return preg_match('/^'.IMAGE_REGEX.'$/i', $s); }), 0, 10);
-
-  $values = [];
-  foreach ($Screenshots as $s) {
-    $values[] = "(" . $GroupID . ", " . $LoggedUser['ID'] . ", NOW(), '" . $s . "')";
-  }
-
-  if (!empty($values)) {
-    $DB->query("
+  $Screenshots = explode("\n", $T['Screenshots']);
+  $Screenshots = array_map("trim", $Screenshots);
+  $Screenshots = array_filter($Screenshots, function($s) {
+    return preg_match('/^'.IMAGE_REGEX.'$/i', $s);
+  });
+  $Screenshots = array_unique($Screenshots);
+  $Screenshots = array_slice($Screenshots, 0, 10);
+
+  if (!empty($Screenshots)) {
+    $Screenshot = '';
+    $DB->prepare_query("
       INSERT INTO torrents_screenshots
         (GroupID, UserID, Time, Image)
-      VALUES " . implode(", ", $values));
+      VALUES (?, ?, NOW(), ?)", $GroupID, $LoggedUser['ID'], $Screenshot);
+    foreach ($Screenshots as $Screenshot) {
+      $DB->exec_prepared_query();
+    }
   }
 
 } else {