Some null coalescing

classes/time.class.php

@@ -1,19 +1,19 @@
 <?
 if (!extension_loaded('date')) {
-	error('Date extension not loaded.');
+  error('Date extension not loaded.');
 }
 
 function time_ago($TimeStamp) {
-	if (!is_number($TimeStamp)) { // Assume that $TimeStamp is SQL timestamp
-		if ($TimeStamp == '0000-00-00 00:00:00') {
-			return false;
-		}
-		$TimeStamp = strtotime($TimeStamp);
-	}
-	if ($TimeStamp == 0) {
-		return false;
-	}
-	return time() - $TimeStamp;
+  if (!is_number($TimeStamp)) { // Assume that $TimeStamp is SQL timestamp
+    if ($TimeStamp == '0000-00-00 00:00:00') {
+      return false;
+    }
+    $TimeStamp = strtotime($TimeStamp);
+  }
+  if ($TimeStamp == 0) {
+    return false;
+  }
+  return time() - $TimeStamp;
 }
 
 /*
@@ -21,185 +21,184 @@ function time_ago($TimeStamp) {
  * difference in text (e.g. "16 hours and 28 minutes", "1 day, 18 hours").
  */
 function time_diff($TimeStamp, $Levels = 2, $Span = true, $Lowercase = false) {
-	if (!is_number($TimeStamp)) { // Assume that $TimeStamp is SQL timestamp
-		if ($TimeStamp == '0000-00-00 00:00:00') {
-			return 'Never';
-		}
-		$TimeStamp = strtotime($TimeStamp);
-	}
-	if ($TimeStamp == 0) {
-		return 'Never';
-	}
-	$Time = time() - $TimeStamp;
-
-	// If the time is negative, then it expires in the future.
-	if ($Time < 0) {
-		$Time = -$Time;
-		$HideAgo = true;
-	}
-
-	$Years = floor($Time / 31556926); // seconds in one year
-	$Remain = $Time - $Years * 31556926;
-
-	$Months = floor($Remain / 2629744); // seconds in one month
-	$Remain = $Remain - $Months * 2629744;
-
-	$Weeks = floor($Remain / 604800); // seconds in one week
-	$Remain = $Remain - $Weeks * 604800;
-
-	$Days = floor($Remain / 86400); // seconds in one day
-	$Remain = $Remain - $Days * 86400;
-
-	$Hours=floor($Remain / 3600); // seconds in one hour
-	$Remain = $Remain - $Hours * 3600;
-
-	$Minutes = floor($Remain / 60); // seconds in one minute
-	$Remain = $Remain - $Minutes * 60;
-
-	$Seconds = $Remain;
-
-	$Return = '';
-
-	if ($Years > 0 && $Levels > 0) {
-		if ($Years > 1) {
-			$Return .= "$Years years";
-		} else {
-			$Return .= "$Years year";
-		}
-		$Levels--;
-	}
-
-	if ($Months > 0 && $Levels > 0) {
-		if ($Return != '') {
-			$Return .= ', ';
-		}
-		if ($Months > 1) {
-			$Return .= "$Months months";
-		} else {
-			$Return .= "$Months month";
-		}
-		$Levels--;
-	}
-
-	if ($Weeks > 0 && $Levels > 0) {
-		if ($Return != '') {
-			$Return .= ', ';
-		}
-		if ($Weeks > 1) {
-			$Return .= "$Weeks weeks";
-		} else {
-			$Return .= "$Weeks week";
-		}
-		$Levels--;
-	}
-
-	if ($Days > 0 && $Levels > 0) {
-		if ($Return != '') {
-			$Return .= ', ';
-		}
-		if ($Days > 1) {
-			$Return .= "$Days days";
-		} else {
-			$Return .= "$Days day";
-		}
-		$Levels--;
-	}
-
-	if ($Hours > 0 && $Levels > 0) {
-		if ($Return != '') {
-			$Return .= ', ';
-		}
-		if ($Hours > 1) {
-			$Return .= "$Hours hours";
-		} else {
-			$Return .= "$Hours hour";
-		}
-		$Levels--;
-	}
-
-	if ($Minutes > 0 && $Levels > 0) {
-		if ($Return != '') {
-			$Return .= ' and ';
-		}
-		if ($Minutes > 1) {
-			$Return .= "$Minutes mins";
-		} else {
-			$Return .= "$Minutes min";
-		}
-		$Levels--;
-	}
-
-	if ($Return == '') {
-		$Return = 'Just now';
-	} elseif (!isset($HideAgo)) {
-		$Return .= ' ago';
-	}
-
-	if ($Lowercase) {
-		$Return = strtolower($Return);
-	}
-
-	if ($Span) {
-		return '<span class="time tooltip" title="'.date('M d Y, H:i', $TimeStamp).'">'.$Return.'</span>';
-	} else {
-		return $Return;
-	}
+  if (!is_number($TimeStamp)) { // Assume that $TimeStamp is SQL timestamp
+    if ($TimeStamp == '0000-00-00 00:00:00') {
+      return 'Never';
+    }
+    $TimeStamp = strtotime($TimeStamp);
+  }
+  if ($TimeStamp == 0) {
+    return 'Never';
+  }
+  $Time = time() - $TimeStamp;
+
+  // If the time is negative, then it expires in the future.
+  if ($Time < 0) {
+    $Time = -$Time;
+    $HideAgo = true;
+  }
+
+  $Years = floor($Time / 31556926); // seconds in one year
+  $Remain = $Time - $Years * 31556926;
+
+  $Months = floor($Remain / 2629744); // seconds in one month
+  $Remain = $Remain - $Months * 2629744;
+
+  $Weeks = floor($Remain / 604800); // seconds in one week
+  $Remain = $Remain - $Weeks * 604800;
+
+  $Days = floor($Remain / 86400); // seconds in one day
+  $Remain = $Remain - $Days * 86400;
+
+  $Hours=floor($Remain / 3600); // seconds in one hour
+  $Remain = $Remain - $Hours * 3600;
+
+  $Minutes = floor($Remain / 60); // seconds in one minute
+  $Remain = $Remain - $Minutes * 60;
+
+  $Seconds = $Remain;
+
+  $Return = '';
+
+  if ($Years > 0 && $Levels > 0) {
+    if ($Years > 1) {
+      $Return .= "$Years years";
+    } else {
+      $Return .= "$Years year";
+    }
+    $Levels--;
+  }
+
+  if ($Months > 0 && $Levels > 0) {
+    if ($Return != '') {
+      $Return .= ', ';
+    }
+    if ($Months > 1) {
+      $Return .= "$Months months";
+    } else {
+      $Return .= "$Months month";
+    }
+    $Levels--;
+  }
+
+  if ($Weeks > 0 && $Levels > 0) {
+    if ($Return != '') {
+      $Return .= ', ';
+    }
+    if ($Weeks > 1) {
+      $Return .= "$Weeks weeks";
+    } else {
+      $Return .= "$Weeks week";
+    }
+    $Levels--;
+  }
+
+  if ($Days > 0 && $Levels > 0) {
+    if ($Return != '') {
+      $Return .= ', ';
+    }
+    if ($Days > 1) {
+      $Return .= "$Days days";
+    } else {
+      $Return .= "$Days day";
+    }
+    $Levels--;
+  }
+
+  if ($Hours > 0 && $Levels > 0) {
+    if ($Return != '') {
+      $Return .= ', ';
+    }
+    if ($Hours > 1) {
+      $Return .= "$Hours hours";
+    } else {
+      $Return .= "$Hours hour";
+    }
+    $Levels--;
+  }
+
+  if ($Minutes > 0 && $Levels > 0) {
+    if ($Return != '') {
+      $Return .= ' and ';
+    }
+    if ($Minutes > 1) {
+      $Return .= "$Minutes mins";
+    } else {
+      $Return .= "$Minutes min";
+    }
+    $Levels--;
+  }
+
+  if ($Return == '') {
+    $Return = 'Just now';
+  } elseif (!isset($HideAgo)) {
+    $Return .= ' ago';
+  }
+
+  if ($Lowercase) {
+    $Return = strtolower($Return);
+  }
+
+  if ($Span) {
+    return '<span class="time tooltip" title="'.date('M d Y, H:i', $TimeStamp).'">'.$Return.'</span>';
+  } else {
+    return $Return;
+  }
 }
 
 /* SQL utility functions */
 
 function time_plus($Offset) {
-	return date('Y-m-d H:i:s', time() + $Offset);
+  return date('Y-m-d H:i:s', time() + $Offset);
 }
 
 function time_minus($Offset, $Fuzzy = false) {
-	if ($Fuzzy) {
-		return date('Y-m-d 00:00:00', time() - $Offset);
-	} else {
-		return date('Y-m-d H:i:s', time() - $Offset);
-	}
+  if ($Fuzzy) {
+    return date('Y-m-d 00:00:00', time() - $Offset);
+  } else {
+    return date('Y-m-d H:i:s', time() - $Offset);
+  }
 }
 
-function sqltime($timestamp = false) {
-	if ($timestamp === false) {
-		$timestamp = time();
-	}
-	return date('Y-m-d H:i:s', $timestamp);
+// This is never used anywhere with $timestamp set
+// TODO: Why don't we just use NOW() in the sql queries?
+function sqltime($timestamp = NULL) {
+  return date('Y-m-d H:i:s', ($timestamp ?? time()));
 }
 
 function validDate($DateString) {
-	$DateTime = explode(' ', $DateString);
-	if (count($DateTime) != 2) {
-		return false;
-	}
-	list($Date, $Time) = $DateTime;
-	$SplitTime = explode(':', $Time);
-	if (count($SplitTime) != 3) {
-		return false;
-	}
-	list($H, $M, $S) = $SplitTime;
-	if ($H != 0 && !(is_number($H) && $H < 24 && $H >= 0)) { return false; }
-	if ($M != 0 && !(is_number($M) && $M < 60 && $M >= 0)) { return false; }
-	if ($S != 0 && !(is_number($S) && $S < 60 && $S >= 0)) { return false; }
-	$SplitDate = explode('-', $Date);
-	if (count($SplitDate) != 3) {
-		return false;
-	}
-	list($Y, $M, $D) = $SplitDate;
-	return checkDate($M, $D, $Y);
+  $DateTime = explode(' ', $DateString);
+  if (count($DateTime) != 2) {
+    return false;
+  }
+  list($Date, $Time) = $DateTime;
+  $SplitTime = explode(':', $Time);
+  if (count($SplitTime) != 3) {
+    return false;
+  }
+  list($H, $M, $S) = $SplitTime;
+  if ($H != 0 && !(is_number($H) && $H < 24 && $H >= 0)) { return false; }
+  if ($M != 0 && !(is_number($M) && $M < 60 && $M >= 0)) { return false; }
+  if ($S != 0 && !(is_number($S) && $S < 60 && $S >= 0)) { return false; }
+  $SplitDate = explode('-', $Date);
+  if (count($SplitDate) != 3) {
+    return false;
+  }
+  list($Y, $M, $D) = $SplitDate;
+  return checkDate($M, $D, $Y);
 }
 
 function is_valid_date($Date) {
-	return is_valid_datetime($Date, 'Y-m-d');
+  return is_valid_datetime($Date, 'Y-m-d');
 }
 
 function is_valid_time($Time) {
-	return is_valid_datetime($Time, 'H:i');
+  return is_valid_datetime($Time, 'H:i');
 }
 
 function is_valid_datetime($DateTime, $Format = 'Y-m-d H:i') {
-	$FormattedDateTime = DateTime::createFromFormat($Format, $DateTime);
-	return $FormattedDateTime && $FormattedDateTime->format($Format) == $DateTime;
+  $FormattedDateTime = DateTime::createFromFormat($Format, $DateTime);
+  return $FormattedDateTime && $FormattedDateTime->format($Format) == $DateTime;
 }
 
 ?>

sections/error/index.php

@@ -1,65 +1,65 @@
 <?
 
 function notify ($Channel, $Message) {
-	global $LoggedUser;
-	send_irc("PRIVMSG ".$Channel." :".$Message." error by ".(!empty($LoggedUser['ID']) ? site_url()."user.php?id=".$LoggedUser['ID'] ." (".$LoggedUser['Username'].")" : $_SERVER['REMOTE_ADDR']." (".Tools::geoip($_SERVER['REMOTE_ADDR']).")")." accessing https://".SITE_DOMAIN."".$_SERVER['REQUEST_URI'].(!empty($_SERVER['HTTP_REFERER'])? " from ".$_SERVER['HTTP_REFERER'] : ''));
+  global $LoggedUser;
+  send_irc("PRIVMSG ".$Channel." :".$Message." error by ".(!empty($LoggedUser['ID']) ? site_url()."user.php?id=".$LoggedUser['ID'] ." (".$LoggedUser['Username'].")" : $_SERVER['REMOTE_ADDR']." (".Tools::geoip($_SERVER['REMOTE_ADDR']).")")." accessing https://".SITE_DOMAIN."".$_SERVER['REQUEST_URI'].(!empty($_SERVER['HTTP_REFERER'])? " from ".$_SERVER['HTTP_REFERER'] : ''));
 }
 
 $Errors = array('403','404','413','504');
 
 if (!empty($_GET['e']) && in_array($_GET['e'],$Errors)) {
-	// Web server error i.e. http://sitename/madeupdocument.php
-	include($_GET['e'].'.php');
+  // Web server error i.e. http://sitename/madeupdocument.php
+  include($_GET['e'].'.php');
 } else {
-	// Gazelle error (Comes from the error() function)
-	switch (isset($Error) ? $Error : NAN) {
+  // Gazelle error (Comes from the error() function)
+  switch ($Error ?? NAN) {
 
-		case '403':
-			$Title = "Error 403";
-			$Description = "You just tried to go to a page that you don't have enough permission to view.";
-			notify(STATUS_CHAN,'403');
-			break;
-		case '404':
-			$Title = "Error 404";
-			$Description = "You just tried to go to a page that doesn't exist.";
-			break;
-		case '0':
-			$Title = "Invalid Input";
-			$Description = "Something was wrong with the input provided with your request, and the server is refusing to fulfill it.";
-			notify(STATUS_CHAN,'PHP-0');
-			break;
-		case '-1':
-			$Title = "Invalid request";
-			$Description = "Something was wrong with your request, and the server is refusing to fulfill it.";
-			break;
-		default:
-			if (!empty($Error)) {
-				$Title = 'Error';
-				$Description = $Error;
-			} else {
-				$Title = "Unexpected Error";
-				$Description = "You have encountered an unexpected error.";
-			}
-	}
+    case '403':
+      $Title = "Error 403";
+      $Description = "You just tried to go to a page that you don't have enough permission to view.";
+      notify(STATUS_CHAN,'403');
+      break;
+    case '404':
+      $Title = "Error 404";
+      $Description = "You just tried to go to a page that doesn't exist.";
+      break;
+    case '0':
+      $Title = "Invalid Input";
+      $Description = "Something was wrong with the input provided with your request, and the server is refusing to fulfill it.";
+      notify(STATUS_CHAN,'PHP-0');
+      break;
+    case '-1':
+      $Title = "Invalid request";
+      $Description = "Something was wrong with your request, and the server is refusing to fulfill it.";
+      break;
+    default:
+      if (!empty($Error)) {
+        $Title = 'Error';
+        $Description = $Error;
+      } else {
+        $Title = "Unexpected Error";
+        $Description = "You have encountered an unexpected error.";
+      }
+  }
 
-	if (isset($Log)) {
-		$Description .= ' <a href="log.php?search='.$Log.'">Search Log</a>';
-	}
+  if (isset($Log)) {
+    $Description .= ' <a href="log.php?search='.$Log.'">Search Log</a>';
+  }
 
-	if (empty($NoHTML) && (!isset($Error) || $Error != -1)) {
-		View::show_header($Title);
+  if (empty($NoHTML) && (!isset($Error) || $Error != -1)) {
+    View::show_header($Title);
 ?>
-	<div class="thin">
-		<div class="header">
-			<h2><?=$Title?></h2>
-		</div>
-		<div class="box pad">
-			<p><?=$Description?></p>
-		</div>
-	</div>
+  <div class="thin">
+    <div class="header">
+      <h2><?=$Title?></h2>
+    </div>
+    <div class="box pad">
+      <p><?=$Description?></p>
+    </div>
+  </div>
 <?
-		View::show_footer();
-	} else {
-		echo $Description;
-	}
+    View::show_footer();
+  } else {
+    echo $Description;
+  }
 }

sections/userhistory/email_history2.php

@@ -12,74 +12,76 @@ user.
 
 $UserID = $_GET['userid'];
 if (!is_number($UserID)) {
-	error(404);
+  error(404);
 }
 
 $DB->query("
-	SELECT
-		ui.JoinDate,
-		p.Level AS Class
-	FROM users_main AS um
-		JOIN users_info AS ui ON um.ID = ui.UserID
-		JOIN permissions AS p ON p.ID = um.PermissionID
-	WHERE um.ID = $UserID");
+  SELECT
+    ui.JoinDate,
+    p.Level AS Class
+  FROM users_main AS um
+    JOIN users_info AS ui ON um.ID = ui.UserID
+    JOIN permissions AS p ON p.ID = um.PermissionID
+  WHERE um.ID = $UserID");
 list($Joined, $Class) = $DB->next_record();
 
 if (!check_perms('users_view_email', $Class)) {
-	error(403);
+  error(403);
 }
 
-$UsersOnly = $_GET['usersonly'];
+// TODO: Is this even used?
+$UsersOnly = $_GET['usersonly'] ?? false;
 
 $DB->query("
-	SELECT Username
-	FROM users_main
-	WHERE ID = $UserID");
+  SELECT Username
+  FROM users_main
+  WHERE ID = $UserID");
 list($Username) = $DB->next_record();
 View::show_header("Email history for $Username");
 
 // Get current email (and matches)
 $DB->query("
-	SELECT
-		m.Email,
-		'".sqltime()."' AS Time,
-		m.IP,
-		GROUP_CONCAT(h.UserID SEPARATOR '|') AS UserIDs,
-		GROUP_CONCAT(h.Time SEPARATOR '|') AS UserSetTimes,
-		GROUP_CONCAT(h.IP SEPARATOR '|') AS UserIPs,
-		GROUP_CONCAT(m2.Username SEPARATOR '|') AS Usernames,
-		GROUP_CONCAT(m2.Enabled SEPARATOR '|') AS UsersEnabled,
-		GROUP_CONCAT(i.Donor SEPARATOR '|') AS UsersDonor,
-		GROUP_CONCAT(i.Warned SEPARATOR '|') AS UsersWarned
-	FROM users_main AS m
-		LEFT JOIN users_history_emails AS h ON h.Email = m.Email
-				AND h.UserID != m.ID
-		LEFT JOIN users_main AS m2 ON m2.ID = h.UserID
-		LEFT JOIN users_info AS i ON i.UserID = h.UserID
-	WHERE m.ID = '$UserID'"
+  SELECT
+    m.Email,
+    '".sqltime()."' AS Time,
+    m.IP,
+    GROUP_CONCAT(h.UserID SEPARATOR '|') AS UserIDs,
+    GROUP_CONCAT(h.Time SEPARATOR '|') AS UserSetTimes,
+    GROUP_CONCAT(h.IP SEPARATOR '|') AS UserIPs,
+    GROUP_CONCAT(m2.Username SEPARATOR '|') AS Usernames,
+    GROUP_CONCAT(m2.Enabled SEPARATOR '|') AS UsersEnabled,
+    GROUP_CONCAT(i.Donor SEPARATOR '|') AS UsersDonor,
+    GROUP_CONCAT(i.Warned SEPARATOR '|') AS UsersWarned
+  FROM users_main AS m
+    LEFT JOIN users_history_emails AS h ON h.Email = m.Email
+        AND h.UserID != m.ID
+    LEFT JOIN users_main AS m2 ON m2.ID = h.UserID
+    LEFT JOIN users_info AS i ON i.UserID = h.UserID
+  WHERE m.ID = '$UserID'"
 );
-$CurrentEmail = array_shift($DB->to_array());
+//$CurrentEmail = array_shift($DB->to_array());
+$CurrentEmail = ($DB->to_array())[0]; // Only variables should be passed by reference
 
 // Get historic emails (and matches)
 $DB->query("
-	SELECT
-		h2.Email,
-		h2.Time,
-		h2.IP,
-		h3.UserID AS UserIDs,
-		h3.Time AS UserSetTimes,
-		h3.IP AS UserIPs,
-		m3.Username AS Usernames,
-		m3.Enabled AS UsersEnabled,
-		i2.Donor AS UsersDonor,
-		i2.Warned AS UsersWarned
-	FROM users_history_emails AS h2
-		LEFT JOIN users_history_emails AS h3 ON h3.Email = h2.Email
-				AND h3.UserID != h2.UserID
-		LEFT JOIN users_main AS m3 ON m3.ID = h3.UserID
-		LEFT JOIN users_info AS i2 ON i2.UserID = h3.UserID
-	WHERE h2.UserID = '$UserID'
-	ORDER BY Time DESC"
+  SELECT
+    h2.Email,
+    h2.Time,
+    h2.IP,
+    h3.UserID AS UserIDs,
+    h3.Time AS UserSetTimes,
+    h3.IP AS UserIPs,
+    m3.Username AS Usernames,
+    m3.Enabled AS UsersEnabled,
+    i2.Donor AS UsersDonor,
+    i2.Warned AS UsersWarned
+  FROM users_history_emails AS h2
+    LEFT JOIN users_history_emails AS h3 ON h3.Email = h2.Email
+        AND h3.UserID != h2.UserID
+    LEFT JOIN users_main AS m3 ON m3.ID = h3.UserID
+    LEFT JOIN users_info AS i2 ON i2.UserID = h3.UserID
+  WHERE h2.UserID = '$UserID'
+  ORDER BY Time DESC"
 );
 $History = $DB->to_array();
 
@@ -91,292 +93,286 @@ $Current['IP'] = $History[(count($History) - 1)]['IP'];
 
 // Matches for current email
 if ($CurrentEmail['Usernames'] != '') {
-	$UserIDs = explode('|', $CurrentEmail['UserIDs']);
-	$Usernames = explode('|', $CurrentEmail['Usernames']);
-	$UsersEnabled = explode('|', $CurrentEmail['UsersEnabled']);
-	$UsersDonor = explode('|', $CurrentEmail['UsersDonor']);
-	$UsersWarned = explode('|', $CurrentEmail['UsersWarned']);
-	$UserSetTimes = explode('|', $CurrentEmail['UserSetTimes']);
-	$UserIPs = explode('|', $CurrentEmail['UserIPs']);
+  $UserIDs = explode('|', $CurrentEmail['UserIDs']);
+  $Usernames = explode('|', $CurrentEmail['Usernames']);
+  $UsersEnabled = explode('|', $CurrentEmail['UsersEnabled']);
+  $UsersDonor = explode('|', $CurrentEmail['UsersDonor']);
+  $UsersWarned = explode('|', $CurrentEmail['UsersWarned']);
+  $UserSetTimes = explode('|', $CurrentEmail['UserSetTimes']);
+  $UserIPs = explode('|', $CurrentEmail['UserIPs']);
 
-	foreach ($UserIDs as $Key => $Val) {
-		$CurrentMatches[$Key]['Username'] = '  » '.Users::format_username($Val, true, true, true);
-		$CurrentMatches[$Key]['IP'] = $UserIPs[$Key];
-		$CurrentMatches[$Key]['EndTime'] = $UserSetTimes[$Key];
-	}
+  foreach ($UserIDs as $Key => $Val) {
+    $CurrentMatches[$Key]['Username'] = '  » '.Users::format_username($Val, true, true, true);
+    $CurrentMatches[$Key]['IP'] = $UserIPs[$Key];
+    $CurrentMatches[$Key]['EndTime'] = $UserSetTimes[$Key];
+  }
 }
 
 // Email history records
 if (count($History) === 1) {
-	$Invite['Email'] = $History[0]['Email'];
-	$Invite['EndTime'] = $Joined;
-	$Invite['AccountAge'] = date(time() + time() - strtotime($Joined)); // Same as EndTime but without ' ago'
-	$Invite['IP'] = $History[0]['IP'];
-	if ($Current['StartTime'] == '0000-00-00 00:00:00') {
-		$Current['StartTime'] = $Joined;
-	}
+  $Invite['Email'] = $History[0]['Email'];
+  $Invite['EndTime'] = $Joined;
+  $Invite['AccountAge'] = date(time() + time() - strtotime($Joined)); // Same as EndTime but without ' ago'
+  $Invite['IP'] = $History[0]['IP'];
+  if ($Current['StartTime'] == '0000-00-00 00:00:00') {
+    $Current['StartTime'] = $Joined;
+  }
 } else {
-	foreach ($History as $Key => $Val) {
-		if ($History[$Key + 1]['Time'] == '0000-00-00 00:00:00' && $Val['Time'] != '0000-00-00 00:00:00') {
-			// Invited email
-			$Invite['Email'] = $Val['Email'];
-			$Invite['EndTime'] = $Joined;
-			$Invite['AccountAge'] = date(time() + time() - strtotime($Joined)); // Same as EndTime but without ' ago'
-			$Invite['IP'] = $Val['IP'];
+  foreach ($History as $Key => $Val) {
+    if (isset($History[$Key + 1]) && $History[$Key + 1]['Time'] == '0000-00-00 00:00:00' && $Val['Time'] != '0000-00-00 00:00:00') {
+      // Invited email
+      $Invite['Email'] = $Val['Email'];
+      $Invite['EndTime'] = $Joined;
+      $Invite['AccountAge'] = date(time() + time() - strtotime($Joined)); // Same as EndTime but without ' ago'
+      $Invite['IP'] = $Val['IP'];
 
-		} elseif ($History[$Key - 1]['Email'] != $Val['Email'] && $Val['Time'] != '0000-00-00 00:00:00') {
-			// Old email
-			$i = 1;
-			while ($Val['Email'] == $History[$Key + $i]['Email']) {
-				$i++;
-			}
-			$Old[$Key]['StartTime'] = (isset($History[$Key + $i]) && $History[$Key + $i]['Time'] != '0000-00-00 00:00:00') ? $History[$Key + $i]['Time'] : $Joined;
-			$Old[$Key]['EndTime'] = $Val['Time'];
-			$Old[$Key]['IP'] = $Val['IP'];
-			$Old[$Key]['ElapsedTime'] = date(time() + strtotime($Old[$Key]['EndTime']) - strtotime($Old[$Key]['StartTime']));
-			$Old[$Key]['Email'] = $Val['Email'];
+    } elseif (isset($History[$Key - 1]) && $History[$Key - 1]['Email'] != $Val['Email'] && $Val['Time'] != '0000-00-00 00:00:00') {
+      // Old email
+      $i = 1;
+      while ($Val['Email'] == $History[$Key + $i]['Email']) {
+        $i++;
+      }
+      $Old[$Key]['StartTime'] = (isset($History[$Key + $i]) && $History[$Key + $i]['Time'] != '0000-00-00 00:00:00') ? $History[$Key + $i]['Time'] : $Joined;
+      $Old[$Key]['EndTime'] = $Val['Time'];
+      $Old[$Key]['IP'] = $Val['IP'];
+      $Old[$Key]['ElapsedTime'] = date(time() + strtotime($Old[$Key]['EndTime']) - strtotime($Old[$Key]['StartTime']));
+      $Old[$Key]['Email'] = $Val['Email'];
+    }
 
-		} else {
-			// Shouldn't have to be here but I'll leave it anyway
-			$Other[$Key]['StartTime'] = (isset($History[$Key + $i])) ? $History[$Key + $i]['Time'] : $Joined;
-			$Other[$Key]['EndTime'] = $Val['Time'];
-			$Other[$Key]['IP'] = $Val['IP'];
-			$Other[$Key]['ElapsedTime'] = date(time() + strtotime($Other[$Key]['EndTime']) - strtotime($Other[$Key]['StartTime']));
-			$Other[$Key]['Email'] = $Val['Email'];
-		}
-
-		if ($Val['Usernames'] != '') {
-			// Match with old email
-			$OldMatches[$Key]['Email'] = $Val['Email'];
-			$OldMatches[$Key]['Username'] = '  » '.Users::format_username($Val['UserIDs'], true, true, true);
-			$OldMatches[$Key]['EndTime'] = $Val['UserSetTimes'];
-			$OldMatches[$Key]['IP'] = $Val['UserIPs'];
-		}
-	}
+    if ($Val['Usernames'] != '') {
+      // Match with old email
+      $OldMatches[$Key]['Email'] = $Val['Email'];
+      $OldMatches[$Key]['Username'] = '  » '.Users::format_username($Val['UserIDs'], true, true, true);
+      $OldMatches[$Key]['EndTime'] = $Val['UserSetTimes'];
+      $OldMatches[$Key]['IP'] = $Val['UserIPs'];
+    }
+  }
 }
 
 // Clean up arrays
-if ($Old) {
-	$Old = array_reverse(array_reverse($Old));
-	$LastOld = count($Old) - 1;
-	if ($Old[$LastOld]['StartTime'] != $Invite['EndTime']) {
-		// Make sure the timeline is intact (invite email was used as email for the account in the beginning)
-		$Old[$LastOld + 1]['Email'] = $Invite['Email'];
-		$Old[$LastOld + 1]['StartTime'] = $Invite['EndTime'];
-		$Old[$LastOld + 1]['EndTime'] = $Old[$LastOld]['StartTime'];
-		$Old[$LastOld + 1]['ElapsedTime'] = date(time() + strtotime($Old[$LastOld + 1]['EndTime'] ) - strtotime($Old[$LastOld + 1]['StartTime']));
-		$Old[$LastOld + 1]['IP'] = $Invite['IP'];
-	}
+if ($Old ?? false) {
+  $Old = array_reverse(array_reverse($Old));
+  $LastOld = count($Old) - 1;
+  if ($Old[$LastOld]['StartTime'] != $Invite['EndTime']) {
+    // Make sure the timeline is intact (invite email was used as email for the account in the beginning)
+    $Old[$LastOld + 1]['Email'] = $Invite['Email'];
+    $Old[$LastOld + 1]['StartTime'] = $Invite['EndTime'];
+    $Old[$LastOld + 1]['EndTime'] = $Old[$LastOld]['StartTime'];
+    $Old[$LastOld + 1]['ElapsedTime'] = date(time() + strtotime($Old[$LastOld + 1]['EndTime'] ) - strtotime($Old[$LastOld + 1]['StartTime']));
+    $Old[$LastOld + 1]['IP'] = $Invite['IP'];
+  }
 }
 
 // Start page with current email
 ?>
 <div class="thin">
-	<div class="header">
-		<h2>Email history for <a href="user.php?id=<?=$UserID ?>"><?=$Username ?></a></h2>
-		<div class="linkbox center">
-			<a href="userhistory.php?action=email&amp;userid=<?=$UserID?>" class="brackets">Old email history</a>
-		</div>
-	</div>
-	<br />
-	<table width="100%">
-		<tr class="colhead">
-			<td>Current email</td>
-			<td>Start</td>
-			<td>End</td>
-			<td>Current IP <a href="userhistory.php?action=ips&amp;userid=<?=$UserID ?>" class="brackets">H</a></td>
-			<td>Set from IP</td>
-		</tr>
+  <div class="header">
+    <h2>Email history for <a href="user.php?id=<?=$UserID ?>"><?=$Username ?></a></h2>
+    <div class="linkbox center">
+      <a href="userhistory.php?action=email&amp;userid=<?=$UserID?>" class="brackets">Old email history</a>
+    </div>
+  </div>
+  <br />
+  <table width="100%">
+    <tr class="colhead">
+      <td>Current email</td>
+      <td>Start</td>
+      <td>End</td>
+      <td>Current IP <a href="userhistory.php?action=ips&amp;userid=<?=$UserID ?>" class="brackets">H</a></td>
+      <td>Set from IP</td>
+    </tr>
 <? 
 $Current['Email'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Current['Email']) : '[Encrypted]';
 $Current['CurrentIP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Current['CurrentIP']) : '[Encrypted]';
 $Current['IP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Current['IP']) : '[Encrypted]';
 ?>
-		<tr class="row">
-			<td><?=display_str($Current['Email'])?></td>
-			<td><?=time_diff($Current['StartTime'])?></td>
-			<td></td>
-			<td>
-				<?=display_str($Current['CurrentIP'])?>
-				(<?=Tools::get_country_code_by_ajax($Current['CurrentIP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Current['CurrentIP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Current['CurrentIP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Current['CurrentIP'])?>
-			</td>
-			<td>
-				<?=display_str($Current['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Current['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Current['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Current['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Current['IP'])?>
-			</td>
-		</tr>
+    <tr class="row">
+      <td><?=display_str($Current['Email'])?></td>
+      <td><?=time_diff($Current['StartTime'])?></td>
+      <td></td>
+      <td>
+        <?=display_str($Current['CurrentIP'])?>
+        (<?=Tools::get_country_code_by_ajax($Current['CurrentIP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Current['CurrentIP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Current['CurrentIP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Current['CurrentIP'])?>
+      </td>
+      <td>
+        <?=display_str($Current['IP'])?>
+        (<?=Tools::get_country_code_by_ajax($Current['IP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Current['IP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Current['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Current['IP'])?>
+      </td>
+    </tr>
 <?
-if ($CurrentMatches) {
-	// Match on the current email
-	foreach ($CurrentMatches as $Match) {
+if ($CurrentMatches ?? false) {
+  // Match on the current email
+  foreach ($CurrentMatches as $Match) {
     $Match['IP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Match['IP']) : '[Encrypted]';
 ?>
-		<tr class="row">
-			<td><?=$Match['Username']?></td>
-			<td></td>
-			<td><?=time_diff($Match['EndTime'])?></td>
-			<td></td>
-			<td>
-				<?=display_str($Match['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Match['IP'])?>
-			</td>
-		</tr>
+    <tr class="row">
+      <td><?=$Match['Username']?></td>
+      <td></td>
+      <td><?=time_diff($Match['EndTime'])?></td>
+      <td></td>
+      <td>
+        <?=display_str($Match['IP'])?>
+        (<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Match['IP'])?>
+      </td>
+    </tr>
 <?
-	}
+  }
 }
 // Old emails
-if ($Old) {
+if ($Old ?? false) {
 ?>
-		<tr class="colhead">
-			<td>Old emails</td>
-			<td>Start</td>
-			<td>End</td>
-			<td>Elapsed</td>
-			<td>Set from IP</td>
-		</tr>
+    <tr class="colhead">
+      <td>Old emails</td>
+      <td>Start</td>
+      <td>End</td>
+      <td>Elapsed</td>
+      <td>Set from IP</td>
+    </tr>
 <?
-	$j = 0;
-	// Old email
-	foreach ($Old as $Record) {
-		++$j;
+  $j = 0;
+  // Old email
+  foreach ($Old as $Record) {
+    ++$j;
 
-		// Matches on old email
-		ob_start();
-		$i = 0;
-		foreach ($OldMatches as $Match) {
-			if ($Match['Email'] == $Record['Email']) {
-				++$i;
-				// Email matches
-?>
-		<tr class="row hidden" id="matches_<?=$j?>">
-			<td><?=$Match['Username']?></td>
-			<td></td>
-			<td><?=time_diff($Match['EndTime'])?></td>
-			<td></td>
-			<td>
-				<?=display_str($Match['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Match['IP'])?>
-			</td>
-		</tr>
-<?
-			}
-		}
+    // Matches on old email
+    ob_start();
+    $i = 0;
+    if ($OldMatches ?? false) {
+      foreach ($OldMatches as $Match) {
+        if ($Match['Email'] == $Record['Email']) {
+          ++$i;
+          // Email matches
+  ?>
+      <tr class="row hidden" id="matches_<?=$j?>">
+        <td><?=$Match['Username']?></td>
+        <td></td>
+        <td><?=time_diff($Match['EndTime'])?></td>
+        <td></td>
+        <td>
+          <?=display_str($Match['IP'])?>
+          (<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
+          <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
+          <a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+          <br />
+          <?=Tools::get_host_by_ajax($Match['IP'])?>
+        </td>
+      </tr>
+  <?
+        }
+      }
+    }
 
-		// Save matches to variable
-		$MatchCount = $i;
-		$Matches = ob_get_contents();
-		ob_end_clean();
+    // Save matches to variable
+    $MatchCount = $i;
+    $Matches = ob_get_contents();
+    ob_end_clean();
 
     $Record['Email'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Record['Email']) : '[Encrypted]';
     $Record['IP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Record['IP']) : '[Encrypted]';
 ?>
-		<tr class="row">
-			<td><?=display_str($Record['Email'])?><?=(($MatchCount > 0) ? ' <a href="#" onclick="$(\'#matches_'.$j.'\').gtoggle(); return false;">('.$MatchCount.')</a>' : '')?></td>
-			<td><?=time_diff($Record['StartTime'])?></td>
-			<td><?=time_diff($Record['EndTime'])?></td>
-			<td><?=time_diff($Record['ElapsedTime'])?></td>
-			<td>
-				<?=display_str($Record['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Record['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Record['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Record['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Record['IP'])?>
-			</td>
-		</tr>
+    <tr class="row">
+      <td><?=display_str($Record['Email'])?><?=(($MatchCount > 0) ? ' <a href="#" onclick="$(\'#matches_'.$j.'\').gtoggle(); return false;">('.$MatchCount.')</a>' : '')?></td>
+      <td><?=time_diff($Record['StartTime'])?></td>
+      <td><?=time_diff($Record['EndTime'])?></td>
+      <td><?=time_diff($Record['ElapsedTime'])?></td>
+      <td>
+        <?=display_str($Record['IP'])?>
+        (<?=Tools::get_country_code_by_ajax($Record['IP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Record['IP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Record['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Record['IP'])?>
+      </td>
+    </tr>
 <?
-		if ($MatchCount > 0) {
-			if (isset($Matches)) {
-				echo $Matches;
-				unset($Matches);
-				unset($MatchCount);
-			}
-		}
-	}
+    if ($MatchCount > 0) {
+      if (isset($Matches)) {
+        echo $Matches;
+        unset($Matches);
+        unset($MatchCount);
+      }
+    }
+  }
 }
 // Invite email (always there)
 ?>
-		<tr class="colhead">
-			<td>Invite email</td>
-			<td>Start</td>
-			<td>End</td>
-			<td>Age of account</td>
-			<td>Registration IP address</td>
-		</tr>
+    <tr class="colhead">
+      <td>Invite email</td>
+      <td>Start</td>
+      <td>End</td>
+      <td>Age of account</td>
+      <td>Registration IP address</td>
+    </tr>
 <?
 // Matches on invite email
-if ($OldMatches) {
-	$i = 0;
-	ob_start();
-	foreach ($OldMatches as $Match) {
-		if ($Match['Email'] == $Invite['Email']) {
-			++$i;
-			// Match email is the same as the invite email
+$i = 0;
+ob_start();
+if ($OldMatches ?? false) {
+  foreach ($OldMatches as $Match) {
+    if ($Match['Email'] == $Invite['Email']) {
+      ++$i;
+      // Match email is the same as the invite email
       
       $Match['IP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Match['IP']) : '[Encrypted]';
 ?>
-		<tr class="row hidden" id="matches_invite">
-			<td><?=$Match['Username']?></td>
-			<td></td>
-			<td><?=time_diff($Match['EndTime'])?></td>
-			<td></td>
-			<td>
-				<?=display_str($Match['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Match['IP'])?>
-			</td>
-		</tr>
+    <tr class="row hidden" id="matches_invite">
+      <td><?=$Match['Username']?></td>
+      <td></td>
+      <td><?=time_diff($Match['EndTime'])?></td>
+      <td></td>
+      <td>
+        <?=display_str($Match['IP'])?>
+        (<?=Tools::get_country_code_by_ajax($Match['IP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Match['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Match['IP'])?>
+      </td>
+    </tr>
 <?
-		}
-	}
-	$MatchCount = $i;
-	$Matches = ob_get_contents();
-	ob_end_clean();
+    }
+  }
 }
+$MatchCount = $i;
+$Matches = ob_get_contents();
+ob_end_clean();
 
 $Invite['Email'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Invite['Email']) : '[Encrypted]';
 $Invite['IP'] = apc_exists('DBKEY') ? DBCrypt::decrypt($Invite['IP']) : '[Encrypted]';
 ?>
-		<tr class="row">
-			<td><?=display_str($Invite['Email'])?><?=(($MatchCount > 0) ? ' <a href="#" onclick="$(\'#matches_invite\').gtoggle(); return false;">('.$MatchCount.')</a>' : '')?></td>
-			<td>Never</td>
-			<td><?=time_diff($Invite['EndTime'])?></td>
-			<td><?=time_diff($Invite['AccountAge'])?></td>
-			<td>
-				<?=display_str($Invite['IP'])?>
-				(<?=Tools::get_country_code_by_ajax($Invite['IP'])?>)
-				<a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Invite['IP'])?>" class="brackets tooltip" title="Search">S</a>
-				<a href="http://whatismyipaddress.com/ip/<?=display_str($Invite['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
-				<br />
-				<?=Tools::get_host_by_ajax($Invite['IP'])?>
-			</td>
-		</tr>
+    <tr class="row">
+      <td><?=display_str($Invite['Email'])?><?=(($MatchCount > 0) ? ' <a href="#" onclick="$(\'#matches_invite\').gtoggle(); return false;">('.$MatchCount.')</a>' : '')?></td>
+      <td>Never</td>
+      <td><?=time_diff($Invite['EndTime'])?></td>
+      <td><?=time_diff($Invite['AccountAge'])?></td>
+      <td>
+        <?=display_str($Invite['IP'])?>
+        (<?=Tools::get_country_code_by_ajax($Invite['IP'])?>)
+        <a href="user.php?action=search&amp;ip_history=on&amp;ip=<?=display_str($Invite['IP'])?>" class="brackets tooltip" title="Search">S</a>
+        <a href="http://whatismyipaddress.com/ip/<?=display_str($Invite['IP'])?>" class="brackets tooltip" title="Search WIMIA.com">WI</a>
+        <br />
+        <?=Tools::get_host_by_ajax($Invite['IP'])?>
+      </td>
+    </tr>
 <?
 
 if ($Matches) {
-	echo $Matches;
+  echo $Matches;
 }
 
 ?>
-	</table>
+  </table>
 </div>
 <? View::show_footer(); ?>