Add a couple working better.php pages

sections/better/better.php

@@ -5,7 +5,7 @@ View::show_header('Better');
 <div class="thin">
   <h3 id="general">Pursuit of Perfection</h3>
   <div class="box pad" style="padding: 10px 10px 10px 20px;">
-    <p>Here at <?=SITE_NAME?>, we believe that there's always room for improvement. To aid our effort in the pursuit of perfection, we've put together a few simple lists that can help you build ratio and help us improve our overall quality. Most lists feature 100 torrents at a time and update every 15 minutes.</p>
+    <p>Here at <?=SITE_NAME?>, we believe that there's always room for improvement. To aid our effort in the pursuit of perfection, we've put together a few simple lists that can help you build ratio or something and help us improve our overall quality. Most lists feature 20 random torrents selected upon page load.</p>
   </div>
   <h3 id="lists">Lists</h3>
   <div class="box pad" style="padding: 10px 10px 10px 20px;">
@@ -19,12 +19,21 @@ View::show_header('Better');
           <a href="better.php?method=screenshots">Screenshots</a>
         </td>
         <td class="nobr">
-          When a torrent doesn't have enough screenshots
+          When a torrent group doesn't have enough screenshots
         </td>
       </tr>
       <tr class="row">
         <td class="nobr">
-          <a href="better.php?method=encode">Encode</a>
+          <a href="better.php?method=covers&filter=all">Covers</a>
+        </td>
+        <td class="nobr">
+          When a torrent group doesn't have a cover
+        </td>
+      </tr>
+<!--
+      <tr class="row">
+        <td class="nobr">
+          <s><a href="better.php?method=encode">Encode</a></s>
         </td>
         <td class="nobr">
           When a high quality BD or ISO is available and we don't have any encodes of it
@@ -32,7 +41,7 @@ View::show_header('Better');
       </tr>
       <tr class="row">
         <td class="nobr">
-          <a href="better.php?method=snatch">Snatch</a>
+          <s><a href="better.php?method=snatch">Snatch</a></s>
         </td>
         <td class="nobr">
           Torrents you've already downloaded that can be encoded.
@@ -40,7 +49,7 @@ View::show_header('Better');
       </tr>
       <tr class="row">
         <td class="nobr">
-          <a href="better.php?method=upload">Upload</a>
+          <s><a href="better.php?method=upload">Upload</a></s>
         </td>
         <td class="nobr">
           Torrents you've uploaded that could be improved.
@@ -64,13 +73,13 @@ View::show_header('Better');
       </tr>
       <tr class="row">
         <td class="nobr">
-          <a href="better.php?method=files">File names</a>
+          <s><a href="better.php?method=files">File names</a></s>
         </td>
         <td class="nobr">
           Torrents that have been marked as having "Bad File Names".
         </td>
       </tr>
-
+-->
     </table>
   </div>
 </div>

sections/better/covers.php

@@ -0,0 +1,72 @@
+<?
+if (!empty($_GET['filter']) && $_GET['filter'] == 'all') {
+  $Join = '';
+  $All = true;
+} else {
+  $Join = 'JOIN torrents AS t ON t.GroupID=tg.ID
+           JOIN xbt_snatched AS x ON x.fid = t.ID AND x.uid = '.$LoggedUser['ID'];
+  $All = false;
+}
+
+View::show_header('Torrent groups with no covers');
+$DB->query("
+  SELECT
+    SQL_CALC_FOUND_ROWS
+    tg.ID
+  FROM torrents_group AS tg
+    $Join
+  WHERE tg.WikiImage=''
+  ORDER BY RAND()
+  LIMIT 20");
+$Groups = $DB->to_array('ID', MYSQLI_ASSOC);
+
+$DB->query('SELECT FOUND_ROWS()');
+list($NumResults) = $DB->next_record();
+
+$Results = Torrents::get_groups(array_keys($Groups));
+
+?>
+<div class="header">
+<? if ($All) { ?>
+  <h2>All torrent groups with no cover</h2>
+<? } else { ?>
+  <h2>Torrent groups with no cover that you have snatched</h2>
+<? } ?>
+
+  <div class="linkbox">
+    <a href="better.php" class="brackets">Back to better.php list</a>
+<? if ($All) { ?>
+    <a href="better.php?method=covers" class="brackets">Show only those you have snatched</a>
+<? } else { ?>
+    <a href="better.php?method=covers&amp;filter=all" class="brackets">Show all</a>
+<? } ?>
+  </div>
+</div>
+<div class="thin box pad">
+  <h3>There are <?=number_format($NumResults)?> groups remaining</h3>
+  <table class="torrent_table">
+<?
+foreach ($Results as $Result) {
+  extract($Result);
+  $TorrentTags = new Tags($TagList);
+
+  $DisplayName = "<a href=\"torrents.php?id=$ID\" class=\"tooltip\" title=\"View torrent group\" ";
+  if (!isset($LoggedUser['CoverArt']) || $LoggedUser['CoverArt']) {
+    $DisplayName .= 'onmouseover="getCover(event)" cover="'.ImageTools::process($WikiImage, true).'" onmouseleave="ungetCover(event)" ';
+  }
+  $DisplayName .= "dir=\"ltr\">$Name</a>";
+  if ($Year > 0) {
+    $DisplayName .= " [$Year]";
+  }
+?>
+    <tr class="torrent">
+      <td><div class="<?=Format::css_category($CategoryID)?>"></div></td>
+      <td><?=$DisplayName?><div class="tags"><?=$TorrentTags->format()?></div></td>
+    </tr>
+<?
+} ?>
+  </table>
+</div>
+<?
+View::show_footer();
+?>

sections/better/files.php

@@ -1,99 +0,0 @@
-<?php
-
-if (check_perms('admin_reports') && !empty($_GET['remove']) && is_number($_GET['remove'])) {
-  $DB->query('
-    DELETE FROM torrents_bad_files
-    WHERE TorrentID = '.$_GET['remove']);
-  $DB->query('
-    SELECT GroupID
-    FROM torrents
-    WHERE ID = '.$_GET['remove']);
-  list($GroupID) = $DB->next_record();
-  $Cache->delete_value("torrents_details_$GroupID");
-}
-
-
-if (!empty($_GET['filter']) && $_GET['filter'] == 'all') {
-  $Join = '';
-  $All = true;
-} else {
-  $Join = 'JOIN xbt_snatched AS x ON x.fid = tfi.TorrentID AND x.uid = '.$LoggedUser['ID'];
-  $All = false;
-}
-
-View::show_header('Torrents with bad file names');
-$DB->query("
-  SELECT tfi.TorrentID, t.GroupID
-  FROM torrents_bad_files AS tfi
-    JOIN torrents AS t ON t.ID = tfi.TorrentID
-    $Join
-  ORDER BY tfi.TimeAdded ASC");
-$TorrentsInfo = $DB->to_array('TorrentID', MYSQLI_ASSOC);
-foreach ($TorrentsInfo as $Torrent) {
-  $GroupIDs[] = $Torrent['GroupID'];
-}
-$Results = Torrents::get_groups($GroupIDs);
-?>
-<div class="header">
-<? if ($All) { ?>
-  <h2>All torrents trumpable for bad file names</h2>
-<? } else { ?>
-  <h2>Torrents trumpable for bad file names that you have snatched</h2>
-<? } ?>
-
-  <div class="linkbox">
-    <a href="better.php" class="brackets">Back to better.php list</a>
-<? if ($All) { ?>
-    <a href="better.php?method=files" class="brackets">Show only those you have snatched</a>
-<? } else { ?>
-    <a href="better.php?method=files&amp;filter=all" class="brackets">Show all</a>
-<? } ?>
-  </div>
-</div>
-<div class="thin box pad">
-  <h3>There are <?=number_format(count($TorrentsInfo))?> torrents remaining</h3>
-  <table class="torrent_table">
-<?
-foreach ($TorrentsInfo as $TorrentID => $Info) {
-  extract(Torrents::array_group($Results[$Info['GroupID']]));
-  $TorrentTags = new Tags($TagList);
-
-  if (!empty($ExtendedArtists[1]) || !empty($ExtendedArtists[4]) || !empty($ExtendedArtists[5]) || !empty($ExtendedArtists[6])) {
-    unset($ExtendedArtists[2]);
-    unset($ExtendedArtists[3]);
-    $DisplayName = Artists::display_artists($ExtendedArtists);
-  } else {
-    $DisplayName = '';
-  }
-  $DisplayName .= "<a href=\"torrents.php?id=$GroupID&amp;torrentid=$TorrentID#torrent$TorrentID\" class=\"tooltip\" title=\"View torrent group\" dir=\"ltr\">$GroupName</a>";
-  if ($GroupYear > 0) {
-    $DisplayName .= " [$GroupYear]";
-  }
-  if ($ReleaseType > 0) {
-    $DisplayName .= ' ['.$ReleaseTypes[$ReleaseType].']';
-  }
-
-  $ExtraInfo = Torrents::torrent_info($Torrents[$TorrentID]);
-  if ($ExtraInfo) {
-    $DisplayName .= " - $ExtraInfo";
-  }
-?>
-    <tr class="torrent torrent_row<?=$GroupFlags['IsSnatched'] ? ' snatched_torrent"' : ''?>">
-      <td>
-        <span class="torrent_links_block">
-          <a href="torrents.php?action=download&amp;id=<?=$TorrentID?>&amp;authkey=<?=$LoggedUser['AuthKey']?>&amp;torrent_pass=<?=$LoggedUser['torrent_pass']?>" class="brackets tooltip" title="Download">DL</a>
-        </span>
-        <?=$DisplayName?>
-<?  if (check_perms('admin_reports')) { ?>
-        <a href="better.php?method=files&amp;remove=<?=$TorrentID?>" class="brackets">X</a>
-<?   } ?>
-        <div class="tags"><?=$TorrentTags->format()?></div>
-      </td>
-    </tr>
-<?
-} ?>
-  </table>
-</div>
-<?
-View::show_footer();
-?>

sections/better/screenshots.php

@@ -0,0 +1,74 @@
+<?
+if (!empty($_GET['filter']) && $_GET['filter'] == 'all') {
+  $Join = '';
+  $All = true;
+} else {
+  $Join = 'JOIN torrents AS t ON t.GroupID=tg.ID
+           JOIN xbt_snatched AS x ON x.fid = t.ID AND x.uid = '.$LoggedUser['ID'];
+  $All = false;
+}
+
+View::show_header('Torrent groups with no screenshots');
+$DB->query("
+  SELECT
+    SQL_CALC_FOUND_ROWS
+    tg.ID
+  FROM torrents_group AS tg
+    $Join
+  WHERE tg.ID NOT IN (SELECT DISTINCT GroupID FROM torrents_screenshots)
+    AND NOT (tg.CategoryID = 5 AND tg.TagList LIKE \"%audio%\")
+  ORDER BY RAND()
+  LIMIT 20"); // TagList clause quintuples query time. Probably needs to be removed in future
+$Groups = $DB->to_array('ID', MYSQLI_ASSOC);
+
+$DB->query('SELECT FOUND_ROWS()');
+list($NumResults) = $DB->next_record();
+
+$Results = Torrents::get_groups(array_keys($Groups));
+
+?>
+<div class="header">
+<? if ($All) { ?>
+  <h2>All groups with no screenshots</h2>
+<? } else { ?>
+  <h2>Torrent groups with no screenshots that you have snatched</h2>
+<? } ?>
+
+  <div class="linkbox">
+    <a href="better.php" class="brackets">Back to better.php list</a>
+<? if ($All) { ?>
+    <a href="better.php?method=screenshots" class="brackets">Show only those you have snatched</a>
+<? } else { ?>
+    <a href="better.php?method=screenshots&amp;filter=all" class="brackets">Show all</a>
+<? } ?>
+  </div>
+</div>
+<div class="thin box pad">
+  <h3>There are <?=number_format($NumResults)?> groups remaining</h3>
+  <table class="torrent_table">
+<?
+foreach ($Results as $Result) {
+  extract($Result);
+  $LangName = $Name ? $Name : ($NameRJ ? $NameRJ : $NameJP);
+  $TorrentTags = new Tags($TagList);
+
+  $DisplayName = "<a href=\"torrents.php?id=$ID\" class=\"tooltip\" title=\"View torrent group\" ";
+  if (!isset($LoggedUser['CoverArt']) || $LoggedUser['CoverArt']) {
+    $DisplayName .= 'onmouseover="getCover(event)" cover="'.ImageTools::process($WikiImage, true).'" onmouseleave="ungetCover(event)" ';
+  }
+  $DisplayName .= "dir=\"ltr\">$LangName</a>";
+  if ($Year > 0) {
+    $DisplayName .= " [$Year]";
+  }
+?>
+    <tr class="torrent">
+      <td><div class="<?=Format::css_category($CategoryID)?>"></div></td>
+      <td><?=$DisplayName?><div class="tags"><?=$TorrentTags->format()?></div></td>
+    </tr>
+<?
+} ?>
+  </table>
+</div>
+<?
+View::show_footer();
+?>